From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DC9C7EE25 for ; Thu, 8 Jun 2023 23:29:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26A8E6B0072; Thu, 8 Jun 2023 19:29:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21AA66B0074; Thu, 8 Jun 2023 19:29:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E38E8E0001; Thu, 8 Jun 2023 19:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F319D6B0072 for ; Thu, 8 Jun 2023 19:29:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C1C4E1A036A for ; Thu, 8 Jun 2023 23:29:24 +0000 (UTC) X-FDA: 80881174248.07.535F9B2 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf19.hostedemail.com (Postfix) with ESMTP id 057751A0008 for ; Thu, 8 Jun 2023 23:29:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=GKUqaxYp; spf=pass (imf19.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686266963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6RGbjUYsdaohPZQXqH0ffB3I+/zH7l+P+guRk55pY3o=; b=wqjFMRPp1rFAC1gCwPseqpZYksfDiIsvMAb2ngoVODDcdaQ8TgF5ywlMOMu4SqIoQGzrPD J9XBdfYtd2n6xN6b04zrYX3aeRUvC80pdxTKXPQOmIVpTcjDxxd1BZv/w4rHB+/sQsiJgq apTwRJp/f8s9dcoaqawHz4gi9TCYVL0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686266963; a=rsa-sha256; cv=none; b=TqhyBFLkwa8dXuZiaucli4Uu54uSR6R0GZA5LPVT8rpr/dpW/wWExLCqpVRUzZ4vq5BVIt lCseGLuVv5GsFUoEk18wGzm4NLKRmpI/Zvaj9lYiSmI3/EpTI2bdhjgCmZVhxg9eZzPfhp SRj22jzQodkoDAPU1Zkv2eZHMScFkYM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=GKUqaxYp; spf=pass (imf19.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-65292f79456so904798b3a.2 for ; Thu, 08 Jun 2023 16:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686266962; x=1688858962; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6RGbjUYsdaohPZQXqH0ffB3I+/zH7l+P+guRk55pY3o=; b=GKUqaxYpA9sPWVTJUqhY/WvUJd0oMJh68pPhWRdgURVT0nWmLLk+PH0CZGMNu9NA5Z bRiLFi1+g5t3OToeIuLBoxouHAfU/mDzBROQ7M/Tsef1mypcXnCe8LHxoBxLOrnM6ZbM 4qfiJ87XgvvzdG45loNAZ4ywZD1ZcvLtxj+IIyoilamuFhZLXVq+SmbFp1cwklOXpCuI yEEPvPJpyQ5KGkMGD6k2sp8h4rNxvLBHg68PEehqHNEXuLkCIioiOmhVzjyKekLNCh4n fp6Ni/Frzf10PCiBBZbi7+BkpecMiiJJcRMZP40H3H/+HasliRX+d3grVqDxmZpSIs9v CZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686266962; x=1688858962; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6RGbjUYsdaohPZQXqH0ffB3I+/zH7l+P+guRk55pY3o=; b=P2G2/pyjwaex3kHlRiR4xFjlg/MasTeKMdmOPCAlmsRXIDVmo4Xq8IUvfbEnFIeY+p rMBZ8e2yKWBatR/+WqryMiHqwR6ZFUNt/3xHoKW4S3W8ISGDIhtdeJOJZhAlmGDvA5FH 4P1jvz+P1RlJitnDG/W5ex0Ctr1sSxt8Gg5NUVr4XOJwQWJGDUOJNvkJWiJpYEWnh4i2 SuAB2f4jV8GT29aPH3fQ198y4sOEI4pAvtUMMISToiO6W0SLOlZkNV21hGJTzGw+7+XX sd0LUF4guhcF8NhXe5zkdE5SJnUmGvAtl7dhQ8AE/oRpMB5dsu0LwbkrDeaLx15JTIog 6taQ== X-Gm-Message-State: AC+VfDyBkmou7TYsS4kxbapS2vIAM2Mk6VQNnKfYLPqHLRHuvyY81azT 28BDYvsJnFg6475q1jQnPME= X-Google-Smtp-Source: ACHHUZ5BemoIUtUyIQMWaimD9moPUg4gS1XMy0WBlsJ68BJAUvGHQpvMYcO3s/oFNl28ctNzJaryZw== X-Received: by 2002:a05:6a20:e617:b0:105:dafa:fec2 with SMTP id my23-20020a056a20e61700b00105dafafec2mr4523293pzb.53.1686266961618; Thu, 08 Jun 2023 16:29:21 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id q24-20020a62e118000000b0063b85893633sm1535576pfh.197.2023.06.08.16.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 16:29:20 -0700 (PDT) Date: Thu, 8 Jun 2023 16:29:19 -0700 From: Isaku Yamahata To: "kirill.shutemov@linux.intel.com" Cc: "Huang, Kai" , "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" , isaku.yamahata@gmail.com Subject: Re: [PATCH v11 08/20] x86/virt/tdx: Get information about TDX module and TDX-capable memory Message-ID: <20230608232919.GM2244082@ls.amr.corp.intel.com> References: <50386eddbb8046b0b222d385e56e8115ed566526.1685887183.git.kai.huang@intel.com> <20230608002725.xc25dantcwdxsuil@box.shutemov.name> <19ea7470e9d6fa698f9ad7caff3279873e530a0b.camel@intel.com> <20230608114128.vu75wlcojpyjak22@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230608114128.vu75wlcojpyjak22@box.shutemov.name> X-Stat-Signature: gdydq647s69q6f41mf6mx11fp5eiyp87 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 057751A0008 X-Rspam-User: X-HE-Tag: 1686266962-178433 X-HE-Meta: U2FsdGVkX18TvvrZIk2HTY3MWLDYTZaIIeMrkz/NTkws0/05kXrwRp8hde5dce2hgDgOBvmy4ceAu4DMv+yNs4oPeWEY1vJLdAXu6WtywRjXAOQs9yeKbejrwtK5JSNusGnoiwCO3MP5p2RLPJO9GgMHDn1WKoM/SJwHzXIekbbLxu3c8ibRx4m5OivryjbwKZf0eAc5nt6RQD6KCSvSFD4zT2GSekZASHjvJTPqhonykiXuVCwLQblc9QNaH44uDUWYFjH+s5o9xRcoLB9AI0o5FpwBk0IGt7A8duQPs7OH/Iw9igW752jXTVnPnXPtV8GyLXe7yJLoC6gXPQKIoI72LycD95LfX24q9/q2AZQpjA4DKab0yYUhZj38o5pEUZU6aAsgg9SLyTf9WxZNHM3qCzFj1YUx6hshgrgpic6DEfqBNcaf4CH/Mraj1mI/vgipFJmPUwaem6U+FbRtj82oynurxqeUitxKwOW53JwLCoUYHnT9knb02izC5tbrilt5wgz3pwVoPiKjLvPJKviMzKSGQXtn1b6wa6GkoUaf+v7mGf/mcuIpDb83pYR/3xppiE1Kut7wo/R+BVnxVQxMQPHPqUUNQbWsz3miq317/j+kVmLoEimUGRZb5D7r8NCYyAQrwJsrGw1aIkc3JR0NW9CIE+SUOfUZ5eygSorAySumBzdBkKG+oFaHQCxiNaq+dGifaR4lMFTO/xTryjK9TG6Xy7YeLpTw1Q0A+tGfKmclArD2GPwLJ3+44wgsOi9rlkdbufQbFCeXnyhXBzS1aHvngv3bilStfGXBwviOtNlH2rJ4NCxbITzWgPK+xnkHRG/5QMaC0sJt0gXkqVJe7ANli/4ANtKdStFJLV0URJcP6m7mZ1uRr0jZGkusWNyNQ89ohCyQRVnG8Liz8UwOva+LtaZtOvEObrgJAM07xU7GMW2IDVbJvD9phSvqvWJb+TIKXNCwYHgGJnm EtKwCbuR VxVPua8pK+w1J4bRO+bnsMvsdaUYPZJHAy4xo2Yi5JryzYGPOjSsTiUb9uUg8zOeJWtwFzsza8wJI428vi5lGZkNspS/hJE3ks1MDh8IBjicYoycUrZ6QwuthhNS7rV4I+RTmuUtjq7mlMTA5dmjNEtVkGKh5kFBT7ySbUc9i4lmFIOg+cd6HzPCdBGUBXWC6ayBP9+q8YxKGtNe1updQ/KIte746ZVUVb43ruNBbD817X8XofvMSMqDsKM/O2crYRLzul1iiKIpIO41i7GZQc5/dtUMg7+q8o34UlOeZ+2uaGN2uLVFPl683nZ954xVXvbN22y87ILBpQ2rbvY6uc3UGP1riEidXChUIIC44L4Jiiwcp4K6EWgicJlMDk7q6biUQhSrHHiHCAFkwuw9oNY6/bYY+rSb3qeEobGNiNCzkt20D7mVERQ/rClD42e2sWf5ORUmmiDH3j8WtTct1ahXzY5/RA3Pt+CXCdMwo4Ujn0Du6mTDNMUkjr9uWPxJx1TZpFELQFnY07+Gi2xYwhuOjqj+D/eql8upwGGwKVyXpZw8YRPluFnuc8s/V+q+sTlXSMsX70UQe3CM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 08, 2023 at 02:41:28PM +0300, "kirill.shutemov@linux.intel.com" wrote: > On Thu, Jun 08, 2023 at 02:40:27AM +0000, Huang, Kai wrote: > > On Thu, 2023-06-08 at 03:27 +0300, kirill.shutemov@linux.intel.com wrote: > > > On Mon, Jun 05, 2023 at 02:27:21AM +1200, Kai Huang wrote: > > > > For now both 'tdsysinfo_struct' and CMRs are only used during the module > > > > initialization. But because they are both relatively big, declare them > > > > inside the module initialization function but as static variables. > > > > > > This justification does not make sense to me. static variables will not be > > > freed after function returned. They will still consume memory. > > > > > > I think you need to allocate/free memory dynamically, if they are too big > > > for stack. > > > > > > I do need to keep tdsysinfo_struct as it will be used by KVM too. > > Will you pass it down to KVM from this function? Will KVM use the struct > after the function returns? KVM needs tdsysinfo_struct to create guest TD. It doesn't require 1024-alignment. -- Isaku Yamahata