From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 062DBC83003 for ; Thu, 8 Jun 2023 22:52:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 649A96B0075; Thu, 8 Jun 2023 18:52:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9468E0001; Thu, 8 Jun 2023 18:52:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E7C06B007B; Thu, 8 Jun 2023 18:52:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3CF3D6B0075 for ; Thu, 8 Jun 2023 18:52:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1112B1C77F2 for ; Thu, 8 Jun 2023 22:52:58 +0000 (UTC) X-FDA: 80881082436.19.D328EA1 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf08.hostedemail.com (Postfix) with ESMTP id 72547160008 for ; Thu, 8 Jun 2023 22:52:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ORpliQHO; spf=none (imf08.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686264776; a=rsa-sha256; cv=none; b=7zwkvZ1+vKc3Wqbnawqs9ScYVTZT/mdEO4y6uXQcqOnndlZ10qoWnTQW9Jg2Xl2wInz6Td 9xnF7thRxrnfUUbBqjveojOtj5WN+nTYZPQDNYiG0NGsCJx5lDBoFc7vsRcfFu0R8NCrJd k5R3jkP2fNtESfbmIWWcooFaQBxdT4o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ORpliQHO; spf=none (imf08.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686264776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k4Y7WiwayXbM3BsktTRl5XMUCYR8lzlMmncKAkkX8tw=; b=5xV3iEn47OmEqgnht5LZ2fveyG+ZZASAoNME9HuTWwoa3ecyt/0e47LOvZ19ucOtyWt7Mm vP9R5Iktbdl+RaHBtfLpjjye1UszahvmYF/CqUvM9GT1zzUOmh94X8bYkOZ+C6LQA9qVdm z2CrxgHjAWJaOoKGTvJKeGsR6VOdZ4c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686264775; x=1717800775; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=21zWUj9vAPSBXRfUhmtCO8AmWkPwEC5zfq8Lbo30rO8=; b=ORpliQHOheQuH081SOU+tB1p4V5ZTgNm40OTScC4+WZsfrhm+m/ayRTx XWWroUzUucPaIXXo2N8nQYWm1FM5m7zjRTzdOYNEl8KkaVVcZy3hIgcV0 p8IHeJnb2j6zNdlluyTte41lNWqohN6A48tmr53u3ewaEcMnPQDVHh7aX JEbblyNdxSaYnIP7m3TxFgYdcGelvvtqcyHqp7ikk6QI9R5AtgS+hiZBU XXbBQWWCjL5Q1lWjWE38OWxx1zWCJBg71Euv+2KSAnKHfk68hBRRYOe7i pOLl7GFbepIin5cU03//v9TdoegRW70Q2z2owAZ1fEH9m3cabkGklaFCO Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="342129259" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="342129259" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 15:52:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="780071573" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="780071573" Received: from fgorter-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.59.89]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 15:52:48 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id B87CF104C0F; Fri, 9 Jun 2023 01:52:45 +0300 (+03) Date: Fri, 9 Jun 2023 01:52:45 +0300 From: kirill.shutemov@linux.intel.com To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v11 10/20] x86/virt/tdx: Add placeholder to construct TDMRs to cover all TDX memory regions Message-ID: <20230608225245.rvygi5zkr2niolsj@box> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 72547160008 X-Stat-Signature: 3dme7nao7mi98mat4ctpf15uqedtrt58 X-Rspam-User: X-HE-Tag: 1686264775-379531 X-HE-Meta: U2FsdGVkX18x6ABKDWlCm9BMszuV/HNeO6nT3geHl8Wo+RHqcunQoZyQ432q/TQrPGpWkceROaUREZwNMInzWk4oQfzkW6iaQMTnMpoCn2tzSJcMP/4tTsLKHfANvYADglPHaxXfEbp5Me3OmvL5lUWoZSk34ROc2w25d1uIuXZq4yYx3onm9ymhpB8taWw6wCkIdjndQUON86x3TeMKf4LA8n7ahcZoynGVIc4gRZT45i6ceOO3dg6Bi8sOGpDu37S4v2GcIHz1qZSNA9OjGKZeKs3fXuaVc0sncJKt7rBlSBZ5bcB4bFdt2AMOp+JwoFKrWp5ycxqKxG4LxSANCkj02Pf+QmLQsltStdmuj6ff4CSoDquQXVVbcFMQ744rtKFLceGhQwwVVkl37ZeJJF85yhh3s19HQYdP1yBKLH11nz8N7H8AeqXt3RcYFV9vW0eci+AMehHBIAXekKCQ/cKl0DjKpqAMzEZM1Cir/uRSwlU4O29vnIYhUaFf5eewWpA8EYrO+zMcGxNWDURyZKxyDIU9MTidxBorwpzJAPQtVa/2Pl7YaK6AVWbMbEmrenMOyJwP0KvAgTneMjCPiCl3/BLE6XbV0ODSMrWjXW3GGGmzmR8gEPBcZHXthLM+2eWpvCER3yxZdNUUzFD81rH0FntIoal3zgcSAAhgURIkoZyEKqZtNNWy21YwYBQOhtqEFky+ZWBEi+8pQhvDVh6BRwDQmALTpoHN1In4JdNdRf+CXR+Z+ACvhohnT5Y2b1q1fe8Kp50w5n2vfNo51P7IfTidnGrrwfnooOT+xUsYjmRoVsSR6hymLovWDUUZky/gozQimNfzo75AVbkb7W1hlyMmO7gnViy7JTRFSXrJaHgOumoj2/8uXRdizjewOcRAe6+Km21kXUowK037Mjy43B1YQI7DMICZPn1wrzDrN1bWWf8DX3YrdB6LyBNE4Cpwx7tRKr8qyXXDVN2 tHMhAMYR 1JSG6d3qi5SA1qLBrltFNvnwlgowqAuxsuFZsqXqPez0Enk5jRCj4Uuk2nFqWHO+1MJ97dTQxFQgptYWppDMvO/2IXryeQugZKWrxwtZvA5P4sgHR1S+Eht4jyRbkI/sHprAQEBY73CjCbJGZNuTAJzptAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 05, 2023 at 02:27:23AM +1200, Kai Huang wrote: > @@ -50,6 +51,8 @@ static DEFINE_MUTEX(tdx_module_lock); > /* All TDX-usable memory regions. Protected by mem_hotplug_lock. */ > static LIST_HEAD(tdx_memlist); > > +static struct tdmr_info_list tdx_tdmr_list; > + > /* > * Wrapper of __seamcall() to convert SEAMCALL leaf function error code > * to kernel error code. @seamcall_ret and @out contain the SEAMCALL The name is misleading. It is not list, it is an array. ... > @@ -112,6 +135,15 @@ struct tdx_memblock { > unsigned long end_pfn; > }; > > +struct tdmr_info_list { > + void *tdmrs; /* Flexible array to hold 'tdmr_info's */ > + int nr_consumed_tdmrs; /* How many 'tdmr_info's are in use */ > + > + /* Metadata for finding target 'tdmr_info' and freeing @tdmrs */ > + int tdmr_sz; /* Size of one 'tdmr_info' */ > + int max_tdmrs; /* How many 'tdmr_info's are allocated */ > +}; > + > struct tdx_module_output; > u64 __seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9, > struct tdx_module_output *out); Otherwise, looks okay. Reviewed-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov