From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB11C7EE37 for ; Thu, 8 Jun 2023 22:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA47F6B0072; Thu, 8 Jun 2023 18:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B55F48E0002; Thu, 8 Jun 2023 18:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43058E0001; Thu, 8 Jun 2023 18:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 942506B0072 for ; Thu, 8 Jun 2023 18:41:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6099E140287 for ; Thu, 8 Jun 2023 22:41:08 +0000 (UTC) X-FDA: 80881052616.13.792939D Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf18.hostedemail.com (Postfix) with ESMTP id 47C561C000F for ; Thu, 8 Jun 2023 22:41:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bUAaMgoI; spf=none (imf18.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686264065; a=rsa-sha256; cv=none; b=QjRnFigUizGJtbBM4VZuDACvQg80BBkTsIPpl48O0eG0VxJG/4HjQr4lvOR+VCZn5kZTu4 DuV8EhP228LKYraOsbwv7xaFMmuH3oUlyCBDGXhk8W4yuwdIqb6/7PCCpEW3cL9bkcVpvy 3ld/bSNUByTlP/k0jSK2CnxblQS4SY8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bUAaMgoI; spf=none (imf18.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686264065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EOsm2MwiOHSdVaG2w8eE4V4EjIcvyWW9dgXoHxRbE0I=; b=L8uMpREhQc23wFbAAYT8h26qewgBAUeWIRiWM++iooxTdibT3xtXO9vSQFKL+pyk9r6oIr fdhgua5IqtcZZAPFrlG53EM3gmlht1/NiV06ioH0614JOUdwEcfFUJ1x//aLT5jMVvCaaW PtaClHZz00OObIh/QTtSwzciwRBJ/Xg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686264065; x=1717800065; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HWH/BChFipfANutgTqAIw2nFszN1k9sN0DS13QIpLeQ=; b=bUAaMgoI85qgDjFudnjvlkbgAtgAlZge4ZYCjN7XJZ5s5iyJiZBZYhqv kf0MMFyw/S98ju7V1V+VEw440VntlMTlEixbRcyvp73TOxeAZl0aoJEc2 sk3rw8slmGgbY5OPZNMLaRvthWdzEkhyGINhUe5EySRRN47HImNi2RUyX dAKCMWHwqX+auHXrggvdZwLnJ8K9f4ZDHtF3xYDtapBvxh5jcdisGTyW8 BrGVd36qG1vIIJAfXPfiDrQ9qxcISnrhNSuAPPGp/maY22SIP2m5op8Zg SzBKsuTnf8rQjFA/Ngm2X21ed7RYwbasbx+7f9NB4vMF93FHIM5N6mzqx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="421040866" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="421040866" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 15:41:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="775264650" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="775264650" Received: from fgorter-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.59.89]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 15:40:58 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 0BC00104C0F; Fri, 9 Jun 2023 01:40:56 +0300 (+03) Date: Fri, 9 Jun 2023 01:40:56 +0300 From: kirill.shutemov@linux.intel.com To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v11 09/20] x86/virt/tdx: Use all system memory when initializing TDX module as TDX memory Message-ID: <20230608224056.2j524gnkrdjtirti@box> References: <468533166590ff5ed11730350c4af8cdb0b99165.1685887183.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <468533166590ff5ed11730350c4af8cdb0b99165.1685887183.git.kai.huang@intel.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 47C561C000F X-Stat-Signature: ckz5586itamd16tw9fxfbki8s5ef9e8o X-Rspam-User: X-HE-Tag: 1686264065-670770 X-HE-Meta: U2FsdGVkX19cOU77PJaTCFatBacVgRcsZszXSfF35EgyhSLZ71LklPIPnHB0CM4xSo4ZolNgzxBPjKyoiigxnFYktJe9DIzq9dAvu70MGpdiApKJNhuBYuAAyV/G7FBEftaRLmLQnAZxoobZJ+f1a7DYLQT8fmdI1HOOUAMqaI0wLxHfhTXI3egXLXDcABpn/ggSPFX7OVrbk20hYiPBmmQ9k15qeu69hUAc/LPxKvtYLa/WuDdf7lOrYaOeVSrq+bfrcKahZJcJqptEes1bkAcaQ/V3vrUneEmHMoVOeF1MM/o896A4QhAw9eCdDNwFEckO8u3JIIXfzLmZgeDQqLOyg3sZbUazeNYAYxeAyK5GiAitgvhCkXzcvq2Aha3iiTO3fGxAPSfuvvBVa5R+1I5XeKma+fWFtFucV84piISfnZNqVMt0lg2m4yLxXzpt64S3zHzkUBQL9ODnC+qv2m2YS9YkDD/tbG/tDuvlT1oDNwY+pnIS4A3aVsjmsh/+xRU5HslyjdIq8GUWy0obVnjoD5+hmO/X1W/lRpvAnHufy/3tUlLOqez0GY97IMgDxxriXtwMMnVe59DkQhCp7Zfzimo3i8c1SP5knT4yumn3UjDAB0JL65I8yxHI0lXEuVzp/1kGNasibJL5EpIanFEVdcw0Uzc1TYSFAo+JsQgWJGzH/6HsGuyXZC/3vU17FozYqFWbpJ13CYLnVCC85tDcHfJLrzSl3zQnRi2oZfuoOixDRF6FVumsxg+kfv9HVmeOEC/sA5BnNYsxsvn4efrpcp6jw3K0zX23m0fYvgzUKG8L6oAuI8us117PB0uhNKd6WJEYSGSr/ZZZg6eXYgjJojzlsJBta3nrbd1MzO1rdv2L29rC01wRhjXCxAz7XVUtVG3Xo8P68WtLdKvj1K6wMQbqdRAPhUlNETAe45tc+fx1ZYd89zdqSBITwqZf9KkG+crMAa5UT1lkYPu 3SzPwFyd +A5Iwtx71g+DloNR080R/IKsN5BT0kzfqIW7thx4nDSdY8knGpQEeninU93yuuaYv7ICQp2MVk/fvH7lXOzVJLHoEEXPoUw69r3pWAPHbTB+uCaOozF/6iXH4rZaxCSuI0eEw+16DZKbkP3GzQS0y2jDxUhalGfWeJzEUUL0rIok5lrbSw5vQgfDNmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 05, 2023 at 02:27:22AM +1200, Kai Huang wrote: > As a step of initializing the TDX module, the kernel needs to tell the > TDX module which memory regions can be used by the TDX module as TDX > guest memory. > > TDX reports a list of "Convertible Memory Region" (CMR) to tell the > kernel which memory is TDX compatible. The kernel needs to build a list > of memory regions (out of CMRs) as "TDX-usable" memory and pass them to > the TDX module. Once this is done, those "TDX-usable" memory regions > are fixed during module's lifetime. > > To keep things simple, assume that all TDX-protected memory will come > from the page allocator. Make sure all pages in the page allocator > *are* TDX-usable memory. > > As TDX-usable memory is a fixed configuration, take a snapshot of the > memory configuration from memblocks at the time of module initialization > (memblocks are modified on memory hotplug). This snapshot is used to > enable TDX support for *this* memory configuration only. Use a memory > hotplug notifier to ensure that no other RAM can be added outside of > this configuration. > > This approach requires all memblock memory regions at the time of module > initialization to be TDX convertible memory to work, otherwise module > initialization will fail in a later SEAMCALL when passing those regions > to the module. This approach works when all boot-time "system RAM" is > TDX convertible memory, and no non-TDX-convertible memory is hot-added > to the core-mm before module initialization. > > For instance, on the first generation of TDX machines, both CXL memory > and NVDIMM are not TDX convertible memory. Using kmem driver to hot-add > any CXL memory or NVDIMM to the core-mm before module initialization > will result in failure to initialize the module. The SEAMCALL error > code will be available in the dmesg to help user to understand the > failure. > > Signed-off-by: Kai Huang > Reviewed-by: "Huang, Ying" > Reviewed-by: Isaku Yamahata Reviewed-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov