From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84C4C7EE29 for ; Fri, 9 Jun 2023 00:27:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CA778E0002; Thu, 8 Jun 2023 20:27:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27ABD8E0001; Thu, 8 Jun 2023 20:27:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 141D68E0002; Thu, 8 Jun 2023 20:27:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 03AEF8E0001 for ; Thu, 8 Jun 2023 20:27:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B649E12028D for ; Fri, 9 Jun 2023 00:27:28 +0000 (UTC) X-FDA: 80881320576.05.1FE8EC3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id C6DB220015 for ; Fri, 9 Jun 2023 00:27:25 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qovGY+0h; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686270445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nrdo84J0X8jc5B7eyB8R3RUmnR4HEezHSF/AurFo3mQ=; b=r0+zroRndImK4LaXs6xRg2yoLP7B8UD0kw7ybPkj77MOMcM4FVoaGUCCucjg5En/0wsjvd hMp7eYIImz0cC3LwsTcKe4ceXXOn8iNvuppdvwCLsRsW23fu6ah8I2vD6fpP9Y6VwwWu1i +j/2pu3+j4mquGDjOjRdgwmBlg9ZTco= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qovGY+0h; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686270445; a=rsa-sha256; cv=none; b=vN6ifSh5yZOqMBYniJjbh+MsyFkYgsBPrXXfT6k4GzgP7bl8/pSJ/eowXrd2e4EagZkFcE JdV+J9rqCwQgoLh04PJ8J4xjhKPL7+n9N+nbQ2vX+s7eIDm5nPy4sIX+AhEOR9jquU8r/a d9U1opyIua8ioid3yCjLC1rZsOj9obQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A4AC96524D; Fri, 9 Jun 2023 00:27:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D51DC433D2; Fri, 9 Jun 2023 00:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686270444; bh=SIg2qSZ9l+pY1OkA6HENpenV0b7K5waTnRvy/sKwjlM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qovGY+0h9kLFkv8QAsPqRiqvTog85N6Irziw8/5DXTE+XQCqe2huwuR906/zl7a/x Ho4FNOd10FP9DQauKymXsDz+ZhYXwSlGn5zAh+4ePggbfsi6GAzK1/KNUuA5lu+mB5 pWOAXh7/CxArWsHYtqr/+ee3eOzQjML/D1WpI3fQ= Date: Thu, 8 Jun 2023 17:27:22 -0700 From: Andrew Morton To: Dave Chinner Cc: Theodore Ts'o , Roman Gushchin , Kirill Tkhai , vbabka@suse.cz, viro@zeniv.linux.org.uk, brauner@kernel.org, djwong@kernel.org, hughd@google.com, paulmck@kernel.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, zhengqi.arch@bytedance.com Subject: Re: [PATCH v2 3/3] fs: Use delayed shrinker unregistration Message-Id: <20230608172722.d32733db433d385daa6c11a0@linux-foundation.org> In-Reply-To: References: <168599103578.70911.9402374667983518835.stgit@pro.pro> <168599180526.70911.14606767590861123431.stgit@pro.pro> <20230608163622.GA1435580@mit.edu> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C6DB220015 X-Stat-Signature: juzqy1191774m97yqx55gwcpkkkcgmyb X-HE-Tag: 1686270445-289054 X-HE-Meta: U2FsdGVkX18jFjD5SSt+tnxdgaR4ar/N5ghS+vEfPuEiabZ9yWuBz7cIS+7GNeZKKC585XfHjQhsJZlVjYd6RBBam/8mPukkKh6lIj16AE0zxQG8FGcbs1wLlGDs/Eb/mE4Gbu5lGUDAfwY/i7+5loq7f8AcA+j0JXI9HNjk+I4kqKiNQbGptG/vgxV1PWxSsZNHndLqBS+lcdmFSmwSHa/HFuV0pa+qhRaiTZxVKSPeDoHy5ZziOm26dlZ5hQDKgx0Uo4WPtBhb9DvenvGfgdQhgZIEFLu0xujvevUTYDCsi7X0p6vUV1hJrvjwUkmizSyMPz28ekM/Lt+apXGeONYCA0Puv/G+ynK2uOkUrzHUdo2BSgX0hgFaECliIKk8pV9h/JmFLGFi7XzPtaJTxT0kAoxoKExpJidnCb0sF4OUg7y6MbWG/MK684Tw5lmDCVBZdz1+6KJTaSWXOTmlGaxefFYS+s4tcbPYE36RM5bcYvdaIJ4DgxU2pBDJkYFC8JFZdYLPd0gBDtqZ9zV2cNCofuqmP9Nu5PZ3W4XK6mctjMNGWtQSOvpBgsAg01/nbITazk1eEBYSCDqUDav4affM0lkk9AYGTXaa5JiX6W+iy3kW07paYirZpnTJ1DQrSVydWn8xCk8O69/rJnFh+OgH9WCWcXcnijBdeTnhgZYRNNPse/H52XWKUaalk++5Sio3eTK0tTDErDA8AshLPZm0V/4l+EFk3gmx+vWnvk2y2G2Apmb+SZERKNgLfY4dQ98YlFxnNY1zw7wytkRDQQj8/6qAO63HWNHapBElhBGgqNWQwTJN+UF6dfBWFo/oTAWq3QkkhO/xYC+vgMVgskyraxuXDywHqouE0mvdE1nwPuJEmnnmcuKaCDz96MNOqWSBDDYP5U3iTPvlw/XGWlBWq4XVeD/y2NdZcnaadz6U7OmlCTsE1eUDrDiMtyUcgrBlRy2O15S6PI+1ZEV JwhWfT/g nwVbV9c9CkuDCgrgR7bdGsj9VDMr71/m2B7dO9rXP4pGxwZPfa93RBxoGj2WaOcUtf0uFVUjKpd17eEVk2jnX3s7MpdG0+Ok5miGJ5PNPmmYJ9BVUoVCnknvgYnP7Hij92FGP+6e9xirV0NPGwmAq+FT+Is7gDCNBaBl7RhAVTGo6Zt5PK9xSEMCqc2uIk942v8dUqY7sJdc3tUCYFKeGGsytqpfSFz0ppC/jZOK7WGQF/gVxWO3YCcrgCLxmS5hBti+TKpixyFa3JXyrqIVc7LoEoo1jletqpWSdfQV9HvuwH+btLDl8QDzeJO5Lv7ysvFJqx2CaU/QxscREx0q1ek7EPZA0WWsU+sRgTXzcB8xIRABmyUwDgO+eNl9im8s52AONGsQJtS8y5aTQfo/Tn79HJ03YI2iVZGKB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 9 Jun 2023 09:17:54 +1000 Dave Chinner wrote: > > Given that we're at -rc5 now, and the file system folks didn't get > > consulted until fairly late in the progress, and the fact that this > > may cause use-after-free problems that could lead to security issues, > > perhaps we shoould consider reverting the SRCU changeover now, and try > > again for the next merge window? > > Yes, please, because I think we can fix this in a much better way > and make things a whole lot simpler at the same time. Qi Zheng, if agreeable could you please prepare and send reverts of 475733dda5a ("mm: vmscan: add shrinker_srcu_generation") and of f95bdb700bc6bb74 ("mm: vmscan: make global slab shrink lockless")? Thanks.