From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BC2C7EE29 for ; Thu, 8 Jun 2023 16:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACE76B0072; Thu, 8 Jun 2023 12:10:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35EEF6B0074; Thu, 8 Jun 2023 12:10:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224F08E0001; Thu, 8 Jun 2023 12:10:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 128CE6B0072 for ; Thu, 8 Jun 2023 12:10:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 722A5160327 for ; Thu, 8 Jun 2023 16:10:07 +0000 (UTC) X-FDA: 80880067254.28.24089E4 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf13.hostedemail.com (Postfix) with ESMTP id 2FD9F20015 for ; Thu, 8 Jun 2023 16:10:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=aqqlosKf; spf=pass (imf13.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.182 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686240605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Loo5qde1he69f2u4i/ib9ZVM0psMD7Cg0M9AatqdFv0=; b=R65PeyClmoxM0wu0nj7e3c3LBYDMfZFGIn1u07/mVr6jYG1bCNE70sR+xHDJj2pzMydKVn lU0fQ1H0b8h0ycPSVM73zv57yWJ4TPWzPScoTdDGCfkL7jfquc8F0oM5aBc5MiSXJqY7IO fOgze+z39vYTRCp9hlq5bsY6X336djc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686240605; a=rsa-sha256; cv=none; b=Bw1amSRGByN8/5xvBaFe8Eu+H3YlCGVe1sB3VEFPCXhXlnGMHV0RspOAqQJefDlFXw5clc wCXXspu6q7RPO8P6AHUyWt2mJ9rJB7yDBKI5XI0YCVdpfDjloLXE94YiX/2QC4+Ps7cEjh neXeHOQFgMXVW+Ysc4UT1dHysmA3k7o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=aqqlosKf; spf=pass (imf13.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.182 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-75d46c7cd6cso61430085a.3 for ; Thu, 08 Jun 2023 09:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686240604; x=1688832604; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Loo5qde1he69f2u4i/ib9ZVM0psMD7Cg0M9AatqdFv0=; b=aqqlosKfbPjKw/3gdBd2lQ7muprhCLsHawg3f4IEwYAKT/Q/itA1SQba/NYMZGYD9R xByoMotkQ5YSr3smggHQRSUbmzsdMAbf02yCN/Mhm6mz8WQzdkQSQWhYdBByBGWDT2gQ J8MXMovb/38C4r1QveZxusv3xE43gRWXE/y/5w1tQFj5VWhmY91XBGwsWLxBqyX1VCqq 9cvUg7fSyMgxDp1kYNUxpwBPzjwODYSinR7UbCGP0ydkvL8SP9VD/npfh8ejuRmu2x/3 6+IybunedSIMYu5nrUJvl1WrNfQ7oq3wtakVljkD8f+KYETinQm55Gjjoj/aosJsFkO5 DLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686240604; x=1688832604; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Loo5qde1he69f2u4i/ib9ZVM0psMD7Cg0M9AatqdFv0=; b=LxCe0ahmSylyPPceOt764JOj3y9LJ/AN37dAs1AKs2B2SGp+C3axXC9Zude6A4cI1x hvfU3I1h6kn8ZAOJQ5AxjkRDhWN/6bwSJiWcLeArMHJRfEnxaD7cVKQwDkdCrGXqR0ZV Ir4DkaGmXcMU47YwCCJUwznN3CpsRZjiUL1VC+EBD2IvKtjVyeMNseJyc+uNT/gd+02z Zec8R2Ng4EWY9XmHQp7s/MuWNLnRpwxSrPsSthB+rTOe7VM0w5A+XmkPix3qmi0hLtCh RHAOntUAyzKEqCet/lkPOeLf3CqVqHPK/JWQZ2CkQvY/b3gtuvj7mboF7ZPW8MXgJ9aT BoGg== X-Gm-Message-State: AC+VfDyrLwf4iR7O2q9CJHQtrdWDTHyDgH6CbygHHaExFI8l6fP4lc+N ANPIckd/S1R5Dw/MzbP9vHgmeA== X-Google-Smtp-Source: ACHHUZ7mv0riOE/OFmjTpYzXkTHyDiyj3eH4VJr6BV5clO7YGWIkdpN3aq6+yAf4fKZ4SWED3zZGBg== X-Received: by 2002:a05:620a:8086:b0:75b:23a1:8345 with SMTP id ef6-20020a05620a808600b0075b23a18345mr7447418qkb.64.1686240604100; Thu, 08 Jun 2023 09:10:04 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id o12-20020a05620a15cc00b0075b17afcc1esm409106qkm.115.2023.06.08.09.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 09:10:03 -0700 (PDT) Date: Thu, 8 Jun 2023 12:10:03 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [RFC PATCH v2 5/7] mm: zswap: remove shrink from zpool interface Message-ID: <20230608161003.GE352940@cmpxchg.org> References: <20230606145611.704392-1-cerasuolodomenico@gmail.com> <20230606145611.704392-6-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606145611.704392-6-cerasuolodomenico@gmail.com> X-Rspamd-Queue-Id: 2FD9F20015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3y7d1muhpbwy6z1oxa37knf3jrrnc6xp X-HE-Tag: 1686240604-275437 X-HE-Meta: U2FsdGVkX18K19i0qJjuz1ZFgJThepD/HtTpxWPYS4xN/LDdJtCAcYPuUcTUl9rnp73JLnlbd7c48HN6YDgGeLxCfhxWcb+8Q9cFv/bNH5YNsnapoNa2aLnrBGpqOWZpR0990BeaA/kT5pI57wkYE3Q0gmGMD+6AhjxeNMupnybGGqZgjY8hK/UDpX9odh5oHHJTai4Fg2K/lIC3xugv46RxEAwW/8in8zCblE1cJnxReKG+48EUTjF5/2VKF124KVAXdha6Sc2VVNX2YShIdQ3hPawZ5u6b41/p/cDNUXTzr0A8khsMMfkCcHtJzxEvUCCyh3Ik+4WpmAwFOYwkz7D89yHYjsbcRcpb65OiOGTLOvHoXgxSNR65lVNBwUog05ZyhrgYPQLkE+maHh1aHKae18Ly1lAe8uSDZfktSur8eAQeAJlFqsFlbbWeagDzcRGM+l2UgtIdvmK0GSY2CZFA4b/prZ8bnqRqwSj5svBzVDRFwQRKq7ZzM2EXoLsD6KopXCtqdUIiDSKoaIX2/J7fcbmNaQyrsadFwDVQyXapzhk1eU6MtkhpU4A8X8v+gvC9UG/TT8TfaHLyNtP5c2S3o3L5PPG2UfXU8t4tT0sesb3E9MsQH6Z5pv8oRTh0PCGYZnWpPuE5jwBQbRafVY7kNeCISfMVz8vyWTVCWpcOcp23zk4ywfvaIIZk58DH1YVScfYzGYTIyXbOpqHsyYlmVwK62hBNc/HNwTJkOcwHpm2VqrAPgFladurh+fo67TgvFaOgk8w8DmllzWU5ZuLEXi25So+OjN31X7hwOp305TnSb3U4lJe903yG38AsRxdVQVdiM47QgH1es9qphcfI5u7XeXL9GJ7PpP9SeUE41xfaV66mwZ+ImdcR69XeeLHZC7YLb9l6NNBBzBNQOgj/NvMLT9BEw/mAWWpG+Ot3JLqwhK72Qtu7MkhcO+s5dR3pKK3Uxkmn0Vm87tx 8nEi12Ft 5bw32C7JUSFyHksrewp6cnSzCtuYsIiJEQfe4+tjwJ7a6jdtZ0hM+04xwD+Coa36KquzwrEJF2bDaZL2s0Q3VwBMsRIIOoZIaYJYmAKpVW3H5/NFqNDlGjXCwCu+4eGO4Vg2P+VoaykZapDtCgqfdCgzsGwtvo1ztp1txjFSw90ivi65iJqgQnwzp1B3E8n60UHpNfZ/Y4mTifDnFf55dU8n103FfIvplP1eW6A65asg//a11MPfsM8ps4qx4bs0xUU81TbZtwZTlT56fJzPoGBLMUwjsNKXCK+JJRdaBtMxdl8+451vuDMMz3AgWDQfvO7gE6IatL1Kxmjqo4Gnt7M0UCRpHH1G5mLfXOIttI0MO9PWJpCeMYDQ98P+qbuJoTWZg9bwsmfXkwXNXhQriE+LQ5FZHFk7llEvRtPE8uI5o56KfFLkAdyUj5MfVVHdDjKSirUmP7Zhz/rc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 06, 2023 at 04:56:09PM +0200, Domenico Cerasuolo wrote: > @@ -40,7 +36,7 @@ enum zpool_mapmode { > bool zpool_has_pool(char *type); > > struct zpool *zpool_create_pool(const char *type, const char *name, > - gfp_t gfp, const struct zpool_ops *ops); > + gfp_t gfp); This fits into a single line now. Otherwise, the patch looks great to me. Acked-by: Johannes Weiner