From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D948DC7EE37 for ; Thu, 8 Jun 2023 16:06:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 499836B0072; Thu, 8 Jun 2023 12:06:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 421BD6B0074; Thu, 8 Jun 2023 12:06:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C4048E0001; Thu, 8 Jun 2023 12:06:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1D3C06B0072 for ; Thu, 8 Jun 2023 12:06:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1EA5AE854 for ; Thu, 8 Jun 2023 16:06:32 +0000 (UTC) X-FDA: 80880058224.08.C2DE60A Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf10.hostedemail.com (Postfix) with ESMTP id A960BC0252 for ; Thu, 8 Jun 2023 16:05:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=zZTqje0A; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686240334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wlySnVLL7BDI4T2gMETXFiEvahuz34MfHsvLYgyHA4I=; b=LT7RpGpVoeBakafr/FUcT5dXzxyHtZu2lprAgpZ/TySKpOf4P7XPr6tEMoTpJeu/9mo1Rm ql8AVV2xBVXz0e0XYQl0bHiCP17Ix1pk8TR2oKsF2c63nEeN7Qqf/FTVAIKaxGEEJ/dukm JN1piPKM3EH+RVizcqKTwCVUmoVgUBs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686240334; a=rsa-sha256; cv=none; b=s/qlb8P764+5NKJ1pm28Xiop9bXfQYShog1mAniz//H1QN3X0j5P7n5WlW3W3qD1oRIGgX Z0BNydI1PW/rBo37UPGkVzt3QVBqJahGUpOqi56oEZk2+ZzvOI0qjtdzImpFmausJsqYUh ny+aQwJRrYA1dERopbczKesIsoYdX8Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=zZTqje0A; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-3f866383b25so6396051cf.2 for ; Thu, 08 Jun 2023 09:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686240332; x=1688832332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wlySnVLL7BDI4T2gMETXFiEvahuz34MfHsvLYgyHA4I=; b=zZTqje0AwcodgM6rBPvUVwnbvFvpBnQvSOHZVkLbseSSXxXubrgyxi6aYu216eBDyu 9Ggd+ual0/SSTfxGdIBW0vngHvrU9t/bOFYgqyeJh7LuaTcocA63yu/xWlI5cyiDQqvV OdmO65l4swhJrDxtgqDqu4LtQGg3ps5e1esSx29JTC2zw06rFNNGwFCtuDtgDUY9TYFV xuCLM/ypwFyecW9YYUHNu+NbIMIpMRfyapdG2tvKjtirZrXCos4ZwAxtxoyr8ezJDTIk q/L1TSmmsHlCuNl5avE11E1nxP1xE5LJjHT0VBjAw47p4u1faCWS7YYOFoqZvMgSOFPa GDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686240332; x=1688832332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wlySnVLL7BDI4T2gMETXFiEvahuz34MfHsvLYgyHA4I=; b=MVDPCn5LYaiv15j2pIpPiARhkaXa+86Qqvq0XBAeaUw9bG3+ngnXuS9V1wzKiD2kj6 IuhCyXZDyqlHi5DvcFJ/Fi3DW6WIA2OsHd1BQ4E5GhBDCJnIc6M8fU0TrOzHl6A0Jpd9 1z0gL8uCcswm1YAl/8KRZNOrEMbftTsi/M5f9r0vq0DLs0d2dykSHT+ToYV65zLrxbud XyMICvvfSZ3+aN7W88Mr4LYvD1SZG2+RoaxlixdCzX8klUcTITK3ld+RhzDJxyvtLkI8 b7OnZTehicX/bW3qHP/Z+l3RIaMAOfVAQKcUJT5CwUjZqxEsrXBY5JrLagf4sNtIGIkf keYQ== X-Gm-Message-State: AC+VfDyujy5wiz5UuAKMskYIFjiGVl7iYh8RwO0kUOEAUKNFZYRv698x 36Dr85p6xy2K1R4IpluSDYSjsw== X-Google-Smtp-Source: ACHHUZ6V3RQRuXW5vNZf519RXC0gMfAE6lZ6fBaGM6N7iR1eBarImWPM9JtIBghkR9z1IhZKJOES5g== X-Received: by 2002:a05:622a:490:b0:3f6:c1af:aa73 with SMTP id p16-20020a05622a049000b003f6c1afaa73mr8876318qtx.42.1686240332439; Thu, 08 Jun 2023 09:05:32 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id bw18-20020a05622a099200b003f9aecb599fsm451950qtb.35.2023.06.08.09.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 09:05:32 -0700 (PDT) Date: Thu, 8 Jun 2023 12:05:31 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [RFC PATCH v2 3/7] mm: zswap: remove page reclaim logic from z3fold Message-ID: <20230608160531.GC352940@cmpxchg.org> References: <20230606145611.704392-1-cerasuolodomenico@gmail.com> <20230606145611.704392-4-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606145611.704392-4-cerasuolodomenico@gmail.com> X-Rspamd-Queue-Id: A960BC0252 X-Rspam-User: X-Stat-Signature: efkjj8p84d69shuia9cf8j1h1wqu4cpk X-Rspamd-Server: rspam03 X-HE-Tag: 1686240333-524076 X-HE-Meta: U2FsdGVkX19M6NobUwRHnsI43YKe1OSmHcEll4Ok7newXYgsYME94vi/E5YdsiyWPdIwI7NFtsMzlpGRf4dxtc0P8HaIJmXmQRuNZKTD2wjqXMZOpGlT420RheNRkGE/9OM3NMfy9JellW1qk7uK0dTLnaQ8+ZKa35YlBwBxIb1NSKZhwJ3rGFem/fXMoelHCxOdkzC8BwLQuMpWv+LVYkE/mPMSin0TbmpNT2lw1Z93Kk7El8GKoQi84pHuTyUni/eWn+MzCcMGpIc4YTfb/HD10FA2EFdBJ4XyCMGL8xUElfNKPc/QdEEyjVWIzq11Qh/Zj/GNssvDU1I4G8SLMsu/K2KiIQ2oJGRY5uyLL4WaKZ4M/ZlVJheIJiybGXT8YSDSopFD6g43rne5ySMJVAn2lisp/ClzdQ9lRgmzQXgLcVwaCXgRcDgOfaDNsubBNctPQ6wwyesn3laoD5NOl6N0F4SmGndghUsv0hrBEZqano2T/K8GQ8wgIsABqsfgmuUVFKc/QOaKCv+6ImaEyAN2eEmZLubs3WhndYpbA/+3ma+7XxC+qxJBBMxZIzSNLhH2a/Pos8lW/fAcNFiCACVB8HHSisGjh5S3FEGBsTSlHTK8nrINaUY+D0du+9BJkQLTOwMj25UHDKQRGiij4xJsPg44fTtkOUAAdk7MszT+a+Q3YMYYXMmmqdS/E4qfBPvEkfAw0/mJ2+zW2Yt7of/LNnEWHQl/2GBswcbJij2P/l0vgSgJygI7yAB+vV7dNVGq/aMwQSE/VSdFB6BPC+0wFvwQiPJZ6INL/R29ftDlATifrDYJwDqiAW97iGOXpPqBAswh1Iqs99aEbuc/vmC1OTgSo14mCLkSw5TeEqW0DgvOtU2RBc9205ufJ28W+qnpIFv74J0Fi7wr6umqSko5BAnD8jx8KemNWco5dERmg+Ex8OHT8PzN2+isXTLk0uCyvOFxt/JshvP0qeE qiDnypRU 7Jto/GehhlrACr26fz2DWdQTVLSKaW59RhAwrImwFT+KL2CU4tkoHXotJRco1Ohm7tTse1iB7Lxh4dYkOu0pM8LnjgTJ1Ur5W/uikMvJmJ8uNcDa8QeKeSbGAaBifMckDHrUO7nlU1cT/wg6HorFWlOi4M8w9p0xcFxz/yHq+j6WHtGt6eFt26t4seox4k4hVqqG0HxNXc9bLViDls+Dx1KFfLifoBkQp4diPlRyK+f1LfdncoXp7FRK/ruwgncN465btxXWmi1Bgo8ifcOsKtXGiWKQomJL/Loce6GUd/NwBdsLpuX+iZc7ggMEZVlPzkwegYFzskvALP3VzBAvGp3Voc39udc24nv14PFN98vJxbE1w8IIzOpavok4/GVQibzDXcaTrgEXyjm5V/O3J9KGlXzsuti5oPYe/hiBUtQSen8jOXS2Cx8BLcesvRvfYscn7qjZ/2hcshtU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 06, 2023 at 04:56:07PM +0200, Domenico Cerasuolo wrote: > With the recent enhancement to zswap enabling direct page writeback, the > need for the shrink code in z3fold has become obsolete. As a result, > this commit removes the page reclaim logic from z3fold entirely. > @@ -1649,7 +1409,7 @@ static struct zpool_driver z3fold_zpool_driver = { > .destroy = z3fold_zpool_destroy, > .malloc = z3fold_zpool_malloc, > .free = z3fold_zpool_free, > - .shrink = z3fold_zpool_shrink, > + .shrink = NULL, > .map = z3fold_zpool_map, > .unmap = z3fold_zpool_unmap, > .total_size = z3fold_zpool_total_size, Same two points of feedback on the changelog and the NULL as for zbud. Otherwise, Acked-by: Johannes Weiner