From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2576DC7EE25 for ; Thu, 8 Jun 2023 16:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3F218E0001; Thu, 8 Jun 2023 12:03:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF4D6B0074; Thu, 8 Jun 2023 12:03:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B6908E0001; Thu, 8 Jun 2023 12:03:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7CDB76B0072 for ; Thu, 8 Jun 2023 12:03:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E336AEF8B for ; Thu, 8 Jun 2023 16:03:51 +0000 (UTC) X-FDA: 80880051462.11.DA7921B Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 44B351600F8 for ; Thu, 8 Jun 2023 16:02:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=4Err329a; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686240152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XmeNd28q5yHmtNMDWyiOtbfHgBbeEmEURGIKSmo3fao=; b=WUW6zzbUFYVsREChcZJsrYs0O1CAiszIQltxfymBdoJrcw0XzvpbX2VOteLpzQ1qhBOmr/ u4N0MIACx5yoG3jIy6Ek1wOr96AJZOK4EYcvi584n+AHSL/q3wTOUcztgrM4yop2IjeIQz LvfEuExiplvjFkKAiaRyIGWCVoyxJOM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686240152; a=rsa-sha256; cv=none; b=n3CmVNILFE6WkpELVSs+RWVpzXCJnMHS5id77/QtBXRenRe00N8JUGcFLTwW6DMVcE/Uzq 6dDUUuzqmDMXvc71v8YBECujtAQdcZhClhkF0G5Vom7met8CsxDKq35082w6m+1Z9Jnx2I hwO9gXiMR9Ms+cHfgXrEdAhSv2F+twQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=4Err329a; spf=pass (imf08.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-75d5051fad3so68659185a.3 for ; Thu, 08 Jun 2023 09:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686240151; x=1688832151; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XmeNd28q5yHmtNMDWyiOtbfHgBbeEmEURGIKSmo3fao=; b=4Err329amGe3/r1KRfph3RhHvzoY0MnuVR+qgGwAsXSKTNif3JYbQZ+WUSP0rk9ZFJ RsmfOKm3LfNWGSxgYyKZPcg4Brx0rkywvP49hGy+8YOJfED/l3/DBAW91mrnCdRA6ARO zw7/xN87kMHBfs7OutjXEEtFfMaFPiJ7aaPlMvs9OdtD1Irf3W1jwY6L/81/kR345lY2 XSS+lA/VBovFuT09Z8S/wsstexqc6b4WMIUeUAOs1UXW6EX5z5Lzy6DtvIQRIMHpm/3u IbZW75l2Ah74BlfGxekqRydAowHLXzVCsNOUQojBqzFMtGrxVEz+1AR2+IUburOJCk1a kifQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686240151; x=1688832151; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XmeNd28q5yHmtNMDWyiOtbfHgBbeEmEURGIKSmo3fao=; b=XJMF/rZCeovzY0opCGvTT+P6PvA7YtYq3VzNwUrrZhm4jGHe4pRWUD3D/6xRRiQIZ8 vMw+grj9s5wDm+IfEBQ6hxMFGbP6yStaFLaO3DNO+sB9cTUWFXM3KFxZ7RoaRNrMfoNF jpahaWoc3rA+HhwRk6cJSeHCs2LC2WpCiMm1dNwnUBfzPVNaRpBVtMzhCHxV8phZVsFQ eyvTUfUyzXiF1qpsYltAWMebNIj0j+leYuM2BJ3bvUNuRR5a66HrDU/uQLYktt+QULbK DrO4ztR9x6Iw7gDC0gfA3s6zC6Lewjxb5Fdj7j2py0D+hpJo7nLDIPQYpMBEwe20HhVM YE9A== X-Gm-Message-State: AC+VfDzRLMFksTQvcWgLKJyoq3NCqPsH/gGKjRsh1RItDyxb+aala4bL y7myzMjnfmprt0r6soBpR4UcIw== X-Google-Smtp-Source: ACHHUZ7XJNSgG1NVbM+XaXN7XC+P/oWfSYzdsJY/RsrgzEsNlY7Czuf4ys9lExvWsCi7Rkcuw/DIxw== X-Received: by 2002:a05:620a:601c:b0:75b:23a0:debd with SMTP id dw28-20020a05620a601c00b0075b23a0debdmr6445125qkb.59.1686240151229; Thu, 08 Jun 2023 09:02:31 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id j26-20020a05620a001a00b007592af6fce6sm417471qki.43.2023.06.08.09.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 09:02:30 -0700 (PDT) Date: Thu, 8 Jun 2023 12:02:30 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [RFC PATCH v2 2/7] mm: zswap: remove page reclaim logic from zbud Message-ID: <20230608160230.GB352940@cmpxchg.org> References: <20230606145611.704392-1-cerasuolodomenico@gmail.com> <20230606145611.704392-3-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606145611.704392-3-cerasuolodomenico@gmail.com> X-Rspamd-Queue-Id: 44B351600F8 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: f9185eepwrf8yy395m8wjyox4xqb4mdh X-HE-Tag: 1686240151-285032 X-HE-Meta: U2FsdGVkX1/mFkV/3GQbPTjOvbccCOJl+Fq3WRqkV2cYhkCoVjhZHj3rNIDdWRA3/jyjZ2tr8KxKQROewiJF+Ur+ivWMNVoA2ZyERIcX+YSV176oVBRny8r35YDvkeEXBi/8+ag6ZcU95vCZzWOMV+E0IA0GbWHIo/dNycbaCASpkFqE+LQ155oSlUmChk7aDEln8J8u3xep7j+yuy1KHaVOotd8AMr7h3RDqmrfRygtiHW6FPRMwhfjZmMOrv/RL57ErfUMX9XSkCRJtVB5Hjlyd97C3E70qz4hzscGcm+sPnpAbVOgJwx/jq7QJryHXTH+rXPiSKK/xmexCZdLAnPdP/76RVQBcPTutqsxSNkFKkgTNx43PagQxM8B6GY5bNx/6UX7LpIznNTLSxhyy9qMSed6uQsQDmOxaFyznJBvcCpofj76DP2aMFTJM/E5yZxdtRf4EKp1NzFFTLj+TMCsUOn6XG9DqEraD/DBcCBOyomqLLIMssfxKufryMFA6qnPBl39GYuB3YBwVkYJsYOWHcixdPOsuRbKFOkVY1cTYh0BQba8pcpGsmWYCNTVTbPFtQ3cqk+Hf3wp5qhEyI7i3Rar1UHp4Jt/CVFgrwFjVGnBB2pxRLFYDGSFQIl+skRKP3/1MMSf68kArdsJdgMuLwEbNBRbBhaoEk8uXR09I4NPo9aPygGZ5HQIYdwwKt5Rxnrs+ofvmmD3sESyBm37jklVY98a53lzrLvqbv+IQdVZInQWJN1/Fc2rWWUAzqEzELZnzd/SPm2qM9x7kdTnWRW9fgwxHa8pWM/COiuTGDZ6qgSnUDkp6UAQ5i/7EhX480JWiPe+kp8LJ/MtwBtQaDHo4OGBHJcQ69viPlWXxrYy5RKwjY75bfcun12h45sDxZf7sFGPo6rPFlbElAE18LkQPMN/kByRw8HBXuqORQzETbzPai86VSnLfL4iIRkG8HaGFJGHXR1Fc8j PESqtPak kM9v/4Dat0M3PfixawnlEd7/eW3+YsvCT8wzgfJRKZibCsmlUxzLbRxk9rTNNrcjV077tMUUwfEER/3zSqZ1ublO97i5drEHb+RMiA01N+kvo+sugEVY9yXQrQqJGf9ChS9P3RZt5xrppUO7gVsDHT66skSVnunxsD+PwzczWCKKyj4H/EBPknjCH4PizwmVX1ZDZmY/U+ytUXlWo5G/emyWey6kU3Io28BPMTFOl61QHtIJ7W5AjpErUUnWulPdbJwkEdCaMF6Ts3vSihiIf/N3meAfIX6hv7p+VoXMyJau5gF/KOeueUVk+aLr7rEPM5I/kujIFMtMdJRdIaq6yEcfQVq51S1B976IjU6CMTGfzexL6BeSi6yduerm69LhRQopP1ZMgmSo0XkjTx7/x5kBJ+44e4M30yUYIhthvq1SUvb7AWlLA4L3qmTfqgk/5KwwRdLMryC+0Y7DLQztKcRgzuCLYIYooWKkq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Domenico, On Tue, Jun 06, 2023 at 04:56:06PM +0200, Domenico Cerasuolo wrote: > With the recent enhancement to zswap enabling direct page writeback, the > need for the shrink code in zbud has become obsolete. As a result, this > commit removes the page reclaim logic from zbud entirely. > > Signed-off-by: Domenico Cerasuolo I find the changelog a bit difficult to understand. How about: Switch zbud to the new generic zswap LRU and remove its custom implementation. > @@ -585,7 +425,7 @@ static struct zpool_driver zbud_zpool_driver = { > .destroy = zbud_zpool_destroy, > .malloc = zbud_zpool_malloc, > .free = zbud_zpool_free, > - .shrink = zbud_zpool_shrink, > + .shrink = NULL, > .map = zbud_zpool_map, > .unmap = zbud_zpool_unmap, > .total_size = zbud_zpool_total_size, Like Minchan pointed out in the zsmalloc patch, you can just remove the line as the member is NULL by default. With that, please add: Acked-by: Johannes Weiner