From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 536AAC7EE23 for ; Thu, 8 Jun 2023 15:58:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B52AA6B0072; Thu, 8 Jun 2023 11:58:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B02BA6B0074; Thu, 8 Jun 2023 11:58:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F14B8E0001; Thu, 8 Jun 2023 11:58:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8BB516B0072 for ; Thu, 8 Jun 2023 11:58:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6171A140312 for ; Thu, 8 Jun 2023 15:58:52 +0000 (UTC) X-FDA: 80880038904.22.EC2C184 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 54D99A001A for ; Thu, 8 Jun 2023 15:58:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=rFlDtp6C; spf=pass (imf15.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686239930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oE0L6uhiLhYAQ30whkI5Wz9EZKNxwSeFyqmqYPKICPs=; b=U29/ddVLLStCWXI0uJ3z7Kngslnt7kAfDa9Xi5MZMm4SChSFkqa4he2iCXjDvh7FqBRBwX l658EZu656Jmy2U9ea1Y53vjCIxNUI5JEkx6dfRh1Gtjwzr2cmKQz0euJy/Dhx8fxuB4y6 eLeuw0mZlC2JTHP98QfSx4+RXk2I0tk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686239930; a=rsa-sha256; cv=none; b=0EMrPnOjEI1Fmey+5Kckw5bRJf5vEqRgS7sKsamAcZwmxN7gRcEkWddVMcV7q8NV4FBkEh T+ah7rB9jaZSFpzMQH4SzziBcknXDpvILLNggfbJj7VMCdTrl/MJgawz4ZLnuUp+4l3xVp j57+ct8pxPV7LJV4UdmIxuOrTWMZGOM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=rFlDtp6C; spf=pass (imf15.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-3f9a6c18e45so5636171cf.3 for ; Thu, 08 Jun 2023 08:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686239929; x=1688831929; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oE0L6uhiLhYAQ30whkI5Wz9EZKNxwSeFyqmqYPKICPs=; b=rFlDtp6CimDUBwq8WNXMrwm+2f1NefnYPrJxslday08prNuXa4pgiuEVkSApNioiDQ EleXqAxvRhFc0GBTfFA4nunO8LLFigNx4vyrGrksoKktru3VQATXF3r47kGAArZZf0fC UvuZOugrOmBSZMZCV/OkZtoQat/g97LmOl3qh+KhP8oSniL1tSCMIbzISnleZgAQlV3p b8Gx4W4h+eW0dX+M0gG9EpnheLely9k2MiYHgVLGGRsoT1uhTtgJRnRGSqjAoRXGG0CA vPGOcImBXFlDWxinJ6j0rmX2RFW4zbVnYpTgVZ+I612ZIfBhmwGmjiPkhULqUM0oaClL TSJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686239929; x=1688831929; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oE0L6uhiLhYAQ30whkI5Wz9EZKNxwSeFyqmqYPKICPs=; b=mGAitNa2UWJYFQequXLOLzcEogRGOBNRj5nEmAA+4C0z/KbD6AecTsAnMGvkOHA1Kx A5pkkbtsCZNk2XFB69SNKsMFqtzKrYa2bI3BTpMDpzcfyoXPaTz2KmIrrQ08FcfjLso/ 3qaGCrLB+9yF66+hOWLoYMoJF399OFThw7dDw4Zj0OOzmagpnBx9yVtZ7fLb9UVCJCsw d4Xx0CYOT+A4RlzcozFtDK87uiFhmRPnWMdNV9+4iC1VSmYhUiVFhZwdy/Elxohd59h2 rtHNINGACLn3vQccbcbHnbub6UtGNUdSnOvCcOm1usba22tTLbu6HejcGotJhaJtR5Sy HC/w== X-Gm-Message-State: AC+VfDzlO2us96Gbn7rGABC6VoNpyWeephpXzECbKxh0OV25eoWtUL/u M+J8ROLORUzxSyIDZ0dc7xWjpQ== X-Google-Smtp-Source: ACHHUZ5N6QaV3GnMPx+oJ398Kgsw/r8y4wVZ0ah8baiJMoQer2Hnp70AlbnjsxAw52Ayg3CxBRnd5w== X-Received: by 2002:a05:622a:178e:b0:3f5:d890:8aa6 with SMTP id s14-20020a05622a178e00b003f5d8908aa6mr7932963qtk.60.1686239929322; Thu, 08 Jun 2023 08:58:49 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id h25-20020ac87459000000b003f6a0fa022bsm442216qtr.51.2023.06.08.08.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 08:58:48 -0700 (PDT) Date: Thu, 8 Jun 2023 11:58:47 -0400 From: Johannes Weiner To: Domenico Cerasuolo Cc: vitaly.wool@konsulko.com, minchan@kernel.org, senozhatsky@chromium.org, yosryahmed@google.com, linux-mm@kvack.org, ddstreet@ieee.org, sjenning@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [RFC PATCH v2 1/7] mm: zswap: add pool shrinking mechanism Message-ID: <20230608155847.GA352940@cmpxchg.org> References: <20230606145611.704392-1-cerasuolodomenico@gmail.com> <20230606145611.704392-2-cerasuolodomenico@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606145611.704392-2-cerasuolodomenico@gmail.com> X-Stat-Signature: jodttf4pqbi7hm5f6qgq8ptwrgtuafxa X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 54D99A001A X-Rspam-User: X-HE-Tag: 1686239930-183112 X-HE-Meta: U2FsdGVkX18cf9c9KPtWcUcyMhE3v5yKm53rLSwuReQb9TmC07whJw1FbOxCY4InOOHw83CzX2rt0O33QnY3/Xu3Gwe1HqSbSVp/v20qHckLp2WzHGJ6NOones07W0Y4XVu2NyeoHriEioAYwfd4zK1TVX3iH6OYpRc2YavNLMeBFdz83SNQ9hGrhjl+e0WFDR5BFG95v64WmsOnjw/XqGldOuvVfyGgRbgMcz5HESUA1SjZfKylswJK9aHCkJMnXW7Hrxuv/qOlwDvouACx9dVZntKzE11Lby89Iz9f7DNWzOnuiB6L6ShLKZ6+n+PdItVni250V2Sb3MfMkPjTqtMX+2AgPRLke48KZu0wCwCuzIzDHVrIHRNdPskhtbCymFukR/2uKvm96NIWJB7nXvqW3kjXcnmmPJJfNqBawatMCSk7QVO4QxnWAT715uZJ8DycAJGPgTP/46JGbSZ2cO+HI1rSQGcCrB6Y6UoVTvBl9VEnf161c1p3Oj4y3gm7gsElarOHYrUkvcvLPB3++VDslr2qU4hG9dHZRt3EOt5GD0GCEB9jHZ6jCYATFJ+EaGFnfjWwYHtV+mxTWjhoJ8sIJ6/4v0I15xNBPBYvYU+z0kq6IUUibfd+o7E8mKMj/T4YXLv2Tmn9hqT0znygS6VS6emHV7qXnfDYg9AYFClKpeyaSCY7VLOx7WEyVqIk9DkPlb7VO4G3iHDef6nODk+5xhHEVugFpZrOEU6QwU5MbTF5oX6r9hlRMMg8O/ERH0C3x5f1vXwp0K+8hKTHkzR3U6XLhhtJk/CQOMfQ9+oaGupd/B7Y2M90SXZNINJo+ES2Dsf5s+cjGj2x0DMTgDAlA+GkHusVg2bJFy3MxLKWan9P6oFHUqwl+Q9bH3H60vthRmxTfLRhLPQe88+2BtrZ/D7hnV9UoeXX3TDc89eMvPu4PI8BgvuxLQbjySKqgf5BnUPXVV4qQ0IFUyY Chao2VEo 8JWDKcChRuFyQk8I9d5aaWWv1F6esivpNIFKPrfxZkQO1Ig4EyHjSPCt8sbLjrJqA5qv0CkAm2L6N3/KZijbfhpF+N3/f39lrej/TaHRftk1R/Iq3KPamKQsa+698VwL8py/4LOwq7jKcAV0ECY4JCAooYp4Sr3tkWSm6njKKD78PZf9soKmeBCyE1H0qX0BNDmOddWV7VUFk23gfwsF3wRYE8qqFzBICkgTEckkrfF+4LlMWUEylYb8xWZxc4140ttVzHCEZaTm9x0kcY6o795VxC1AiCbIwxpHCy4zi8GHCTUW2m45VwB4G1NdEpqMlOWRif7qnLCbtWAnxWHkeoCy1DTr3PfrgOke4LS2YM8rKs7aur7KgEvk4ziqkmiZB1J2hJ217cOztno4anF9I6+wfFYqkiqMmXuHaBhhxyTS3dvuucYlTvkr5jwFysNDCx1gIT/2B9iaAk0HCwdLq92byL7+pnd9Wk6FS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Domenico, Thanks for incorporating the feedback. Just two more nits: On Tue, Jun 06, 2023 at 04:56:05PM +0200, Domenico Cerasuolo wrote: > Each zpool driver (zbud, z3fold and zsmalloc) implements its own shrink > function, which is called from zpool_shrink. However, with this commit, > a unified shrink function is added to zswap. The ultimate goal is to > eliminate the need for zpool_shrink once all zpool implementations have > dropped their shrink code. > > To ensure the functionality of each commit, this change focuses solely > on adding the mechanism itself. No modifications are made to > the backends, meaning that functionally, there are no immediate changes. > The zswap mechanism will only come into effect once the backends have > removed their shrink code. The subsequent commits will address the > modifications needed in the backends. > > Signed-off-by: Domenico Cerasuolo > @@ -364,6 +375,12 @@ static void zswap_free_entry(struct zswap_entry *entry) > if (!entry->length) > atomic_dec(&zswap_same_filled_pages); > else { > + /* zpool_evictable will be removed once all 3 backends have migrated */ > + if (!zpool_evictable(entry->pool->zpool)) { Comment indentation is off. > + spin_lock(&entry->pool->lru_lock); > + list_del(&entry->lru); > + spin_unlock(&entry->pool->lru_lock); > + } > zpool_free(entry->pool->zpool, entry->handle); > zswap_pool_put(entry->pool); > } > @@ -584,14 +601,70 @@ static struct zswap_pool *zswap_pool_find_get(char *type, char *compressor) > return NULL; > } > > +static int zswap_shrink(struct zswap_pool *pool) > +{ > + struct zswap_entry *lru_entry, *tree_entry = NULL; > + struct zswap_header *zhdr; > + struct zswap_tree *tree; > + int swpoffset; pgoff_t With that and what Yosry pointed out fixed, please feel free to add Acked-by: Johannes Weiner to the next version.