From: Mike Rapoport <rppt@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-mm@kvack.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation/mm: Initial page table documentation
Date: Thu, 8 Jun 2023 12:00:56 +0300 [thread overview]
Message-ID: <20230608090056.GH52412@kernel.org> (raw)
In-Reply-To: <CACRpkdYPPLWW6P5wwEuXjM6ZL6k6fpq_G7my6jBRhz76426bcA@mail.gmail.com>
On Thu, Jun 08, 2023 at 10:13:49AM +0200, Linus Walleij wrote:
> Hi Matthew,
>
> I fixes up most of the comments.
>
> On Tue, Jun 6, 2023 at 5:57 AM Matthew Wilcox <willy@infradead.org> wrote:
> > On Tue, Jun 06, 2023 at 12:10:35AM +0200, Linus Walleij wrote:
>
> > > +- **pte**, `pte_t`, `pteval_t` = **Page Table Entry** - mentioned earlier.
> > > + The name is a bit confusing because while in Linux 1.0 this did refer to a
> > > + single page table entry in the top level page table, it was retrofitted
> > > + to be "what the level above points to". So when two-level page tables were
> > > + introduced, the *pte* became a list of pointers, which is why
> > > + `PTRS_PER_PTE` exists. This oxymoronic term can be mildly confusing.
> >
> > I don't think this is right. PTRS_PER_PTE is how many pointers are in
> > the PMD page table,
>
> I don't get this. What does PTRS_PER_PMD mean then (and
> then all the way up to PTRS_PER_PGD...)
PTRS_PER_PTE is how many pointers in the lowest level (pte) page table and
pte_t is a "pointer" to an actual physical page mapped by the page tables.
> Yours,
> Linus Walleij
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-06-08 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230605221035.3681812-1-linus.walleij@linaro.org>
[not found] ` <ZH6uolQWeyX9kb+j@casper.infradead.org>
2023-06-08 8:13 ` Linus Walleij
2023-06-08 9:00 ` Mike Rapoport [this message]
2023-06-08 9:31 ` Kuan-Ying Lee (李冠穎)
2023-06-08 11:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608090056.GH52412@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox