From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FAFC7EE29 for ; Thu, 8 Jun 2023 00:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77EAD8E0001; Wed, 7 Jun 2023 20:27:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72EBD6B0078; Wed, 7 Jun 2023 20:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F5E58E0001; Wed, 7 Jun 2023 20:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F7BB6B0075 for ; Wed, 7 Jun 2023 20:27:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2546B4017C for ; Thu, 8 Jun 2023 00:27:37 +0000 (UTC) X-FDA: 80877692154.06.C02320E Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf27.hostedemail.com (Postfix) with ESMTP id BB0F940004 for ; Thu, 8 Jun 2023 00:27:34 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HIfqQHgE; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686184055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xbdx4xyOW7tIGIIzXTzdSpqOcheZeZb/oA5ir9mW2no=; b=qbodwk7amhAAUISWhNExvYu1wMu7n4Iy5MkgBRXiBccu5io5rj4tTZDy4q9UPG/BIQ1gXr FlMN+FLflYh2XNBeS68QsppZxziIerV1C/tGqwUKFqU99vX1JCPT9NXSb4WqQ97jGjDZOi mVHSwZbwPmehd/uq1WNsEw5qldaGC5U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HIfqQHgE; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686184055; a=rsa-sha256; cv=none; b=Nrzei78K+aOasDT5hBU0B20M+eWkZSH3H905ViTHeik/HCqET13uQy0Z2yXZsFJPGgFjFh Q9yO2M6Yco7aHvJEs7EOuAKZhiHOh0K0p39hJ1IwhTWXKSsRo4hXpyOf108PIdA2A9xVjz V/DXqAR0hTyNQnbiUl6PIis01riUHKc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686184054; x=1717720054; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jQzX338FXtlNwG/9LxBQzpwhJC6fI/w9zX8t/rNwMFg=; b=HIfqQHgENjbsCzS2DT67AIQ5W2S3X1bBVSFpPD8CuK5vRrxDxK2U2M6o bQXYRC+2KLKRttcbeJRl+403AS5FrTl647G4VbTdZpvU2+leFo6ydRzky Z/fzm6RqYYwAQS6A1sdLr8bzgfT1icyuPq030ToOKQT3FgYDWzQ86EIqw tXsBFhij4PFUfBCNVhFaIXgZJkw75e3hWHcyvByMBaoX379XoPZYhvpcc cvErLz3I0xqxYgckaOF4pEHOwwUEqrY1DLvWaYppe8UDw8MDZJBc0Kz1u 4P5hYsv+6Ua2B+SC25livPbm+sjC2tWYY3vOyZQ1IjakzmbEhrvmQ0+Gc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="341806280" X-IronPort-AV: E=Sophos;i="6.00,225,1681196400"; d="scan'208";a="341806280" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 17:27:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="956493261" X-IronPort-AV: E=Sophos;i="6.00,225,1681196400"; d="scan'208";a="956493261" Received: from zhanzhiw-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.42.209]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 17:27:27 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 3054610F0E0; Thu, 8 Jun 2023 03:27:25 +0300 (+03) Date: Thu, 8 Jun 2023 03:27:25 +0300 From: kirill.shutemov@linux.intel.com To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com Subject: Re: [PATCH v11 08/20] x86/virt/tdx: Get information about TDX module and TDX-capable memory Message-ID: <20230608002725.xc25dantcwdxsuil@box.shutemov.name> References: <50386eddbb8046b0b222d385e56e8115ed566526.1685887183.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50386eddbb8046b0b222d385e56e8115ed566526.1685887183.git.kai.huang@intel.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BB0F940004 X-Stat-Signature: yaerzd8b7hch5uhj68upfpm6kj4binre X-Rspam-User: X-HE-Tag: 1686184054-879624 X-HE-Meta: U2FsdGVkX1/1B7FWv1B03Z+Etx6n1zGeEMmhs6w+GuiYII06rxDM9abtu8AFvHlTi6wP54JLhvgU2uG5c35Zzwf2yMxxkPAkSEJrReCfKld8xMFOfOhQzl7pTaFyRmztM5P8Aujdjz9F+r6PlUsCV1M8WMIYxKWNwUyX4tV6sMy9Plu6yvblcxwze/+VTOnXt3l8t/vETt9CgLc5Fv18fDyxs4s8CYrAtmd1hRnFFH7REOdr0HNQPyyjnaEyQmcRoQ1s8m+gB/jm8xbygh33cMhMmOvD58GttIVNoouGG5atIa56cyi0C+UdffF0PuLFdkarkweDXM5EalNinf/4DFXs8OAwpnwv5bLu1iJjjrikkpapfUyO07cvxTON/SD5mdEXqwl7d1keW+lVEZgGtbwds1LGg89FnhkoJfFJqJHoZ9SJwDN7cr7OJx/sRmiUWYGRT+zWHd6ztuvtlUo0uyU10HU/lxbZu0n6kPs2A8CpAXUFsgp8rs8x22RYf99IoGjYFIFHnAGpdNvHTMDpUhODxBnXuM/OKrzy2Jv+MP1C16Y10/858pISfM3Q8VFk35h7caylXmqCwx1qG3wA0U+zlDzJTPsDpxT2yhLc9mh+avplbVa+r5lZ8KAji2gp8nDdulkTHOOpw45Id5wo4AHog4wxpN//qYa0r24XenRy5kGg7XCT5RW6DW039dGcG74Oi9ia0pN8/ooAlOrEANy2UvraIF1EwA1nDsAmcvD7OtC7rOzz301Gyi23HQelFROL/ib9SFAwRZUYMRQLwdmwA8YjIW9zCH2AlKSJT4n5tovW+0PB1m4sNKZvl1cEd+OuinhF3hXZqalnr2j/e2F7CATRLHPZJFudiDKv8X3NENEBu6rjCzQMDTVpqYfut7kwVpBxWw/3oEsO95KtFFXvkFufC7PZoKPCcc8umI9w6BnL0eZzQZRaq4w3Dk2v2L7Max50H6HOQq43edx dmfBUb8T zLTr8HxjikGPMNFLFmNTEV7KMroDl/9IFpNkr4UNJ5Z+WOfSFMGBzsV07NSy0064U9sT7MSaxJo22Jt/1iiwsqZCf48cEKF1Kqjd3rQthbsmwfVI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 05, 2023 at 02:27:21AM +1200, Kai Huang wrote: > For now both 'tdsysinfo_struct' and CMRs are only used during the module > initialization. But because they are both relatively big, declare them > inside the module initialization function but as static variables. This justification does not make sense to me. static variables will not be freed after function returned. They will still consume memory. I think you need to allocate/free memory dynamically, if they are too big for stack. ... > static int init_tdx_module(void) > { > + static DECLARE_PADDED_STRUCT(tdsysinfo_struct, tdsysinfo, > + TDSYSINFO_STRUCT_SIZE, TDSYSINFO_STRUCT_ALIGNMENT); > + static struct cmr_info cmr_array[MAX_CMRS] > + __aligned(CMR_INFO_ARRAY_ALIGNMENT); -- Kiryl Shutsemau / Kirill A. Shutemov