From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99824C77B7A for ; Wed, 7 Jun 2023 20:44:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 058666B0072; Wed, 7 Jun 2023 16:44:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F23736B0074; Wed, 7 Jun 2023 16:44:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC4C38E0001; Wed, 7 Jun 2023 16:44:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C5A8B6B0072 for ; Wed, 7 Jun 2023 16:44:12 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9AE4A1C7A5A for ; Wed, 7 Jun 2023 20:44:12 +0000 (UTC) X-FDA: 80877129144.28.9B3E753 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf12.hostedemail.com (Postfix) with ESMTP id BA6D14000F for ; Wed, 7 Jun 2023 20:44:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=OxZBBCYE; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686170650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uBtObePEJMpXLUdvR0d7lMNYDfd/1CWLLE/+yHsMKo=; b=PfT6bvhYt/Dc/yJGESEoXqkGhZWTQHtxW1rCv4UCBWhaZQo6bABqluxyMKU8iTRDouFXDz 1tFwITehW3RO+SH4OfW6NpUtmF1yOa6OXlPqwPnXLdrRBRJU8TaEb6YrbuNLcBrc8KiIrD esQQ2fzFk1CrFiD9X+b/GPDrvL3G4HY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=OxZBBCYE; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf12.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686170650; a=rsa-sha256; cv=none; b=C4tfLAic/MHekJDJTa4P3il3IQ90KT8xZ3htRx0MYjffR5NniivJ8crCpGbZpGuHuazTYI VyOQvLLVkE3gLmA+zwhFBQRarD963xgFCaOPjw7fYLXnlMaelr+NiVz8Pd4h1NW0eVc7sj lDkxveGDpofyAKJtCe3EWrg0rtbgfW8= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f80cd74c63so86530091cf.3 for ; Wed, 07 Jun 2023 13:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1686170650; x=1688762650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8uBtObePEJMpXLUdvR0d7lMNYDfd/1CWLLE/+yHsMKo=; b=OxZBBCYEhIrvwilPeyYAZFxKMThGWPKFtvT8oMlyBxMhifnnpwTGJA3Bw/eJIxgy1H iTYPYBylFsDtuhH207pppa3AwkSdc3r92VwecbqE3bP+g3liBFKIbd/NbNpf4enILb8H pUZJDS11SVTHkROPU7jL9Zb9HTKRSWftA7uacAmuWtb8eNcIV0arySXPDwZZBYelCtKw 4j1XztZcYuVoExn1ZacU6MUE/9h6+U5nHGy1Bnq1+JcHgpKxgQ9HSNKazdiIPrGAOZp8 +FG9EbUQmVjC4LDUIloOrRsGw3Wey4tyLiC4qdjaQGo2SKZJ/J+HRF5QzvKEfFpvrRMK XQ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686170650; x=1688762650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8uBtObePEJMpXLUdvR0d7lMNYDfd/1CWLLE/+yHsMKo=; b=kpC0teP2qrcx1REY119ZA7khzT6b2Y4h3xfGbIipAfpuCKh+p87AsCH7+/iVJvTdcL gIRyMpm5ObIpuvUnECU5SGdj1ZTA3jrJ1VgsZognih4HeQhtKZLd3gjk/Yp/q302Ud8T ISxBLWI4a+HDduWX42EA+IH4XMh5SHOeY3a+dMU8UZskAOnfLacPsluP0rpqDMF58Mb7 zvg7z1lQBERg26tdquFeZUz45U+jodctxAx2n1BsE8XWEnREcp/Nyacp4rIfHS1KNrKA u4uhQZ9Ewt104teQelquB5b+H8+ZrlLfs2WUE50swRCZ6Of1rRLT+CpUium71fS4O9EX KW+w== X-Gm-Message-State: AC+VfDx42FXC0UekMKc58GK0+54O341+LR1GOPF7108XLWjTMzxWfZ9z OemwDE5m898Ej3qGJFZM5E1WFw== X-Google-Smtp-Source: ACHHUZ4N4t6tphKjaDaXXafqoNfYjiMYvpmcCkdxaqEcbN27M95rCwdK1/mGDtr3FMQ4HlUihB5P6A== X-Received: by 2002:ac8:7dd0:0:b0:3f7:a54c:c106 with SMTP id c16-20020ac87dd0000000b003f7a54cc106mr5072909qte.56.1686170649788; Wed, 07 Jun 2023 13:44:09 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-8f57-5681-ccd3-4a2e.res6.spectrum.com. [2603:7000:c01:2716:8f57:5681:ccd3:4a2e]) by smtp.gmail.com with ESMTPSA id fy5-20020a05622a5a0500b003f9adf7c9fbsm174163qtb.71.2023.06.07.13.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 13:44:09 -0700 (PDT) Date: Wed, 7 Jun 2023 16:44:08 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Konrad Rzeszutek Wilk , Seth Jennings , Dan Streetman , Vitaly Wool , Nhat Pham , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: zswap: support exclusive loads Message-ID: <20230607204408.GB340728@cmpxchg.org> References: <20230607195143.1473802-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607195143.1473802-1-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BA6D14000F X-Stat-Signature: heqhaxyumagk618r1en9zu8ag7cd8ytx X-HE-Tag: 1686170650-168007 X-HE-Meta: U2FsdGVkX1/ux/xqIQi2uYJJeUJAnj6YPtQOU4rMajkEXCSh4tdlJQcBWZWsql7rIWuXK/BUbwU9Uz8si9wPc0rzGUZXKbjUA57NnCkw1WraV6WWPK4zqhlMJNYl6UfmUGvEqW8gTjZy2Ky3VKL+ezCd4LVbEUAGAGQXqW2X4OO9aHUJqBtzvd//XolCMj8wDQ2WEDLK1RutGhU8TsNOaDNE0MogUV1f1IFxTHvjrqHWbsbmc8adOrcdvJauJspMenLlL4lWck1Q2Bpy9PtDhMoxRlFFdFkGBitem8dTkRHII7SWfVggX/RmW+pStdG5DdBTG/SNk6ZLIDPydoxQksvq+J5zIWLI2pbu/lpj6VFXkw+hJFsPiJW9pgX9b80BtpF4aN3B2boD8VL+I9VlwrfSf2wDCNFdX0ff9U8MA4Nv9yCrfQ2l7C1+1VPoZF5A9Ch7OaVMElH147bOtNO7doQeCIfP8uI8AnqmSv76qMPB47FUMP+EeSj9v/9YNVD7kWrf7V5SrR54lm8jzbeuNCYZamqftDjfCM2sYFFAHsziVnemefb3XqMwB3z3dM/KagsBTr/6EXLBBbCXbzz9vy0UL7851Pnkix/Ayem5KBbfkckMJHVFvXHIe2BASgn1I9tzdBu79T+WvJlMte08bhMbNM4HWMu485PL+0lppWVUW3RIb4d9Db1DdYu0eGgtXg0VDvRAPCXDJWgna7pNUGGPWEUoYxcuEySD9MEg57u83hOGuVvEZV5nd+pWS7YHosz3YwTcnhnGoEIw7BqPAthOr45+fz0Ay1zRtUQTRg/gwyZ/PX6g8XTmN4czP4vnIAuLRsPlTbn4IoacDNSQ5eigjevhg4pVVck+kLcuzzyv52+RQ9m/KDxudLT2n3xR3UgQuo//NIkj+4N5ibaHGHw3LxNqg3doz1UGu4nr//51LdNjgtvxyPQskiz7Ga2QSr8Z2tfQ/d2fT43300G vXWE6Mmp IOlZahf9OJErHoagkQSb1iO0cT8ydYJMMdLBCsCQ9Hs17axrWHFkc45jq04QriMOzTkPEe0xDkGmmL0FvkbbOjOEFIivPkMFirGkEwbIRM9RjSteIjfzpadixM0eIqaz46LbyD7Iuh4aYCq9mpkrmbs6DyJKmgKIYwe40LdklynSc/FZxjZCuKkqvv2pK7my/hg64E+36lhdzPlYRQRVg5DLX9P2CjMORUvgck1QKSASdeLVdl3OC2F7wjvT07HR2z1UN2Kx7WsXBH7nYShyG6cs/kC07n/OF9LESsWvLBm1wVoE7M97tIhIoDDxjCTurdbqP/a4uOIM8grsadb+9N0eoIk6oUsFLH68pHboAH7AhMyqvTEP1VkBagWOpO3DK0zA2fWFmw3xfk5D/s1GUNQcDEzztF5f6kMyqxftnDvKU/evPLj53v7AnWCxcrFfetCU9rMM9xnFN62cnLS848RNIOzqQTG6U0gnG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 07, 2023 at 07:51:43PM +0000, Yosry Ahmed wrote: > Commit 71024cb4a0bf ("frontswap: remove frontswap_tmem_exclusive_gets") > removed support for exclusive loads from frontswap as it was not used. > Bring back exclusive loads support to frontswap by adding an "exclusive" > output parameter to frontswap_ops->load. > > On the zswap side, add a module parameter to enable/disable exclusive > loads, and a config option to control the boot default value. > Refactor zswap entry invalidation in zswap_frontswap_invalidate_page() > into zswap_invalidate_entry() to reuse it in zswap_frontswap_load() if > exclusive loads are enabled. > > With exclusive loads, we avoid having two copies of the same page in > memory (compressed & uncompressed) after faulting it in from zswap. On > the other hand, if the page is to be reclaimed again without being > dirtied, it will be re-compressed. Compression is not usually slow, and > a page that was just faulted in is less likely to be reclaimed again > soon. > > Suggested-by: Yu Zhao > Signed-off-by: Yosry Ahmed Thanks! Acked-by: Johannes Weiner