From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81CE8C7EE23 for ; Wed, 7 Jun 2023 15:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BFA2900006; Wed, 7 Jun 2023 11:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14901900005; Wed, 7 Jun 2023 11:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01074900006; Wed, 7 Jun 2023 11:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E2FAC900005 for ; Wed, 7 Jun 2023 11:09:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B62C21402CD for ; Wed, 7 Jun 2023 15:09:46 +0000 (UTC) X-FDA: 80876286372.26.9DBE866 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf24.hostedemail.com (Postfix) with ESMTP id CFE1C1800DA for ; Wed, 7 Jun 2023 15:08:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=l8AsNQfZ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686150525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W5p2WzoMAd699TqoHJTiu99DkZxymavMq0558AjUk5I=; b=3iRu+ROAZkd7Z+1E9KT559W4kTSXTqFj5IyuHrK5YhZfWFIGfqawE4BVk+0PdEj+o6iyrm ksSVqqFawxBIBOpiD+vc7emqOPPghkIJG9CHwjT1Yio3+KYKjtg298UlIRj6uED6stF6uI s57NYeQu17v10uWTkinA0cnOqfY0RCk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=l8AsNQfZ; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686150525; a=rsa-sha256; cv=none; b=0QzymrL4HID8oR7wmAjvHyXXS9xsXzI6D55tJ+bLXqKoUtV5LAV7FWQDV4jdzkaiBWAeeF 75hmAydOk2prwdcWx51dwk/zKBMI1QnBaq3R+yFlOpbAyOCxJgfRGHGZq8WOPY6QhyGD6I lB0ZBQjpP/exOB1As5v/zcNqpfBlTbk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686150525; x=1717686525; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6TdsUePGYVEjerNbgyfVc3Eki0F3cK61GqMEgDDK4l4=; b=l8AsNQfZsrfMxrCPAr8AxBWj+YJvfYpzqkC4uOWG1vtlxBNU1GWu8GSa QeX6IdOV5+WoxWWiHnPJ8x3bYX323e70RLI12wuy76pNbwOvg0WRG8DkB Vn2/mkKssHA7acYfx1dqKD40ahGRdrq2XABGZYMV1OsCy89Apv+MCvyaR FjcFWbGDxVKER91KEXLsURtJEDTiAZI4UfB6r/E66YgbuH5KmLBySZz96 4TcPxNVppNLROl1TGrzM3Ax71sA1KDNfGzAE1tJUcv+rhP56hHxkN/QYB Arc1JwA3Wycg/zPCQWANA8oQL+srBFhSqofx/58Ljhlii0hjlLY/uTxyK A==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="443381441" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="443381441" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:06:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="883838935" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="883838935" Received: from akuporos-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.211.72]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:06:37 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id C2CEA10F0E0; Wed, 7 Jun 2023 18:06:34 +0300 (+03) Date: Wed, 7 Jun 2023 18:06:34 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 04/20] x86/cpu: Detect TDX partial write machine check erratum Message-ID: <20230607150634.te5u2q5tlwuyni37@box.shutemov.name> References: <86f2a8814240f4bbe850f6a09fc9d0b934979d1b.1685887183.git.kai.huang@intel.com> <20230606123821.exit7gyxs42dxotz@box.shutemov.name> <4e9acea6b956e1fb83b4e49fc8d154295e321f29.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e9acea6b956e1fb83b4e49fc8d154295e321f29.camel@intel.com> X-Rspamd-Queue-Id: CFE1C1800DA X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gkcikeeoeyxdbce346pu1n934a9wfpx9 X-HE-Tag: 1686150524-168022 X-HE-Meta: U2FsdGVkX1+hd0Bfyq3i8lXsWbd5W0Cx1EeIP+m5qtaphRHAuM/OyilfpGxf4aWK//hFdSTdZ23PLQX7VUN4NZOaRY/rZILC0cVIeh1Wb/UBcipxtCfvZg/r52S66rpu3UA79q+qD3g5bFKSIEflY8y+/rrwaILfU4o2VdHDw31AczClLfRTDQFLZ8fGuBne6UDyXJPyCrD3mXixb9FvvgHLe3lzJudk0O5J/LWYwK4uJVs3+OOWhAbtO8hGLbGoe0DhxXiDcZW1aeyThtidhmbFYzyyQ1D0YxPBAqaiWq6uQ78LJ5zsQP6s6Bl/FkIX3DAUI5iGvQfo6Kt4O05TvWZX5nvrxOjIbDodNfpXRIus5tSl4kuGLZctcNJUIki2sS6rnnbXu1uGkPe+x1ebZdYP7WstZ5xbJ4Jmf9PXOxdqSXT8gU7/FVMqab+C53X9/86TjrIEK8ug/8L4zAQwI3OvZoRp7LXaNPxsJgN+gfrBYmEl3ehBbRUdnhHfrfYsS2RJO/DlaBzjiZc0f8+sQIcAEyyzF9eujpVHw9wcmtWoQpqeReuZxcRdw9vmA0JL8l37WR1mbqA1J5mzSrN4ao3lmLujqAiy04N/SOJwvUgCyBSiIt0Z+XNpx5PGz1k40uJC2zFlNii/dUdzQp+HuZ+GEKEMQIfW3/KAmtSTyjl3oS5UELo3Ww1YI5pO3lqhxg+Y8Ibwjicxtd9WqWlS9GJ4El67uGg/vShEoK76DgVp9CJL94vtxWWpyfe/YJEeQyqdycBp+0M4dYxQZNA0Bu4DMHr7SwN27a5k4buTjlxQVNFKI4qP24CZNg7fU+0IF7Il8po9k2G7YVPPeF5yvQXrCbjVvux+CHpEIxyawdWaMHG6opjvYoHPk+dT2JZ5G+nUoImvuUCVESJaXjItt//CY9hOO4+mZmv6Omq4/ocajj4JMw+Wy14Ha/OfoD/lsmDucIKuOBqkPQ9k1Xn salrJNvx AuVljXozi5JRALpUDrbnaQIoKKZpA3dHcxD8foX0ZK9tu7WH/97cgbc+owEjFCqMPPgQOC5K8D/6Srfkg8Sl0n98i5RDzUbLlsWfhIEHx8tRZyPXp4SiCmsddYwyB8Irew9MyHfTrjEmnO/kShjOPQ/yLn1cbXe2Qlfhx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 06, 2023 at 10:58:04PM +0000, Huang, Kai wrote: > So it seems there's no hard rule that all bugs need to be done in > cpu_set_bug_bits(). Yes, CPU identify is a mess, but initcall makes it worse. Initcall is lazy way out that contributes to the mess. Maybe cpu_set_bug_bits() is the wrong place, find the right one. -- Kiryl Shutsemau / Kirill A. Shutemov