From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D7B9C77B7A for ; Wed, 7 Jun 2023 21:19:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E038E0002; Wed, 7 Jun 2023 17:19:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE038E0001; Wed, 7 Jun 2023 17:19:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DCD58E0002; Wed, 7 Jun 2023 17:19:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F0108E0001 for ; Wed, 7 Jun 2023 17:19:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0A24AA03E6 for ; Wed, 7 Jun 2023 21:19:56 +0000 (UTC) X-FDA: 80877219192.16.E8481A1 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf24.hostedemail.com (Postfix) with ESMTP id 28DA9180011 for ; Wed, 7 Jun 2023 21:19:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Dn0wciA0; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686172794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2OwwAPTsX0YV3vUdxtjfpz4TiWLtJRU1D8tBxvGSgvM=; b=nDI2+pb4nMP5FQ4cfNMnkqLQpvUFuSn74YTyj24d2W2dTpT+nSBnlhV4/mJjAdo1skrE9a ymIMorNgaYR30GA+FS43ccMyfOEWJfXwsyDlpgLb1gnqdWsQbcqDOmC4i0UgOUN4aYXuEK ZzXYxIKjIDKisN2iP/I1CI2xPy369rI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Dn0wciA0; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686172794; a=rsa-sha256; cv=none; b=5W3kH8OYCxQ9BAC6vmqVBRZXWyyZa2xEKNOQY/OoWI1st9k5J2Ubu4vuj6beaWsohKTo34 7V3f623YnrS8F/ESzdssKSZOb4LDLdJ3SWHS4ziCJ+pVUJ+IugmT7lQPHvOIaMHEl0pe8j 4cAQ1Zk00V4r/Ylhzc6WlrZuweV4hRw= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1b0236ee816so8415925ad.1 for ; Wed, 07 Jun 2023 14:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686172793; x=1688764793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2OwwAPTsX0YV3vUdxtjfpz4TiWLtJRU1D8tBxvGSgvM=; b=Dn0wciA0nzHX/RcBPG9bXLiBsfDH0C8i9UN4h19QGoCN+lXz6j0TtaghmiYxiYlatz dUC48YyfCOPEd3NaExvAy2oGXwf0DLKnjOsfdvOMBv9O3c7mgsdTf0l/eZf2dhkvtXNs Tkx8GQi4UFiuncFvzm6eLIaGIDZtFMT/meXs0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686172793; x=1688764793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2OwwAPTsX0YV3vUdxtjfpz4TiWLtJRU1D8tBxvGSgvM=; b=Sv5Jm9QBgZVbl7ztxD/WFANitkc3PHMKfSlkJ4kLVqCHY1dU9NPBFcFjnfGVIaVQr4 UoTIFQUj8jomhztWsOP5eZh4edjtXkbUQFDIA774V6v2pj9XssjhRYQ+PAdnuJVwS7Hu VviO3R3wQGaerllw8LXpnyGChWFXdLKF2q2AfGExNwXo68x4/n4Gudia7gu3GB9V0LSN SAIpo42Ap/xj+SKeKOcCMJWBadA7Z8fCgO9pnds47EGxnRbnCE7sqSNaVzVL1BqYYUV6 sttoPyhVqp6CgHvMksm2Zht1V90qEh5WAFT+xmQNCsniSCjO67MF9PS4rNHlUaaBXwUp 4A5w== X-Gm-Message-State: AC+VfDwyUwJ4SGMWr3MsOubPMzgfU+HWuxHnh9e2ysszp12IXDzZwgFU A2PND7lw9+0Pv4CbmjNbweVK4Q== X-Google-Smtp-Source: ACHHUZ5V9nGQDkdGfxISQMBDH8TRICjsCW5LhXfjuFShBXzhX7gSXaKHOiWW4nMsxpBocxsJSkfahg== X-Received: by 2002:a17:903:2350:b0:1af:ac49:e048 with SMTP id c16-20020a170903235000b001afac49e048mr186444plh.25.1686172792827; Wed, 07 Jun 2023 14:19:52 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id f23-20020a170902ab9700b001a922d43779sm10846050plr.27.2023.06.07.14.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 14:19:52 -0700 (PDT) Date: Wed, 7 Jun 2023 14:19:51 -0700 From: Kees Cook To: Christian Marangi Cc: Alexander Viro , Christian Brauner , Eric Biederman , Mark Brown , Dave Martin , Catalin Marinas , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] binfmt_elf: dynamically allocate note.data in parse_elf_properties Message-ID: <202306071417.79F70AC@keescook> References: <20230607144227.8956-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607144227.8956-1-ansuelsmth@gmail.com> X-Rspam-User: X-Stat-Signature: sk68uxmfuhefke7kmksbftbg4uzzwcsj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 28DA9180011 X-HE-Tag: 1686172793-267647 X-HE-Meta: U2FsdGVkX19tHni5M/h5a2vZvr02Dkt/kQ09P7TSLTvpwi1c+ID9CL9AFidZHTYHRvPCCg+Frw1ugHzpU8drLSRL7qCISwMQkVkhnTs2R7pYZ99Y6q6q/iAKsFF3UgRJQk9Kpu3yWdKmh1maakvUshPpY25zKjYssBlyUEHQC9vfbokSTe9clcKUcrslRYhUVCpBkxGSsU9UHFXaihKohoh4/rG6OnaKVh9ClV+saT9860XcgrIYLo02WL//pTDittYoQmsrkM4H36ZUQkw9kSbTzN0rj0ffO0rEumG9phr5onHeWT9KnkDoSULK6NW1IR3BckqL9cJREfVIv8JYMvjIwg8dP8xSTnv9dR6/mHamCXfH8+n1wee1sukoK9+9ervFvM+fGo5+0h5ic3nD30C5fBesUzhMjFTOvcqCM0m0CqeEE2aD6YNh3Ryb8iRXr4p9IrXlglbOz/pCgPihHJozq12kSxpvb6CsFwEEdImA0u/6UTHR/71vVPihVJBEls8KaWl6LK22qJmMX+W63rl5CZNpjtzyyVOymTJzZCdG/+SF1NxshMkOrE4P1pg7Ct8h1Q8MRAdxY+pWOGd6c2LT+iAwQfyvyhalc55ebA8ZTobRkavv/eRZDx52sy8yeXHw9fUisXQ5KDdc2Uf87rD8fX+yWGRkfeY9+/rLR98Akop2VpizrHOWxAJGr/ug9EtQsDRROgk5/FHPNyONvkNjBPFgmi8ApOBVhxluuQBb2S+fKY889DJhaDuUWRM1BXiGZMZPCnoUonWCERaeEWEWY2Yc4ZRx7VS0Jz5UQlvEJE1+b5cQZ8jH4qt1i2NBuJtaC3yqRPti8FNQICUTYljSI6ZZoeGNfcA1b/aROdGOrYnujhXg30qsYYfJt53B9Xf61tvA+u+RP0yMqzEsx0KNTzqqO5Oi7TWy3UXK5FnsPz1gahu1y4q9k16XD+xPQck/dZyNy3R0Ow/k/uB drlRBuLD MByj2ce1AQSmGqdH6ie3yNun/UK0WI0iZNZne+mtXglS6zf5RbZyA2KsmIWCiN3OtqkvbJqO/DHv/WRzFi9cT0KouCrCFAQiL6vLVKy3Wm95ZqLHBSuIurAIhgCfTtzTXVZwnoLq2f3zJKt/+Arm511BbkJ6Uu63DPpUK6sDGQT9tg9k0hmBwxE/NCEQau0Gt+nzIgT4aZpd9Pv60x+LouKvlPM4qPuQE/s5zueYVG1z/tjU6Xg0b7IZHyMQyY7CPcFWcpqtTb36Csim7WydaA788fh8Lf66MYgsWOgshEuxQSPJxgSw5cBee/6rxYzDUYU75vgOswDJgbUyS7SPQTtY1EaeExz4Zw4baW7492hKuLQLtk9mLYcA6yrQLe7CJyoOk/rk0eZfUSj6ZnDTBCZe/bQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 07, 2023 at 04:42:27PM +0200, Christian Marangi wrote: > Dynamically allocate note.data in parse_elf_properties to fix > compilation warning on some arch. I'd rather avoid dynamic allocation as much as possible in the exec path, but we can balance it against how much it may happen. > On some arch note.data exceed the stack limit for a single function and > this cause the following compilation warning: > fs/binfmt_elf.c: In function 'parse_elf_properties.isra': > fs/binfmt_elf.c:821:1: error: the frame size of 1040 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] > 821 | } > | ^ > cc1: all warnings being treated as errors Which architectures see this warning? > Fix this by dynamically allocating the array. > Update the sizeof of the union to the biggest element allocated. How common are these notes? I assume they're very common; I see them even in /bin/true: $ readelf -lW /bin/true | grep PROP GNU_PROPERTY 0x000338 0x0000000000000338 0x0000000000000338 0x000030 0x000030 R 0x8 -- Kees Cook