From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E0CC83005 for ; Wed, 7 Jun 2023 11:23:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB1208E0001; Wed, 7 Jun 2023 07:23:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62546B0072; Wed, 7 Jun 2023 07:23:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A50BB8E0001; Wed, 7 Jun 2023 07:23:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 921626B0071 for ; Wed, 7 Jun 2023 07:23:28 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 61AD4160233 for ; Wed, 7 Jun 2023 11:23:28 +0000 (UTC) X-FDA: 80875716096.06.341339D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id A2CEF40025 for ; Wed, 7 Jun 2023 11:23:26 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=l9jqMmOf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686137006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Edd6CqeT1Jv8wOOCIgEQtEBna+OKqySUj8TaKTFv8eQ=; b=f9p2wXRw2/qabSfRwxgmYZ1VaY0LdfDaP64JRvrIHQOIxa58kAd2oxfblTI4v6TWizC6bO Iz5OkDMXLeAaGZHt9xpPiSvNpkxCt4q6gmx1LEJ7DzpVeaGWejCnq8UAoYbED3zeEwrzUc i5WEW+uyZ0/uWKf/qty9g8Gsb+QiFgg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=l9jqMmOf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686137006; a=rsa-sha256; cv=none; b=FAw6UKR7OqCi57TId87t4q0QFtulrFxmenAke0mH1HQ/4lI2MkAdACLbIWK8LpTneyawqa BkiO1de8L5QVu1TA82ZXbpff+bDpOwVT9D+HzW5f3jVQn8z3tIuoFkBXGsb2z3zKbX0CBR KuAyQZeyMy/h75gb3kVHGT9FAAdtJ1o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D566613F7; Wed, 7 Jun 2023 11:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66A54C433EF; Wed, 7 Jun 2023 11:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686137005; bh=692XokvxKzDQrzsRY0aIK8Ow6Q63x8VkG9gKJSs7Pqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l9jqMmOfxNpxEBRsiMWKN3ziafDCD5xZkky5cqz2nXO3S7wnqKxVyyWuJA7hIer7U COvHylReJPdxeFRNY+cmqpKZDl4N7F8jdVbnepnmtZi3eXUnJ4tH5zvBjPsb3vgtSr JaZm2x/A6ACFuWHgYGRjqUHgM2ESd3APsRK9mZh5nPBVYRT4VD1X/HnhA0WdFIjGAn Hgj7o6eWMn1y3J078IvIXo3cxFUAyhJG372oicTmwA1b9tM/oI1U0M+ZjFYCLPhzlC wKsVkXXA8L5zefMFTV4ZceZbVwiQVf0ZWN8pdGmcZoYuBOjgO8RT5Luf4qtOyhmO89 MWOrQBAOssFpw== Date: Wed, 7 Jun 2023 14:23:00 +0300 From: Mike Rapoport To: Haifeng Xu Cc: david@redhat.com, mhocko@kernel.org, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init_pgdat() Message-ID: <20230607112300.GF52412@kernel.org> References: <20230607024548.1240-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607024548.1240-1-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: A2CEF40025 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 61kjmsijmr1tfs46grgui4wiompibcqb X-HE-Tag: 1686137006-928452 X-HE-Meta: U2FsdGVkX18TgWv08m8tmnoLIMW1snHKmpiCR/SwYZhXJO2O8am3MsERVaYmiyPIqVvHWXyXaVFCP89GSqYvUsjKOlwZEHyJTeACQKQlwNnUBdLRSNTKQYTQOP0WBocl/CaXOFS86irzFOSH7J6Fnx7ZSsVgSTlan18acGwtJTkKSe13J7KjrhRqNBTWqNGLbBUqJHLfxy2BQjjixN39u+CaN60Vny+aOH2k7+Q8i2dTWH/xqplinUh75x7tb4/K9z1MHqp1B1SKAkyH2ZPET7BgIMU9kpjNi2mKGjg0HPNqzU90omxhkpRhHY03CLNAOXehih2c7GOlDhKtkTbEwBjEnrq0kJX5hSWdkgQflXsFXz5GMBlKiXuNEGDqmksYukDhiSB9o3S6H3rETZN2HdniDovq3KSZjGA1TplxsgsGoE+IKMsJO2Y5Ia04VuJqobBKzn36drqiKt/zpxgM7NEop5Jv6OPwEslnZBYx/4Q+bCfGV4YWwaB9yAUiweTQuwDyo9g48WMRjcg89Bh9F2JpqZexi46Np3PO+EqUssvBAd5f/s8XSRYM1LikbSXIQkKpMSz7x2YuVLTk9fuIoTDLJVng8/53I+4/+hncHQpq4ttR+yWZOa9lS/UHxR1sg0HNOKHwusVgRByBGV3rfWUopTipUaXV/Us8OZBOkh6podrf0ZFs/1gROFmhy2aTdbgo9/7+tiaGE7WxxhzYbapmCvir1tgEERw/niH6xS19CaBUw+MCmnOt3jJjWdobwVC1Ls1KbLmcvJ4iuEyAPlibDEuh3ns1t1SmBPs8BLZrnPForJgqzgSMtUBQh33gUrAIzb6WKGW05zobcowntFdnWT79IMoea1GJQeLz75jPFCsjUC34LtmNR4gSMZnitxR2hkqQf6XPw2AM7W+qp5dF/Bc2gCOwBLqE5VEEWUN6ZVB2Qv68yCyBAXcpK0iYoB4pfHIFnxUFwwMpGld v9MUGUVg 8gkVp0dz/p8TqP278Rn1if3RBEzxYB8tSk++6fa+NKJzNdC/m0eyFOg1hjDy3VWdMx3jPNstVoVQdPV6FM97eAnKjJeM6/BcghdCB15AaY9MvXqnh8xsSD7IZ10IGixNaThbH/vyCBqlCRhx0EnTQ28DZvXecCD+B1D4Fp6bA3IwpWd0gsK8JqOmuuTl62/C9j9p9Ikt+jm4rCRKxI7RMhgJ2cN7yvsvGGCAAt21SbnB9kYrX32IpFMH381ZzyfrRN+4iFOfKGs3icCIAR3Ja1BCq9swcYqVlcSNruEMPv0ovCQOjJdUg/0+YM8fI5ukmqCIUg6DX20ZeJXcqOkU/zeQIzESNVPXgem7FFvWdZ3hS6zsWYyDabxOzpM2kW0+Zh4coN64ziEuCbcsgSRueiVtA45wQnhKKK5dBL44Q0992f9EVCxCWByCJo+NwQf9BpfF2pTkPjib+YAOFjzi8mJYbKY0oBPYRVlzr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 07, 2023 at 02:45:48AM +0000, Haifeng Xu wrote: > managed pages has already been set to 0 in free_area_init_core_hotplug(), > via zone_init_internals() on each zone. It's pointless to reset again. > > Furthermore, reset_node_managed_pages() no longer needs to be exposed > outside of mm/memblock.c. Remove declaration in include/linux/memblock.h > and define it as static. > > In addtion to this, the only caller of reset_node_managed_pages() is > reset_all_zones_managed_pages(), which is annotated with __init, so it > should be safe to also mark reset_node_managed_pages() as __init. > > Signed-off-by: Haifeng Xu > Suggested-by: David Hildenbrand Acked-by: Mike Rapoport (IBM) > --- > v2: > - unexport reset_node_managed_pages() > - mark reset_node_managed_pages() as __init > - update commit message > --- > include/linux/memblock.h | 1 - > mm/memblock.c | 2 +- > mm/memory_hotplug.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f82ee3fac1cd..f71ff9f0ec81 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -128,7 +128,6 @@ int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); > > void memblock_free_all(void); > void memblock_free(void *ptr, size_t size); > -void reset_node_managed_pages(pg_data_t *pgdat); > void reset_all_zones_managed_pages(void); > > /* Low level functions */ > diff --git a/mm/memblock.c b/mm/memblock.c > index 3feafea06ab2..da4264528e1e 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2122,7 +2122,7 @@ static unsigned long __init free_low_memory_core_early(void) > > static int reset_managed_pages_done __initdata; > > -void reset_node_managed_pages(pg_data_t *pgdat) > +static void __init reset_node_managed_pages(pg_data_t *pgdat) > { > struct zone *z; > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..65e385f34679 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid) > * online_pages() and offline_pages(). > * TODO: should be in free_area_init_core_hotplug? > */ > - reset_node_managed_pages(pgdat); > reset_node_present_pages(pgdat); > > return pgdat; > -- > 2.25.1 > -- Sincerely yours, Mike.