From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D35C7EE25 for ; Wed, 7 Jun 2023 17:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E5338E0003; Wed, 7 Jun 2023 13:34:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 495B68E0001; Wed, 7 Jun 2023 13:34:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35DA28E0003; Wed, 7 Jun 2023 13:34:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22D918E0001 for ; Wed, 7 Jun 2023 13:34:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D27E3140425 for ; Wed, 7 Jun 2023 17:34:34 +0000 (UTC) X-FDA: 80876651268.04.3129ECD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 0D36F8001B for ; Wed, 7 Jun 2023 17:34:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f1DYw+dA; spf=pass (imf30.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686159273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vlfEsUmenNcOuOU9pMuJIRbpVHXDmEO4+LZJj06Pkzo=; b=l9OB9uf3qxKcA6MLN2Y7zYYOLSC5wSPROFVCLsDydEj5B2n1O4Jxp/vpi+sVwHMVKSvqEM R6t3FMZnx275wc7GT9OGOdchfXgYfrbx+JC5HmF80cstOKEmpDwPHfoRivCMjJDVYEQrky ElNAi9qM8PANflcpvEtIuOLMhC2dqV4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686159273; a=rsa-sha256; cv=none; b=1rP50bPnuygQsYtc4Wo0Pq8mR/AaO4sLMo9wiNTOyBgyHZs/OqrflgHhlm1P8DIordHVjH Uzfz+Li8vLeR3Kuk4wW0qVJskbMIIS9fDruQ/RbY5r0/kantaam4xEPESzZMHBK7+83ruM kKuEqaDZGYXJPIXD2N32t50WKTJ/G7M= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f1DYw+dA; spf=pass (imf30.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DB15964210; Wed, 7 Jun 2023 17:34:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B558C4339B; Wed, 7 Jun 2023 17:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686159271; bh=ZvKkcdQ1lOUxF1b2GWrc8NYGJ2lVBPJVjPW9hRJYDeI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f1DYw+dARGN05S/WBtv2Cv3qeGsq03nD/hjgdBmRuZn7tHofzqrcVc3qmxpX6RZ9N xIiXWKferDCKJj3wBA163Od+ev9SAuMo2CRtKL4Oc+BFr+y/gHHwcPjLN7wRBGbZdr DH0YrspVUj4s3jnJ8AvaiuflIIoreADBS+niNH8Akf62Svt4IQVHY5ziZhoHXXiqzg cx7QTYjjdNi91iWHPWR1sg9fy0YZVA8mE5XT7KcioQ211J5NadouXr89vDn0H1UYtz lCS8bvvAORmfeuLFBO9Yhk28Fum6KK3XHkF1CjzZNmuVffM8ro2wHac2l/3t5fJ5WO U6m8y87qq73rA== Date: Wed, 7 Jun 2023 10:34:29 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES Message-ID: <20230607103429.2f4162af@kernel.org> In-Reply-To: <2293095.1686159070@warthog.procyon.org.uk> References: <2291292.1686158954@warthog.procyon.org.uk> <20230607101945.65c5df51@kernel.org> <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-12-dhowells@redhat.com> <2293095.1686159070@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0D36F8001B X-Rspam-User: X-Stat-Signature: 9qk4ysds6xeeobtotaxdxx49kn6t7p7s X-Rspamd-Server: rspam03 X-HE-Tag: 1686159272-530112 X-HE-Meta: U2FsdGVkX1+cM1rUtMO6g32Dl1fFQjnJmTD4CN4xkvyEexKuK6I3uLcQsmn6pWxglkYmPyReXuLTkxiL1TwQVooI0kCVnUxYCawr1NVSxx04WU5djNaq1iI7aeTXIYLtCB/PvYYwpZ/iSA8oSWeKfml7tfxl4jtpA0Fe/mMxgxEOGAXUNlvfjR10e990yu+X00l3zIQuxwr3TKAEuu7k4Keamc92iCoarcV3BIKvf/+UoUiO2wWr78ok+0824VkvqwwxGMoh6xN4npZiyWthrxJo4ilywlSTn5ceJkgjC3ZtOyPjj3PyQ6JTFqQCGze63w9jxyYeWNQUtVOOBxkrEs/hGNDpJ+VSEZlOJZ6jjj6dMsqIcFVL3t34v+8kqJuYPEolV/33/XER967kldrqBF7/2IAq0/vPocCKC4cEyR/BhbaYRSZXKAD+0gsuEey9c8S/kVyVVq7Nvs50R5rnuTjAxWH8cIfb8sk2vua8el0c8iekgw82o7s+mbxjR87omQbWRmu6GmMiJ8a1m/NAaLQ7ZlRwU4xxmeNIdvQxzAQcGL3a7dygKJKAduuvXOG/dXdfpLKt4Ntk66fYxpQ2J/KyJ6JuaWtZRmEtKlc3Yvc/+xEI88IpViKioLPlgb6iJMle87oDUBybLuaZcJ0p2pUERSWHIQMJFid6hgEOJvKk8wvECYYemjmNLfw0tFE/SHe7LeddKBLjbHO0g2/CkhCbdqbLxIcSLmFCPFvMbG0TJ3NplktnHw7tFHD7zF3XqG7aR3VRucKEtFGl8ra0FoaNTTJ6KqwRcOzkSZT6JhibjAiB1GCnk2IY7428M1oNk+dkv0v+TGFIZzuFkV5O0dJ3M6joWacc1VL2FV4ZpzZmVjIdZahYCWwEhHFtnWOtJDpwdYWkwOFhFqUB9nnA2SKSXvZ3x1h54hPJxXWTwR5HPLCSXMbULkabrU12tecgZSfOE0viKk928iJotM7 Y7b472zA krHiTH6RCr52VEanwZ0tgtMQa+gPdKQ7Uy+LcecX07HW4iK1bU+xj2J9ZTy1NAgyPA23tO+S39fFxr1iKbq4bJSiP4JBHT/MZo9jVUYKovAcH07Qr1gOy2bCW/vyYJzZaiT7Sc5QYRFv/2C71llb9xX8YDM5NbtKgo/2mrUvD9UqvPWUqtLuyF/B2SrId8NY53jqWxQ/OejZO/IbBWoeoIgOyE47RUVtx+7vK6JKruSQCLKoFhPdNgdS1lmnHklQOgQUmCx48AmrGLA41V068MrydPqN3mMrq7DyXpc3s5fci4GINtfGlSQ32amef53O5lbuLArE7xeP/5nh9zaQ2GsHDCYw721tYgXaSOzUgEJrJE0mxt95kQ+O45/ss+qG+u+rV0YpA0SmYjiEMlycev7BFSvN5nNEoEqP0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 07 Jun 2023 18:31:10 +0100 David Howells wrote: > > > Why move pending-open-record-frags setting if it's also set before > > > jumping? > > > > I should probably remove it from before the goto - unless you'd prefer to do > > it in both places. > > Actually, I need to keep the one before the goto. Yeah, feels like goes together with updating copied, really, not no point passing it all the way to tls_sw_sendmsg_splice(). I'd drop the reshuffle next to the label.