From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382A1C7EE25 for ; Wed, 7 Jun 2023 17:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADCC38E0003; Wed, 7 Jun 2023 13:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A64FD8E0001; Wed, 7 Jun 2023 13:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92D3C8E0003; Wed, 7 Jun 2023 13:26:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8306F8E0001 for ; Wed, 7 Jun 2023 13:26:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4CF1E40456 for ; Wed, 7 Jun 2023 17:26:04 +0000 (UTC) X-FDA: 80876629848.24.457AB89 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 9292F180023 for ; Wed, 7 Jun 2023 17:26:02 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NYJztc6K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686158762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tw5o6fPw9gyzLqlDqc81hSMsgIXuIKAfkg7pFLSJhc8=; b=8NlMy/SQkWgyvvvFoaegebzJODovq1IvtcnaYXo2hwXAML9iOLgi97LntnFBOPrj7JkvGF 4PCAzK/1ayoFuNB6ZiS4JtmYxouQssdFh/1j4mpJCdVScWlqfabct6T4Iq2E5GpdlJW932 7f3oGYgQ5yprvVriUaxHwD7jcl9d2pQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NYJztc6K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686158762; a=rsa-sha256; cv=none; b=qib2Fgi6dD+ILiitMtDE/DfSxRYpgF6FwQXTNyYQ5LGjvFux0uLIglZzEGcfSZljt0rznL vpUfJgyItOrnsgewbUs+mpdn5nttFgJn/+is+9uedl2TYgucgy7FDlDz40pGZ6CuqUpeLF B8wK+9L9ZQNu0skMZXjBuLZQ7yBqKeA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C6C4A64200; Wed, 7 Jun 2023 17:26:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05812C433D2; Wed, 7 Jun 2023 17:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686158761; bh=0MBhuEUX2bktmVFKRPGnv8oU9W5tm0XrwIeAW9OBqu4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NYJztc6K5jZaEpT5qmYChibBOYzwSAkpmz4luHH2EERw0PJbUy4NdUK7sOHmMohEv L4Y7jZiccYhyhFR5ioEP01GXWEyxpDJ73Gab/BxVRJhCWxnFAvzE29QxtsB3IuT1xn qTcuRgtm/jMMrfC+i53EtgpTUIBBrnLMh+sI0NfGT4IFKTnbOOgHyY6BB+ny035F9E av80Tcccr/PaZaKHCB3HTiybgCAWkD4ePOn5L4H0tXwCaTFgXNFkqzK4UldjZtsxwy rbwwSEegzCShGku9llVhj8mpPI6xq3GpFvw8RP/8sQpd1zt7NT2VqVpvzleaooJKow euaKcvwu3sxTw== Date: Wed, 7 Jun 2023 10:26:00 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 14/14] tls/device: Convert tls_device_sendpage() to use MSG_SPLICE_PAGES Message-ID: <20230607102600.07d16cf0@kernel.org> In-Reply-To: <20230607140559.2263470-15-dhowells@redhat.com> References: <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-15-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9292F180023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qjt9mutkdupg4qnps8cjyp8rp76a9pgj X-HE-Tag: 1686158762-666001 X-HE-Meta: U2FsdGVkX18PEL/uURPppJNxdk/moeavw0tK0RB1yRAMCrSwtUPIXhH0TFgUp9Exy1MkTlJqpFnPLYyKAWdbR5apU2eDUhPGXZCFMHECRggDBF8K/oVv6HWAPL5nqzx+ASYWLVdzyPEL4JnJc16c8axJdzk21LAOemKMW1y26+s4xd9P5BStYbKaHlnQ94UyDqVYXWMT2n3+860CrA6BbzmPDFS1wQm6BPRRO1WGCWZLlyGM2GsmM2L190XCgyZTMcqOdG8rx0blEp1rBwyQrxB9tZnCnOXykTE0Xu79ajIuD4056Nco/zjkj3r8VKcg3T4mI2klwS+o8dXVEIQ7dPrZpN93J+SU+NUntG1m06cxemEOMv+utKn/KdPKwnI82RrcSKXSEQdeE7cKHos9PAMPJDprL/LQ61tSdcp+V39JS+0G0vwXU6dSOkWCmz3bF4pMpj+VNyG5QeJrgrdVNSfx4ts1IwCFtskwBbRijUOvFLpIGszqNIQHq22roA6K0Auv9pINI1u3NP5r+BwVCzLefzqnBPqnJ5YTpNmWlL+gxvOhrFgM3s87Y86OWc0j3T5lwQgIi8dVPbBl4+AQiuQlPAgnZmWmNYuttFfkg8LroG71OCcBFMI0XX1JEYNIW6yy4j7iTEYKtuzm2f8h47ID6qvOZzTrEJ4/qsxJh0O4TbaFUSbGh1vzSi3DVcm2JlinPpPvtPFGjnbPmNEJqTeGbmql9UAIR3INH/6NOY0U35efW/GGvdb8knvIfPLMCS/Zhf0jwJNxX9KYKdc4UzYM16i76BTx1Sx7d2I9iTEgVCBNjvsY3+ceSbB0SjzryuqNn9Nu+eS7ZDWQG5tNAnDez5iE6QxUVHHuo9Ct34w4LoTJ1lBYabs4v653hv9G/jSYxGOPqYK4n0R+InOlu+I7suY7QSVS86FZ8afBDcJsNBOn10hLuFs+vhcrOlojK4GprVj6var/gRZLwwp Mk6s0CQ8 qN+sOCcEvaORLANe0Z5piVQAadSagMiFxDNKeJlbzOk1iA2O58Vhsh4z3e1ENJpGVq0Qbj1CQGZBH5Ao4065p2Alymlosa2R/MP3OeDsyTvoaqhVWTv7Zpfm57HX/vM9GQ1vetzoL5JlnCRzZcxgctor2oEFH+fZbym87kS+Lhma4MDjAYL5cfF/XWG5S8Xhgwl2wwVlNI4NdYGw2I/YXo4D+364dMYR+qaCok4eQoq3YhSY0ji9bIHuIwAdh5AUIzi0vQlx9qyy7GtxDnP/fgNiDhwqZP09odrCYlwUsG4sXRQWzewpKkvMTCWpTqSGYDMNpOtsQLZcd1KOBJWol6BhhIhKXZ5oTS+uthhVZoovy+wHfW53WmzeFHKHe5wV1V366bAFPZPFjfSPSIL9ahICvm+KY2xVvlTnF2PwBBRBZSb+pi1Wq+sZqycMJtoyHxmhzpNNxR1+uTbDV0XUyrbFU76SdYAMmJZe4RVG8DhJ0AvaQg22OkjzJSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Jun 2023 15:05:59 +0100 David Howells wrote: > Convert tls_device_sendpage() to use sendmsg() with MSG_SPLICE_PAGES rather > than directly splicing in the pages itself. With that, the tls_iter_offset > union is no longer necessary and can be replaced with an iov_iter pointer > and the zc_page argument to tls_push_data() can also be removed. > > This allows ->sendpage() to be replaced by something that can handle > multiple multipage folios in a single transaction. Acked-by: Jakub Kicinski