From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A74C7EE25 for ; Wed, 7 Jun 2023 17:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33E1A6B0075; Wed, 7 Jun 2023 13:20:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ED9C8E0001; Wed, 7 Jun 2023 13:20:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DD146B007B; Wed, 7 Jun 2023 13:20:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0F48D6B0075 for ; Wed, 7 Jun 2023 13:20:28 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A23A78037A for ; Wed, 7 Jun 2023 17:20:27 +0000 (UTC) X-FDA: 80876615694.12.411D8C1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id D4BDB40023 for ; Wed, 7 Jun 2023 17:20:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QrgEDUrp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686158425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mp4qHtlJS2jk9b2saG3EpebfyEBIrlg2e46Lmm6jsVY=; b=PIEaVG2IYhVk0IWuXcmRRVZy+YmIFjmE+vI3IqKxYH5gCsBbo/iPBQLd0SpOQJezHXPL1n Dwuw2OgUOTsMsSPUNJI4Rb+H+SRN3EVlmbCRVQNVU6n2IGE3i2boWA+gWcyVqZ7vjwqh5J rr2Pbv2TfaH9eeMBhnUWnynDO9N2Ags= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QrgEDUrp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686158425; a=rsa-sha256; cv=none; b=zcSEcsodUL7AUtiBhgp4Gg1mgmg0RZoPrOYFAUJxzj8/Awy0hoQlTthyodMOVHVAlRsAD5 D5wjBKGwpU9NcwyF4Wv5BNw6vGqdf38Fex5xDGWKcwrByHllOXS8VRut/5yhkG5oKoKGEe VoGXTotEDR+PdiAFG3Q2NgOWgVpkFp8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1139D63AC8; Wed, 7 Jun 2023 17:20:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C17FDC433EF; Wed, 7 Jun 2023 17:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686158424; bh=adqvDA+1TjaAGnTMKfAosw2t+UHx0gdR3o+C9+WLfas=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QrgEDUrpuvtjtYYXyNXRk1dM2+tU5LatKXwXs/1xrXOOFssrCslRRsYtUyt3hdrkn Dh+x3YRI3wjtLLcilrzbAlRVvaLYnG0rcVd/Zq5rTIqTJb/bk6b2AdJhN2Jwvr5VQy Y+psu3Ozz53QvE8pkOaoGyFJra9fJeporG6xTn4ngLRRqX0uGjaWkRdg3rbA0NO/bn Ou7iQI5PFw3OR4mfe5YqMygaocJk4FR2iqfVb4093jkA93CKs5hB+FL+jEI4h/LAmU z/1SnG7PASoJh0YamOmuhju0WO98sy0xlKkuv/wDL7v5AV7XKcTVyZ4CA0JS3GEw1z tKCVsbaX9/Elg== Date: Wed, 7 Jun 2023 10:20:22 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v5 12/14] tls/sw: Convert tls_sw_sendpage() to use MSG_SPLICE_PAGES Message-ID: <20230607102022.42498d4d@kernel.org> In-Reply-To: <20230607140559.2263470-13-dhowells@redhat.com> References: <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-13-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D4BDB40023 X-Stat-Signature: nq3u1niq3ukd91yboht8gejmstuafpgu X-Rspam-User: X-HE-Tag: 1686158425-880943 X-HE-Meta: U2FsdGVkX1+xBKDRAv1TOJLYuZcI7XVw/hff16LucJkJni486MYvQELd9/TqGdV+cDvRyUM/+j0tUOpcusDDTKtPbdgkF3AwaS/fce4/KqU+Ah/NzST32rnNNLJyQknnv08NyqKI8lKgXMWwzs3Ss4Dg18AHzjF/lezDM0CzMxL1PtzrU+ZxKKQP7B4fUi97y2K51YxUQZiz7sUJh3ntuXwUEqU80ectJOnbNytVoV5bc0TJHQOII0+7ZXLZJF3AeGf9eDXvOd1n/uTgS+v3IckdxJbKYAB3mF5eQ/fLQeQl5CT8aqiGGcZs0gdISMFc5ybMil5hqsCaWw+Hsd7dDgohO3kyjQKX/zGaYyt3s7CZaUq9/NS12cBWq2Y9VWEjj75SDfkvjBYMKG1rq//cEkbnUTIVfFDaBrrfTlPDdLGUChCh/4IJEPXj9JTu/QxooTVvhIJqp43v+fOrAichBUq/PfW8ZMXsAiiD8Dp4vsyHPGt3svatZAPSMGMDXC8aejBctOYgg7vagClM0JwVM7ibvaJ6sYj16ul80rM8zntYjZZu1r1NNUWE2jptAtMr7n2N7irZGdmX5b7aDPiCzcs0VxZbDjYh/ryuob2tqYDLYb7U+nbkS4JX4egRvLs1DHSD6Gr8wpHdijgoflmS77Tw2R2+wt7kvy5yaNS8BCT9N4Fv48kuH9uQpnBa1xRpywPFfDIIUey+J07+Jmyscf7Ds10srIwy8WzbXEPiJF4OWn715itv7/YTmALik+izyzZ+syscVoArv4dyWcKaGIxoJehoZUN82VpaKoeTl9ekMTXIk2BZ0V5gCLd+QzX9qN12pS5JmiNvEw2VwrHNDoFFGMGF6CcdJIropCFf5j/Y5CHTzZX2b9Mcy3K4sJ2t7ye8gfOQs4kBmXbNUhiXkLTeCnvPdGiZfYxS0zQ4aJURtJRJaq0LqyD7Plc87ak3lhGYCsOwZ2CrhhjrBa4 i70MUwJD Bv7esyHfYQEQgsmqYHimiiwrcrqwHzD/4j6XORiHbRChqAcTH6rvqo5nmeWA5bDRvqCEjTu3JXsaW5rULqCbdQhfYt//Ff1Vny9WCGDzo2gphAtH8MmVc9GFYZK8dWXtUAkPR+SxkK6iK+/3oJnWOe10lb8uhi8KLIClKrmH0uXeMAJsqqWS96rn6VONQ+Cy1tezXsCnJbXTJJHzzwDGrkrH4WuCCxQy2FNnGsyYGJJeS9pVRYzDvtZfPUDgMuEr177rfo6wNE+0ntdGuLi16lP0qT24i1lY8MtoqVPI6rA9qI/Bx2T1v+/mRbhiyeQrTD1SG0jIYM2y+whv2Wx++lFwKw3k0whZ10ErSxS4mvSDGnE6NszPqCWRY6g+LA45YPGrw5TdIlEJAPj9Zm5obeONYSjrIa1S7Tq1ZL9VKZfB0ATv9r5G0tQF1FBdjTevraBoDP6/ZzehtmJWgvBfV6M0ZSflPtpGcxDy3HTSbKAe7wnZhL4fm4XR5m6zl3h2PSrQ+8V14tmkOJ0U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Jun 2023 15:05:57 +0100 David Howells wrote: > Convert tls_sw_sendpage() and tls_sw_sendpage_locked() to use sendmsg() > with MSG_SPLICE_PAGES rather than directly splicing in the pages itself. > > [!] Note that tls_sw_sendpage_locked() appears to have the wrong locking > upstream. I think the caller will only hold the socket lock, but it > should hold tls_ctx->tx_lock too. > > This allows ->sendpage() to be replaced by something that can handle > multiple multipage folios in a single transaction. Reviewed-by: Jakub Kicinski