From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03871C77B7A for ; Wed, 7 Jun 2023 16:56:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78CB48E0001; Wed, 7 Jun 2023 12:56:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73C776B0074; Wed, 7 Jun 2023 12:56:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 603AB8E0001; Wed, 7 Jun 2023 12:56:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4DF396B0072 for ; Wed, 7 Jun 2023 12:56:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DE870C03A8 for ; Wed, 7 Jun 2023 16:56:48 +0000 (UTC) X-FDA: 80876556096.11.AA99A7D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 3B647160020 for ; Wed, 7 Jun 2023 16:56:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Inki/nRU"; spf=pass (imf08.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686157007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RaNh/eQQV0/c3hFtm/zuMjogYq3Sxb0ZAH8aMfx2Q4A=; b=w2lf4YsO/FYqTQrppcffkXEuDesdaljbCyKBHe1h1rrEhsH3goLHpnQiJhI25kAZk8W+0W 5aAr2OORUKZxSC7AkPMBGLHDU3kqy8gnViRmok1Rly3APw6A4BjLOv2nJl/SGoAVP6D0sH RoRDwt28GMRB0tzO7ygN9ua4N8r5pDY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686157007; a=rsa-sha256; cv=none; b=jG4UjKoYNmLzsHH2USwL7VMwsZLOYWNrDawJOR7zohOGN6NqFrglxcctfsmxrT4qjPm1h7 AZSHV0W5s/mX5CqfvQUxua/iKrXzpn9dZBnc1nyGTzM1c/rhLAbanwmFGOu9+Y+whR8085 Xx90jeLorJfyFsmAUxUKH/19c/NY7Ho= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Inki/nRU"; spf=pass (imf08.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 38CA763B49; Wed, 7 Jun 2023 16:56:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9642C433EF; Wed, 7 Jun 2023 16:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686157005; bh=aPvBZetYhuElDrsk7XgaTFNO0pGltg6x0ZotRqSwJPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Inki/nRUfVwANPsVcJ1lXwPjALjzfm1hJuhTUtyxbCdDVKiA6DT2hysaQq7YRArkY TmcAYk6xx2FxD6ZvT/LxBhyATpqVWXVwoXsxT4L3Fk+VS7tXb7l+Ezz8YYFYq8q3oN 2VLd8kilvOMvEceRci0tIwOEfxF6ZWhZW6zJpebJLwpnoIu63ZhnwNcgUWuTFd3ibp L0MsVZNJ93F5rs2zGgKC/I5saeGGpHAMmCqleqjKHOf2+M7fX4kNpTZjTklqey4w1L GcKK0AbFASSEzR05VPsh1SBNgSFAMsHKsDl80TScNufOJ8BAovXa75T/RLI6PZf2dS ame/Hiq/DI6ow== Date: Wed, 7 Jun 2023 09:56:43 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Al Viro , Jan Kara , Jeff Layton , David Hildenbrand , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH net-next v5 04/14] splice, net: Add a splice_eof op to file-ops and socket-ops Message-ID: <20230607095643.38c18ef6@kernel.org> In-Reply-To: <20230607140559.2263470-5-dhowells@redhat.com> References: <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-5-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 4pkg5q3fz5nk3d1uju5juok1q6gku1u3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3B647160020 X-Rspam-User: X-HE-Tag: 1686157006-880203 X-HE-Meta: U2FsdGVkX193LwX7+7pOhk8uYqVkMmSXAZAJO8a5UQEqTunl2LZ7w4Kur65nYGRxmPoX+WsEssTQoNlpQX4imp2Bl0Hwb057c31RdMaT+54GCWvdbQOmzHwkxpQwORm54SUQy3hR0ZbcgiI9cSJ0BaXCtk6BHpBWRgJt1jL1tbDDyXfkAWH+gzf/S88p8rlQZkmeOYA+FnMYoXuUCfDp/5VD5FvpA6+V+M5uz2I+i4PHP1AHhnW6TMWmI+SeuaX0kIpspBeK1xdE2dC/DyoU2rQ5t+q/a2DDJuy/hBz4JrpEyuLc9zPYkz+Se0h0O/WZCAghbXbQK+h0bYgMCSZBCCCpHAnguSDxpRI+lvCL0PdbTQ2aD1ovAOtYTBFzSjS5aOSkElZzwoaAf3X+R2TPwlvyVtziRbrHdzK5KPy4z/9z9oNTKzcnBxo0Be+kSY5L9hKa8uYQPkoNBePEhAku+Pkl3OqFkW/WyMtsYn4yHXg+sfvkk2h6Aib8+FWJofYAAxUr0MR/tTFHC/fIC6nM4zdJgCuv96dPs4a07cw3X4EoQcbPzqPAT1a9FyXcuHxB/zSdLpAA3jgoyQB4uOwi/lgkabJ9evJBmFp3pSGPVU6fXS2CdUSgIyd9D+wLwXSjsXqE9wb2YkJfby7vOXlJMhoEicDDh1xTATpoatPgSuEw7OkKBZ5rGz04gedM8FRvNr3mRtCRW7dcJOEC9WHyWIl6a2X4gQXEFCq9kbFX701fURFB94S1KJYFVNRiLBVQwMVsCFOnv/KurqhXMxKGJ7ZO8GyZPFb4V+CFeb62bncIpmVaMWc7++nD2L0+uFIbS9h+TYiU92stX5deqBa0AOrH7QDGQr6do/scievLYA4+cqmbaKcH2OElOEPPt5caI79/Ho+FsxQJ/XyUF8ktQoe/uCR7ZKAf50TQhYDPGfRoWsTV5Zj3P9JBGvguZv5hnrLYTc4EAmOpIAnVOoO 6src6cPf 9M0iO9Wz96BKg5I5Aszy/xxw1aG8FihxGHqRQK/6GQvQeT/LClBmdBSXPHM7cxcPBJNJ4eUAZipGkDCEe6+yXY5lmp1daqzg1cpD5jskPqTstf6zW9k+Kk2QqQpQdHnH9Cj0UKaeLnIZDqD7CS9xZEvuFInpGVyLEwFjqLi5DrhJ8CFpstVAforYUX4Cdj3C+zsdPjKjh/7JZzWnK+R0C1EIr2JMWF5fMWooW+4V9xJQKHeuG+a2Pgf6H1G1vA/SCdK9ShelIQhA82Uo09+gmAhBzqNFOYLT0lFWzjlBProcUwDsibMb/nwNKsqy0Cc30VLIs8TXiTSubgEjFMupUGT5S7e2cW22cp0Z/tZg5Maqyf1DIkuXIE7qRfdAsz3h0lCJp5/nYIlNU1C+YbOaBN2KU/y4r2xpNzthpF9ZvnTN8WPvjGXvVhWL7wxlG4GuhStU2BGSlFXnnm8+JkTSmcJIA9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 7 Jun 2023 15:05:49 +0100 David Howells wrote: > Add an optional method, ->splice_eof(), to allow splice to indicate the > premature termination of a splice to struct file_operations and struct > proto_ops. > > This is called if sendfile() or splice() encounters all of the following > conditions inside splice_direct_to_actor(): > > (1) the user did not set SPLICE_F_MORE (splice only), and > > (2) an EOF condition occurred (->splice_read() returned 0), and > > (3) we haven't read enough to fulfill the request (ie. len > 0 still), and > > (4) we have already spliced at least one byte. > > A further patch will modify the behaviour of SPLICE_F_MORE to always be > passed to the actor if either the user set it or we haven't yet read > sufficient data to fulfill the request. Reviewed-by: Jakub Kicinski