From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0958CC7EE29 for ; Wed, 7 Jun 2023 08:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 762436B0072; Wed, 7 Jun 2023 04:19:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 711EE6B0074; Wed, 7 Jun 2023 04:19:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6009C900002; Wed, 7 Jun 2023 04:19:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F6CD6B0072 for ; Wed, 7 Jun 2023 04:19:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 25EF01A016F for ; Wed, 7 Jun 2023 08:19:14 +0000 (UTC) X-FDA: 80875251828.25.0AE67DB Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 4D5B6A0015 for ; Wed, 7 Jun 2023 08:19:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ey0J6ANp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686125952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vUw3pvnoCDVchEZbcmCMTv1rymUUdjuYDIrMsGD+/vI=; b=aXDwHT4L5lYV5gerR/UMUWR3apNARNg9rvmdYyoiCegZAJbPVRSE+yK4zzTLLA7M+x1XJl m3HdeAK6/qZbsklIxOnVHbBEhY9GHNLwHcPB/RxNlUKnNCgMs7jIoZs1zzOyx2fZvZ4Jlm aKWtCXzmKpm2LNyNQtbaoY7vwwpkcLc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ey0J6ANp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686125952; a=rsa-sha256; cv=none; b=Ugm65UpJ0lh4xfuxMKZrBz62fYfhaYmmNI6NVF3pIMFErrNxIxGDiTN51V2kVa/xXxslwT 4dSC4Lz8Yo96nNcyVKQeXxgkPgVdYMSJfuX9CGcZzp8boJLzf2qcrzhaL6m4dobjvKN2xC Gj/gBJINZ/AuRxXXNOCVNffg92cXVvY= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1b01d912924so65717295ad.1 for ; Wed, 07 Jun 2023 01:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686125951; x=1688717951; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vUw3pvnoCDVchEZbcmCMTv1rymUUdjuYDIrMsGD+/vI=; b=ey0J6ANpBPU0w/BzCNPygbd0EqLpxTSaoSbtOWNdKLZgVbYtVmKZ4oCL+Ihkwvx+h0 PFrgIvMcbggz9qJV/DXgN2rDn1Ai+SEOz0QmuzffLK57HjToRAuJ2CabTwEzTjtcxkMf yIsUXJe8pKuIWazuESc7Hcgor65NDlMn+Yi+k1hIftWrwrdLdhOvXULKpVXFVnX1qNt/ 4drGEqES7nevWDaLxjLUAJbyPhoZ81hIwKbvk5iv7odV3OkFs7IQOi8pTjRsD1XBbE/I 8Mj8dNQ0rrVyM2qGvrgbmfe8AbjeHmj+EFIltzlQ+uyV6t3fiuBoxtHfK6pjjQliwJN5 frIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686125951; x=1688717951; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vUw3pvnoCDVchEZbcmCMTv1rymUUdjuYDIrMsGD+/vI=; b=MFQzT6ESIJFVvWAaN2RhWZjrhcY2Esd1+o4/MqECsbNcCzTr5lozQ1YrnCB5ZIQx92 nbO3BMHAsRq9Czu/NV0nff6smajJr5E8nRy2XAsAr3wtMD5ke0IoIVtb+XSVQed1gyH9 pjAulpSVYq9OGvdCNTRXOspj9SY/o+03UTtdKUO5MN8kyoLkc6Kc2hINqBWXs3l0/LBV jOc8m56EWG/QfpekvAT7rmBlJddfbCXSzTBRVD5t3EIGX1OBicl+1KPwcQUA341a284L qoSbS6/S4nxcfVleTAPcyQuVX+2ljHsM445i6IbhyYlOC4zIAiMg6xPKnOFjI+ijA0NO hPzA== X-Gm-Message-State: AC+VfDyOo8JcJp8jlamwDXQPc4ek3mmXADpYNcjDPzi4eLYXu1Tsyy7f NAqiwltm+3i5ZBN8ueNabVU= X-Google-Smtp-Source: ACHHUZ4qmDkzQEmUezZ5ox34Ji3uK6GPUG9y+XZtEzqn6r49SY1/XX0eQs5VU+AQEYa71u+2zuFYjA== X-Received: by 2002:a17:903:32c7:b0:1b0:4c32:5d6d with SMTP id i7-20020a17090332c700b001b04c325d6dmr5788432plr.31.1686125950586; Wed, 07 Jun 2023 01:19:10 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id i16-20020a170902c95000b001b1866f7b5csm9801505pla.138.2023.06.07.01.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 01:19:09 -0700 (PDT) Date: Wed, 7 Jun 2023 01:19:08 -0700 From: Isaku Yamahata To: Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com, isaku.yamahata@gmail.com Subject: Re: [PATCH v11 06/20] x86/virt/tdx: Handle SEAMCALL running out of entropy error Message-ID: <20230607081908.GE2244082@ls.amr.corp.intel.com> References: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> X-Rspamd-Queue-Id: 4D5B6A0015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9qjcgtx47sjczb5frbp95x3sd6a8k5ur X-HE-Tag: 1686125952-625098 X-HE-Meta: U2FsdGVkX19C23AT+K6/MfBB8I4MrawQPov8BSjAUhj75mTp93nmzvPHE7T+XSx47XModoWY6rzne3G0a2XfsZfHN8lacfwXm47EaMmlCOYiCdm0M6MjM63sRi25NX3jM63Ib3ovxzrKH84cRLvRqqWPK8w/LGDSWNpq11LpRsdAfqy/bkuD79ea4Y41eJ7UWnS6rWThMbi6mxrcdv7EVqZKdzpnYZZKMHw5YQmpWWpFhrvGG008aq1b65EtdX6VFtHkwX8ebfsjUSJ70wX6hjcdl7y/h+6Eb5z9OW8jHot5fSD490zvtl1RHTm/NGw4do/PxEoa9nAuAXMGCUrqYJj7pW6zSGCCGjyg7dSJo9WXmivW/KqGM6KpjYyGX/xZDr2oEjQbkHxQ4Ae4xeErNu9KXkagqPLhTXJhzRV/pZNLvFpzTuCmxptILzsxv2iPMzrnmlQQnmPUrLdwlUHiBu5nowzPhSkknKFVcFob5CtgjcYyRAIafxLpVfUti7WpojEfQ/FgyZFuttK5eBzbxWhaljM23+ZoafeknQIm+rnA02uazHKLc9nPjfgVWN5znRB/Q56/lqvmTV4Ee8oartwUk13Nh8tjTlSERb1KVTWC3OQSXTQLTWmKPm7LC5ZEGWt0gLAx81iQVbWeKovspLH8E2ujKub7+ujIMBPE+j7HL7l9OegaSd4ml2L6w3lynV58Eivht95n8zSHwB++VbpcrREn3QP8fc8jKnm2m6OdkmR/0zeHbb/25uQ1r8rc63WUaxrMJtLzhQFX+UtYFmU1aIvAAjjT6gFeVqgR+u9rRmpyUgSIJ+aR0XrGkW6UX3UDr3ze3Uiyf/yLP/Hlxy9YEgO2njeLi3a56ekvuCHGRh24SLic+cfXuTCJ2qVTlXN9wZFF0N+rFyGcUKNhPkBCL04xR6TBoMpMk4k6q8i3luNt0YBfFUN3ru35cWStpwlojZKna0jAJFdXaJL kUO+1n71 OCKxnXdlMWBzMUDNQxJAzWgd52AmHoF5ONgMbr3MY3tPFObp3JdZNCmdVPd0DbeO43CBpLs2Z1Vk2NXnoyjhSFPSnu+VUODzWgKAzi52LGvfmvv0ptQuhXMm3zOEE4rLjPVUBANlRNx+X1G8G37fOa2VF+yNKEBj1h9uVwBhRpYtqzVv/fbm+LXjyil6UiXBURfhuRFg/icT97cC9UBcAJoBqLgBu8/vWDNyUoiRb5vFWYaOL8rYn5MTOP0FCxUk9eUFpZrBjH+h2k2zSnapu0/8zL6d82SAh5YNcEQWG+fCBByoaF4bDTVqzmnTxC7focwmUnqYKAtYWRMSriBMa7lmuPTL7rtn3mRpqrd6JZ/TP8M+AXvFYJJ9ZJwaWLYRBo/o3FFGAch4VkFwkl6AqPP2EFBsfRPBdQn9QiM4a67EZ2JUUKXkAFvwuCT75pOhRJ15IbMfs5DoTofQwNE9G8twV9+ZUK3YKlbznpkje5KJVoJeW40eY73TL+I2hwhXBT4ccF9LESd0AvXPOoseQLUq6bhSFCtRQIEKa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 05, 2023 at 02:27:19AM +1200, Kai Huang wrote: > Certain SEAMCALL leaf functions may return error due to running out of > entropy, in which case the SEAMCALL should be retried as suggested by > the TDX spec. > > Handle this case in SEAMCALL common function. Mimic the existing > rdrand_long() to retry RDRAND_RETRY_LOOPS times. > > Signed-off-by: Kai Huang > --- > > v10 -> v11: > - New patch > > --- > arch/x86/virt/vmx/tdx/tdx.c | 15 ++++++++++++++- > arch/x86/virt/vmx/tdx/tdx.h | 17 +++++++++++++++++ > 2 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c > index e82713dd5d54..e62e978eba1b 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.c > +++ b/arch/x86/virt/vmx/tdx/tdx.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include "tdx.h" > > @@ -33,12 +34,24 @@ static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9, > struct tdx_module_output *out) > { > int cpu, ret = 0; > + int retry; > u64 sret; > > /* Need a stable CPU id for printing error message */ > cpu = get_cpu(); > > - sret = __seamcall(fn, rcx, rdx, r8, r9, out); > + /* > + * Certain SEAMCALL leaf functions may return error due to > + * running out of entropy, in which case the SEAMCALL should > + * be retried. Handle this in SEAMCALL common function. > + * > + * Mimic the existing rdrand_long() to retry > + * RDRAND_RETRY_LOOPS times. > + */ > + retry = RDRAND_RETRY_LOOPS; > + do { > + sret = __seamcall(fn, rcx, rdx, r8, r9, out); > + } while (sret == TDX_RND_NO_ENTROPY && --retry); > > /* Save SEAMCALL return code if the caller wants it */ > if (seamcall_ret) > diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h > index 48ad1a1ba737..55dbb1b8c971 100644 > --- a/arch/x86/virt/vmx/tdx/tdx.h > +++ b/arch/x86/virt/vmx/tdx/tdx.h > @@ -4,6 +4,23 @@ > > #include > > +/* > + * This file contains both macros and data structures defined by the TDX > + * architecture and Linux defined software data structures and functions. > + * The two should not be mixed together for better readability. The > + * architectural definitions come first. > + */ > + > +/* > + * TDX SEAMCALL error codes > + */ > +#define TDX_RND_NO_ENTROPY 0x8000020300000000ULL > + > +/* > + * Do not put any hardware-defined TDX structure representations below > + * this comment! > + */ > + > struct tdx_module_output; > u64 __seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9, > struct tdx_module_output *out); > -- > 2.40.1 > Reviewed-by: Isaku Yamahata -- Isaku Yamahata