From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D87EC7EE29 for ; Wed, 7 Jun 2023 06:39:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AEC76B0071; Wed, 7 Jun 2023 02:39:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75EDA8E0002; Wed, 7 Jun 2023 02:39:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64DFA8E0001; Wed, 7 Jun 2023 02:39:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 51D4A6B0071 for ; Wed, 7 Jun 2023 02:39:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 218E91C6EA0 for ; Wed, 7 Jun 2023 06:39:28 +0000 (UTC) X-FDA: 80875000416.15.FCAC15B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 724461C0017 for ; Wed, 7 Jun 2023 06:39:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jezxN5vp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686119966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jUZ00b9iqUT/nckUmlcO8kjYkn9S8J8SDkfWnJtmHjk=; b=u93DZrFSNrMDzT130dsm49lZqT5ITE/fCbY4Eqwo1D5PEkwMl/aixFRm9W6bHA60qwxqj7 0rmxfHQopqhGyfykh/SImzuNal1rcJR8lLSSBp4GGz225y/9vcaKBCqJW8SbX8D9CciM7L 733nOYiwdnbHqb9IUkksbvxGiv9qKHw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jezxN5vp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686119966; a=rsa-sha256; cv=none; b=M0MISSrS2oG39XbENTokEpVnaYgZuYV68wBKS3dSyjHJJyD2JyMGZcIDIiRmFGKCR0wnxh z/J16D0lIa/Czd+9tDu9fM63qRwGiVPirAUkwvyU9vrUN88NBm/C1rzQXYeWpvwXIY8I9L Ulj1NRAsK2Joj3FzhgPpj0zdIO/bHBg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C6266333C; Wed, 7 Jun 2023 06:39:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B7ABC433D2; Wed, 7 Jun 2023 06:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686119964; bh=UISjTsiRCRSInrIvyE5FgvbQwpHYWJ7g5Pd31zSUVG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jezxN5vpNEgL7CI2kIWk6axf3PVPFkgG1cIa9UUJMUVFVal2nYT32BrYB3FgdMuG1 nVMzp3rhutYuE6ulNHctoUgD8XIbduiHHthQ9f7HGdicY0/5BKcwsmUGxkIZ05YyfR kbaQ9QoMg+IkTzKPXDcJU1MvG5JyVmiSGdgR/T2ZeYd2EgZdDmXp8w00FOl8opKf3F bNYKyGgsFcboLNW+6v+wWS6W5e45fxb6udpRtblYQrKNz5RW9ChPggk27Ghe5RCf8Q IZna0cP1/0brHZ+dHOAAs9oJGa5xVI4fHNs6SSJB2ueQSJyUvK270mz3f5q0YJ57ix HpmwPcLZWTTsA== Date: Wed, 7 Jun 2023 09:39:00 +0300 From: Mike Rapoport To: Haifeng Xu Cc: mhocko@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: drop 'nid' parameter from check_for_memory() Message-ID: <20230607063900.GD52412@kernel.org> References: <20230607032402.4679-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607032402.4679-1-haifeng.xu@shopee.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 724461C0017 X-Stat-Signature: yfgp8qzum4mp5ynxtsm5h3q9ye96qjyh X-HE-Tag: 1686119966-219425 X-HE-Meta: U2FsdGVkX1/HP0IshbhIOkTe6/EUxRMsRcE77fH8Evw051NHHkbcBOPRCDwuH+PnlOwxJnLLFQvdT8Z11GyX5Lh2APS/6DLBt8r3F6NCC6hcl0u6eAREsqpvyWdiC3Vgif+bPctY5Rece3Ak25TdeEt8nWdGQsQhvZDZPFdBy6qUeQPsF7MiD6u2EfzzX7AuK/QpebfsvzwHld2wcELGwJaKnPkRGJe7V5wxRHgB8nXXnz/VhN2Fx813B1GTd4yUCqnPBxpuAyj+ARx2tfv7TbWdxmacVF4VQ6+6Z8iGLv60Y2YaEGqbFkSRCdg7Nnq4arSEi1iFvC//WCX7EtsHKb+j8NWUsLGRQ48k+BdxYQ4hlpJcQ+5rWATazaFfqcZcIiFs53xIk+P33F1BgMITUOyrS1xhvrJ36IYnYujyaaONjYwcwsxuqxp/NQ3y+Ho476cJWBoxRMjke+eNeBGwfgHRVXo6qzd176AJ4slus2+ra3D450vOs9P18P6enFoFHaT5xqQQlYLPWGVIdXa6/xoFiFzzXasgjzJFYjl1ob0V65PvOvPIa94z8Ud43ylIp3EFQEYKzGJ+Zyd6Qn3SLXI6TGKnjH9dNNjSyQcns1KQ0mCGEHJ9u8VmeyD45zOHtfYc1NiK/WZgyFRggegThCEBcfFn1amSbfef0mM/Y59VP/O7r3D2Pk4W2CIcJFIbXWh34jUvQfIum22YFAr73ErUT25Lwz9NpG78+YrrconFSVI9eZ3rzCh4p/P8dyiBqxP1Ts9ygn8QUtXafGpLMxm/rbcJ6zK6gZAgFLMniIX+2a0TSJTAMEuz5RsK1HJ8zQ5qC3EDqHCFrKKHhpbe00L/7SBSMP3H5NBpcgkLj3AjJssTdNUlgWuyPVLK7OtCPsbtRDfTCBxCHp0TSdB/6ilmwrgGIZqNgWmHkIVxKgIMQRRSHbeptigUcPldgf149D72GFJ4EBtop592s5z sow6vx7p 6sSflkTscd9SjK+jwhV43dDYJidzQUsNBwskBbeMvqYlprsitP093Z/dSut2sKnXp1q7+YglEfUQNP5wvcRKrHtPSI2knfse8LG+Ty6iLToI5B79p2fGaz9BFGkEAb2baliU51ih7kXERnwuK/OdEXFgPommbvLPDPRceu2+X3s7cn6SoEf/Oot4lUirdOJWGfHVxfCTqQUmVUhMiAQ2U9GdOfb/m95sMEIFbFoy/qBd70klZihJwJ22g9Wn+rAK8RCFnKEV1nia6/3Gf/SrlxE4Sw+xaltcEHTqqKnD6veqzWrH1GXdTqb09yI2scrHImkmM0JP3oAn3/f85oChn3tH4b35eZ3nO08K8Xx9tCg+qVbjGBkhAW3+MWgtmV7qczz5dfEtXfbi1W8zxf4DSETD0Ds8i4Ss4Q/oGqnPePmmSHNw2+s1mwutJh2uJhZxRObGCm33Fhmai2DQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 07, 2023 at 03:24:02AM +0000, Haifeng Xu wrote: > The node_id in pgdat has already been set in free_area_init_node(), > so use it internally instead of passing a redundant parameter. > > Signed-off-by: Haifeng Xu Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index b82718d596c3..78e67041ae9f 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1725,7 +1725,7 @@ static void __init free_area_init_node(int nid) > } > > /* Any regular or high memory on that node ? */ > -static void check_for_memory(pg_data_t *pgdat, int nid) > +static void check_for_memory(pg_data_t *pgdat) > { > enum zone_type zone_type; > > @@ -1733,9 +1733,9 @@ static void check_for_memory(pg_data_t *pgdat, int nid) > struct zone *zone = &pgdat->node_zones[zone_type]; > if (populated_zone(zone)) { > if (IS_ENABLED(CONFIG_HIGHMEM)) > - node_set_state(nid, N_HIGH_MEMORY); > + node_set_state(pgdat->node_id, N_HIGH_MEMORY); > if (zone_type <= ZONE_NORMAL) > - node_set_state(nid, N_NORMAL_MEMORY); > + node_set_state(pgdat->node_id, N_NORMAL_MEMORY); > break; > } > } > @@ -1887,7 +1887,7 @@ void __init free_area_init(unsigned long *max_zone_pfn) > /* Any memory on that node */ > if (pgdat->node_present_pages) > node_set_state(nid, N_MEMORY); > - check_for_memory(pgdat, nid); > + check_for_memory(pgdat); > } > > memmap_init(); > -- > 2.25.1 > -- Sincerely yours, Mike.