From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A795BC7EE2F for ; Wed, 7 Jun 2023 02:46:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E73E6B0071; Tue, 6 Jun 2023 22:46:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 397226B0072; Tue, 6 Jun 2023 22:46:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285958E0001; Tue, 6 Jun 2023 22:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B26A6B0071 for ; Tue, 6 Jun 2023 22:46:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF9931403A6 for ; Wed, 7 Jun 2023 02:46:04 +0000 (UTC) X-FDA: 80874412248.19.50CC9AA Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf07.hostedemail.com (Postfix) with ESMTP id 1E89740019 for ; Wed, 7 Jun 2023 02:46:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=HMoDpGxw; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf07.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686105962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Y4cpQu1sdYA6+2nMRyH32rTc0BdepZfuCueHh8wgQ4=; b=ZnLzdS5YmKQz5z6LWhsSa+uLdcNBfJ+aK1ILDLy1dXFTVbF0XbTwOB06l3/sev3EqSdSXd McFmnTe0maXOsFG1yficD2Ya76V8wF8Yof+gRqNqRYK1TILKj12HkKviAo8+RxjBza4AKa owDiFPE6smgoi1Z59KLet/ywjUfxSZg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=HMoDpGxw; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf07.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686105962; a=rsa-sha256; cv=none; b=2XNiaWnfF3i1N1b4PiudPSwB5XQXC/y1HVvQNHCAG8lttKOR1j+PfQaEcEbujyiQ1VwVGT UOv/MjoWX2M7Pdv3CD7U35r0GNxMIQmKyJc2nr4YmckGIYbNQJaTG6dtfSOEtOdTGaPj6W RJ4BpzQfsKXYmfM+BVeA1JGJD1XZIlM= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-bacfb7acdb7so8269547276.0 for ; Tue, 06 Jun 2023 19:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1686105961; x=1688697961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Y4cpQu1sdYA6+2nMRyH32rTc0BdepZfuCueHh8wgQ4=; b=HMoDpGxwfm87j/JEZXDRmv8x4x6KJh3hyX7ilOvqVJ6AfoAy62VEps/FuPtBsHKt8W 22opKIRkZyYSrWJSKXnqP4327VC02fGAaVCifGAbR1PyecXRmeuamMLje03HuElZXvKz WdjrWXHC1g3ddYePoXSJC2emmxFXOD+8Gvzu5kABh4BnsW/YxvzkZgb8rU8XVy/aJX0a lbAsG/BdRxNJLoKxr4sODzLTqxpaRjBrFDNKk9A0T9pJkdOPoHto/GZj8hQ+shSVWXfP ErUrk9txBu+8Kv/B4fyl156GlVGw3a9Kte+WdTpstYTvP16ZSVE3FlXnlAA4XLQaZwv3 oeIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686105961; x=1688697961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Y4cpQu1sdYA6+2nMRyH32rTc0BdepZfuCueHh8wgQ4=; b=Ojp+OfxPiEkNkVYibPwAaqFZIrxHJFpB4YdrpRtK8RVmwSnEp/OtkgbCCoZJ20BUd9 zWfpPKJkkxh1HH2Y1pDytxsWqm+6Iw2bmge5MFh3ndfupG2sKXmZGVWa5k+8/h0vHDaw BdVFeTGF9dO89Bsf7l1Z0wWE+6Aokd8cqmfC0EpGLDCMIOKsCkR+7DxPr1BszZA/kt7S 6FGi48umytyA5dADex07vefX8H9GEsh1TnH9xvVxKZp7frwlO+ixfUirJyF9UR3NY0q0 a6ruU4wc2SxLlp06KqUN6tDwgKFlJsR6QbV6Eou4MK+CgHC0vmQF3e3Wewd1UZtyY/qk gxxA== X-Gm-Message-State: AC+VfDzmELiFFhM2XEI7Y4gRUw5S0TgDwXFuKAtJkIWiJ8xAo+AgOf28 /sadsVRqM2Co3NhFa7vHEBmsyg== X-Google-Smtp-Source: ACHHUZ4dxus19P+lyr4IEn4CBH2WtiWiSxvheWcDTyK4wXOCaDNWuqPT3y483yKgCqbU9DznKrv//w== X-Received: by 2002:a81:770b:0:b0:568:be91:c2b1 with SMTP id s11-20020a81770b000000b00568be91c2b1mr5223033ywc.9.1686105961046; Tue, 06 Jun 2023 19:46:01 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id g26-20020aa7819a000000b0063b898b3502sm7386477pfi.153.2023.06.06.19.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 19:46:00 -0700 (PDT) From: Haifeng Xu To: david@redhat.com Cc: rppt@kernel.org, mhocko@kernel.org, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH v2 1/2] mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init_pgdat() Date: Wed, 7 Jun 2023 02:45:48 +0000 Message-Id: <20230607024548.1240-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1E89740019 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6iipw7meydh5zqck5hei8ds5ogditsnd X-HE-Tag: 1686105961-427683 X-HE-Meta: U2FsdGVkX18hC5KuX7Kuo9JFfm732fXChaD87gmfv9WrfimprlobqotgLI9PnPQi587D3QZHdUA7BjdCjQTQlyzYTgVifJrNAADha3aXwweyVIJTiR9vO3LpvIE/ZdHzpSfSc1qhqmMP70xPn73oqbz3JkW0XKqXUdYu3r8QAcC8BwzAxWLo5OCoP0ovURcT07Yxw6Z/6FolLvGeqGez5s8gfGXQ2rpIB/+PxHh291V7ve/HzwnYVWDfhhMeeqdMcCEyGGqU6A1D/fPlSZM1fS4xk1T42qNDiNCXndYq88GsvH+sd5gjnJ2xDpKHZ8HKLqxPobymt6QVgY501pfBA/rC81TW/gomLJNxJE+ZNWX/GZ5WlBI4O64dV2azSK2RCP9Dph5vatRkLv/RagFBPgG1A5HCLbbKLnQTZgbnzKJFzlIoUxRMa0sRNve5Nrp6a9lJHCkoj2HwYWDmm6NPsAAcL8T76I2df1GZcD/i7VAdrPwmxpTYXh4203pGNFcfo4DyvAAeEHuZ1+VOM7VC9iZOGVbhIBRbadqj5wZMvTKokOuRfOIUvFFRWc/ffE/xEfLnu49UN5X42fUrWkBFsGGkpZeqdPsTaV0fTi83iAV18pQ1uxoXthzDihiRTgwzlYzhvrH16jHUt8N/jNtrrUSq5JPIFq/NbmkEdwwEPMvBSaUnsmbyUO387IdFIlOOI5xxx6onndRKqDii5vJkjwGDsmJxLG7H7EJJWOgpHBojKkiW0/ZOiwli2fHZV6zSFnJO/WcK1eNtEOMdwTTGJBY1MtAMqBRBTOfiNS0oklPoBmxVljSMWokkVRyqtRwRI6gkEt79BuLAj8qQbu4tk5O7DmyR+soSj0Ju74DLh6/xsx9QUCRzp3b14hvIrDaAmffsJQ+raV2E+VcH9RSXJjtZm+GqBmZmzVJM9YtP2uth+ISiQBczZLH2on41xw/NVEg0U9L4mAJFPdxfg4L eeu2Uh37 4xOJ483AT1XmADpyStjmqTFP8ult5xchv7E3XNTckaAgYuWCxtNJfcv6PBNtNDcNvnPSmzJpPWtSe1zYmSkhfLEK/jhpaIhZzr25xSrqcjowEXnZpSDuGA7l0st+xORbV6X+D5Oe9TE4lydqUVLFo2toQ6np/r1zrvcq5iJ4lZvLZDras1vLW/mhyCoiYlAVPctWUp//ol0YU2WMuQS35bmKfX25g85js7B7ksKEvV3K4GNYcfaWWsFr3zFsPTaAvkAaxjuXPOLDP9vTNB86FAGW2Pf72OXeVBnp976O/VgLP2IUHOVVTOGXnRY5Uz4omRftLamRec03gsxvORL343VP0aGvvuBJBbdAEQSwM1QRCwNdry6XM2C/VG80OHcnKPhOEl5RRH7JeUSvNP/75V4DDCRv9GHuVQ4LrjVkMe9btYTPwK+gsw7JliuAPB9VHrlEGjfzK4ZDvBQPJLbAjh8IIsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: managed pages has already been set to 0 in free_area_init_core_hotplug(), via zone_init_internals() on each zone. It's pointless to reset again. Furthermore, reset_node_managed_pages() no longer needs to be exposed outside of mm/memblock.c. Remove declaration in include/linux/memblock.h and define it as static. In addtion to this, the only caller of reset_node_managed_pages() is reset_all_zones_managed_pages(), which is annotated with __init, so it should be safe to also mark reset_node_managed_pages() as __init. Signed-off-by: Haifeng Xu Suggested-by: David Hildenbrand --- v2: - unexport reset_node_managed_pages() - mark reset_node_managed_pages() as __init - update commit message --- include/linux/memblock.h | 1 - mm/memblock.c | 2 +- mm/memory_hotplug.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/memblock.h b/include/linux/memblock.h index f82ee3fac1cd..f71ff9f0ec81 100644 --- a/include/linux/memblock.h +++ b/include/linux/memblock.h @@ -128,7 +128,6 @@ int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); void memblock_free_all(void); void memblock_free(void *ptr, size_t size); -void reset_node_managed_pages(pg_data_t *pgdat); void reset_all_zones_managed_pages(void); /* Low level functions */ diff --git a/mm/memblock.c b/mm/memblock.c index 3feafea06ab2..da4264528e1e 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2122,7 +2122,7 @@ static unsigned long __init free_low_memory_core_early(void) static int reset_managed_pages_done __initdata; -void reset_node_managed_pages(pg_data_t *pgdat) +static void __init reset_node_managed_pages(pg_data_t *pgdat) { struct zone *z; diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 8e0fa209d533..65e385f34679 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1210,7 +1210,6 @@ static pg_data_t __ref *hotadd_init_pgdat(int nid) * online_pages() and offline_pages(). * TODO: should be in free_area_init_core_hotplug? */ - reset_node_managed_pages(pgdat); reset_node_present_pages(pgdat); return pgdat; -- 2.25.1