From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2625C77B7A for ; Wed, 7 Jun 2023 02:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E49F48E0001; Tue, 6 Jun 2023 22:43:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF90A6B0072; Tue, 6 Jun 2023 22:43:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0A78E0001; Tue, 6 Jun 2023 22:43:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BCF5A6B0071 for ; Tue, 6 Jun 2023 22:43:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8547A80821 for ; Wed, 7 Jun 2023 02:43:00 +0000 (UTC) X-FDA: 80874404520.30.E67E3DE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id CA9A818000B for ; Wed, 7 Jun 2023 02:42:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ubl2ySok; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686105777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b3YDhZpXD5Hb62ohai9Dsz5kBy0FpIuqNyFqn1Q97LM=; b=mDYsOIFQAYG7rriVcLomzyx3m7SGIdRs1ILBs2VvLu4OV2AOFKseM7P7RrKAvOA+a4XY/g MfodyW1hoNJhUolh1MMn0IxwuRRYmTJ1x9XVF8Vot9Vy9PGdBoF2D1556VVvXXaqiSmPPq kVJLmhHRQb805rCiLUMqt5TNLfsUNsU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ubl2ySok; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686105777; a=rsa-sha256; cv=none; b=c9gn+oZL5k+3Hv2zYfscjNt/DMoZo/ivdEWMKpRqmvt2hII9CJWC93itsoWhWLn7+2Ckww wk57cIiw7agN6D1zr33esCZ57W/neuyrGM7Pu9cj/a+KffWWpNdaxVwL+Bmy5YFMDE8/o2 1YzXZwypp0f9H8vuEaQvMcaMblRQ9Cg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7A4662FB7; Wed, 7 Jun 2023 02:42:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB98BC433EF; Wed, 7 Jun 2023 02:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1686105776; bh=HPX7TTyNLy9QYOmc7IjiU6+RwLEOPn30MEW3zhLSVew=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ubl2ySokBAZpXZwrtyG/EsPwhz9RPRnQArXZM1uSLVtRQErDCIvCbrOlqlQwiZJuP pvnpnlZM8Fymg8yhxYliosgbG7NmiKRNuWadMn+zpFbJJsQ6OsLL+4wc8Mu5PpiXv0 oOm9Q5g9thm7ySWqbMML8TYWZ0QyZSIF2UjCxWlM= Date: Tue, 6 Jun 2023 19:42:54 -0700 From: Andrew Morton To: David Hildenbrand Cc: John Hubbard , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan , Lorenzo Stoakes , Jens Axboe , Peter Xu , Jason Gunthorpe , Jan Kara Subject: Re: [PATCH v1 2/3] selftests/mm: gup_longterm: new functional test for FOLL_LONGTERM Message-Id: <20230606194254.5e26642b28dfbd0e198d24e8@linux-foundation.org> In-Reply-To: References: <20230519102723.185721-1-david@redhat.com> <20230519102723.185721-3-david@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CA9A818000B X-Stat-Signature: f5d6dy63dpem68wai63b8gpezbqcab4m X-HE-Tag: 1686105777-652705 X-HE-Meta: U2FsdGVkX18QPWQvt4pmM+cMqpCFrvaxceiKSTf+w8jxfHXrSjunzU8jND9Ie2QpfUn+OLqC6IJ+XI32uLqiurFqO2S0Sfezs9FYibXzhzeuKJqJbtBTyJzRRhPmu4xqGypqi99IwQe2oWoVhl2KuEM17QPlYlJ85gZeHzXBWASP6fy6C/GYFO3ynQ17b3+Zn9LGiDrFHoFCNXZW8V0ZHYhFIXi5CIthE04Uwa5UVUKhdqXCjORqc/kJPjKD7xLiEBWu26R9RVndV6OQtBNRwgEtm7Wt2+Y4+40XXPTiHY/JLYMDriJBcIf7XON9IXM+TdvEUGDjuuF/8fBtlUJZX09tIb+Huusyj8QolpVJUhoxBshDAup7hlfq7n8eBMv8t2zPaPQhhPsVOeiwtdPx1PcWkLV919T/NxeKF4iicAZPXg/Rcr0qH27vAEr4vu0tb2iQZloXAgp02DM/lhAIraEfh/qOqMooxGmFn+SKlC20Zr832mBcGF5yHOZ0mbh+zjW+VmIB8usnzsNvmUGYDjhMBauHOogX1ld2jEATmwvAx1lZJNXC6RJgoFa2GAhRouhtzt1rBntWy2PjB9ImgfvAa/r5N9ZEhEn6Ae10yYktB+/mEprCmF7rieAM5j+sPP+J4f3hxe6+u1S78BUXCtHKZaZvReCSUfyxxmLRgO1TUSxfOvvfN2XDA2cbMdSA/E7q2OrJZfIFuZ8FoFrvKt8o7v6vFE4i1zB3+qWgfJ44/2HkMt3hKKF27ReLRjsaPhqZJFcYcxdw9Pw3cqtuvNwbik50Yap7i6pd2GCuSt+G97qRMmOtrUmNou2fybImplSQ/iTBZ3eRittI+QkLEjh+tumI7/Z6tow+BYHwNrCcJGGsyM/haI+tjQOnIbg6mpFRkVcFM3ytADdwQ31Amn0s+yiGJfSK0IpzghELq753KSyFR3VMso/rYea8CtpZNs8yqMje4saSBGiNS1R a+45J2Cb VhHmC46ExvzPmwD/dxVg9K+3Xxpi2VGuOFTQvqTdmaTrTo/GVlzDdtPQoPux+8I2Jdp60+iBF0AOX7VOsGMQ3BpL01CteUIc5vblHgeeoW5uOQJivN/CN8V7UBLbUG4U/e7h68r/xpzgyfQ98nIrDHz5Khv8ar3ZFVi88Bo5N1DfY3o4G75Xn4Q7TOatfUktZeJfG57qIp/Lflp8eE9ommYfypUtQZmNM0Xn1YMHkzOey9dwl2tGHVL4ox3isp4/0fvrYbOewBWTOHISHEs5MRO3SiQl8lQ/Vo3uNON0g/PkohbZuP5Bjsmnv46xpWAlxsZnOa2Nu9YOpFtvkLRIXRcBHnbaYO2vipRtS4/vySxbYgPd9/9GhkVKXvIZ6kMRmDpGHMnPgFWzS2vxx0Un9BujcA3LrbxDyp5NjnZUXkawZasDKKC1PB0wEZYVJQBmsXsu+PW1hevikNdJruAIxr05UjpzKcx/lR76s+hkvqNVgKFhQdXNfEPPflL3jU+tzxSs7zF1iQXGXrI3i/D1Weo0V6RSp0EBdsDW2LS8M+b7i3IdaiL0hf0ljhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 6 Jun 2023 09:10:22 +0200 David Hildenbrand wrote: > On 06.06.23 08:23, John Hubbard wrote: > > On 5/19/23 03:27, David Hildenbrand wrote: > > ... > >> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > >> index 23af4633f0f4..95acb099315e 100644 > >> --- a/tools/testing/selftests/mm/Makefile > >> +++ b/tools/testing/selftests/mm/Makefile > >> @@ -34,6 +34,7 @@ LDLIBS = -lrt -lpthread > >> > >> TEST_GEN_PROGS = cow > >> TEST_GEN_PROGS += compaction_test > >> +TEST_GEN_PROGS += gup_longterm > > > > Hi David, > > > > Peter Xu just pointed out that we need a .gitignore entry for > > gup_longterm [1]. That logically belongs in this patch, I think. > > Yes, although I don't care if it's in a follow-up patch (we're talking > testcases after all). > > @Andrew can you include that hunk in that patch or do you want a resend? I added this: From: Andrew Morton Subject: selftests-mm-gup_longterm-new-functional-test-for-foll_longterm-fix Date: Tue Jun 6 07:41:28 PM PDT 2023 update .gitignore for gup_longterm, per Peter Cc: David Hildenbrand Cc: Jan Kara Cc: Jason Gunthorpe Cc: Jens Axboe Cc: John Hubbard Cc: Lorenzo Stoakes Cc: Peter Xu Cc: Shuah Khan Signed-off-by: Andrew Morton --- tools/testing/selftests/mm/.gitignore | 1 + 1 file changed, 1 insertion(+) --- a/tools/testing/selftests/mm/.gitignore~selftests-mm-gup_longterm-new-functional-test-for-foll_longterm-fix +++ a/tools/testing/selftests/mm/.gitignore @@ -39,3 +39,4 @@ local_config.h local_config.mk ksm_functional_tests mdwe_test +gup_longterm _