From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32216C7EE23 for ; Wed, 31 May 2023 16:27:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F2F8E0002; Wed, 31 May 2023 12:27:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EF6E8E0001; Wed, 31 May 2023 12:27:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B71B8E0002; Wed, 31 May 2023 12:27:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 49B628E0001 for ; Wed, 31 May 2023 12:27:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0C1F2AE1F4 for ; Wed, 31 May 2023 16:27:21 +0000 (UTC) X-FDA: 80851080282.03.AC84547 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf02.hostedemail.com (Postfix) with ESMTP id 3DE9180014 for ; Wed, 31 May 2023 16:27:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="nUUz/rxR"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf02.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685550438; a=rsa-sha256; cv=none; b=aAjzJOAl32EsHmO4qTEHZFPj22HrZfcBJUwAtjuhzVTMiDEh5TScnzUhQD7TMUtGgzoztf 5dOycPAKP1LLbDuI6ObsC2AkoVVikwsbbgVUrfHpxaRwQjp/CWfMNW3FnpObZA0ynqnj+7 fMuRbfB0FHyJU4/9U126tn4+51c3brQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="nUUz/rxR"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf02.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685550438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aeCrhh32K7Ng3rxN/A0sTmbfxrCR/KPR+Nm/ryxEtJ4=; b=U7ffScdoel8+sc/lD4FDitOVhXYti0fFjJi7BffE6P3LDse7bZcDeUytjl+s97rDm+o/EV xOqoRwDkQw0/9ZzQA2+Jf/j4l/fAR1P42Qpnbha6SDVcmQisGKzoK1GWXHQr7dBz5yq3I8 wz/BIYOOgGcpjETg/mxzx29sca9mziI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685550438; x=1717086438; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=751fKcMvplG6/KmjKYOTWk7+Q9GXlyI46BmhatKMpyg=; b=nUUz/rxRqSIm/uR7rJnQVUIoDYFul5JvN96p8Pkx1eySX3ezu/+wbUpx yRqR3ZQ0m5DGvWNfSXOvgfsZDaNrvjphl2P6pxcMpFlaMT/d7emZRuLKu /k/4a817k7VWJZ1Ss3ZmVg7IdNPc8xILM4o/XN82wsiwM+9c+MIqqBwQz cj7DsLL6ZsqX0vg/aUU9HXNpPGnQ+la5gWRcDc+6xcYSWCmJPrKwdMYjd JpP/60neZP9OSnAcVLFNS0OaLVVw0DRYU3++6twHJFpHm5crOL8leTfuZ Ogb/S+rgn/2NdAv+OlD/Gv3fH9dCIg/3h4IVsDtbmKYKI+KckDY2CcUbu w==; X-IronPort-AV: E=McAfee;i="6600,9927,10727"; a="344807303" X-IronPort-AV: E=Sophos;i="6.00,207,1681196400"; d="scan'208";a="344807303" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2023 09:27:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10727"; a="740029619" X-IronPort-AV: E=Sophos;i="6.00,207,1681196400"; d="scan'208";a="740029619" Received: from zukmacix-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.46.53]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2023 09:27:05 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id 4A56410B45A; Wed, 31 May 2023 19:27:02 +0300 (+03) Date: Wed, 31 May 2023 19:27:02 +0300 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCHv12 1/9] mm: Add support for unaccepted memory Message-ID: <20230531162702.zfzex7vkhn3uqgvb@box.shutemov.name> References: <20230518231434.26080-1-kirill.shutemov@linux.intel.com> <20230518231434.26080-2-kirill.shutemov@linux.intel.com> <20230531155159.GIZHdtH20Q0FsmN3OR@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531155159.GIZHdtH20Q0FsmN3OR@fat_crate.local> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3DE9180014 X-Stat-Signature: b4aeph66bcd4sxmi1zouzsawr1gh3kuw X-HE-Tag: 1685550437-623615 X-HE-Meta: U2FsdGVkX1/1quvCb6o25zp0OFSgxWR5X8GRrhliL66cLNwCCoiuhB1q8u6f7tRwCLrjS06t0rQSQDqYMBXGQsJ2wFOpWc/lLg2cu0ZwIw5d9DpcZj50pGXS1DptukOM+rWhTiQRAVMDXRJW0cr3MJsBPHtaviDxN1CuYXZgRz0CgaOddDp7yW0Eh90unYPrSodgzKbLRX9tcN+LSpr2D5/u5IyqLyTkDk1UJpViUwrXauRlJxmkYxRoMPyDNLti5EM8pTgwimuC0jByrKzmGddELr651KjRBNrKuVj7G2DyvDmrUuBYj+ynKQ/+Kp6pWyGyB5fjB+wW/cECUNmpKe3VfGffJ6fqkQztUvdzbV7q8ka3TsgetkQd8a4FJNgzy6mRP7iG9004AC24mZH4ecJDcHYGLUbasDjapQWS/F9lgaZM1jS5NSmtJtrXXu3YdthgtbL7etoEiVcEfRfvqmShAnv9tQAQlV8dn7dCi/DnlfwyxNByWqRc6+NRQO4b9pGGvIclxS7RTUyr3dtqjaTR74r2irlYVnLmNiCGG2y/mWUIZwUtTapEj08prSz/IJqWfRqbNav5SCiqy9rCkdyYm7dfmcMYmBXbXo778tfAFSWPRvLhI+0Hm8vX27scd+/Vp23Lx57RmhrnMg4FSUWpJWVF2LJwpE3I0M+Z3ld6p3uzm+X1YDy5CCyOxRN2gD1J+HJFGbObu9lyhwr1FzC2fiZKOwSkZg6zClvs00usWIzN7RNk7MKi5o/H1CXtKciZim2jzf2gEg6gbh0JRVnYysysk//uthlybB/f4MOAcNIrUUE042o6RPGi1s4bZCR7qv2MBVnyeqARGm/xqBiMwQYPnC1Xkyp2IIti31xKu7txfAz4EXOy3yJOyMGnrZlaurnGy31I3g6r9Za1UOC5idIn2jaLN6XaoupY6g9inXtyDfwcpF1VY/XzTElt8bDBc/oI36UlHGVbAeC amqnUfj0 MIvJysa5vWOEAxe5bWTE0TsLV0Kpd1kB4UzKjybdY2eKYOPai6mtsUd1ypbnldhhrrJjjtKMDrFTKf4SrLbh09AjcfuDKhAlL1L5IFAWrMW6nUdY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 31, 2023 at 05:51:59PM +0200, Borislav Petkov wrote: > On Fri, May 19, 2023 at 02:14:26AM +0300, Kirill A. Shutemov wrote: > > The patch implements #1 and #2 for now. #2 is the default. Some > > s/This patch implements/Implement/ > > > workloads may want to use #1 with accept_memory=eager in kernel > > command line. #3 can be implemented later based on user's demands. > > All this remaining text should not talk about what is being done > - that's in the diff - but why. Drop the "what" pls. Does it look okay? Implement #1 and #2 for now. #2 is the default. Some workloads may want to use #1 with accept_memory=eager in kernel command line. #3 can be implemented later based on user's demands. Support of unaccepted memory requires a few changes in core-mm code: - memblock accepts memory on allocation. It serves early boot memory allocations and doesn't limit them to pre-accepted pool of memory. - page allocator accepts memory on the first allocation of the page. When kernel runs out of accepted memory, it accepts memory until the high watermark is reached. It helps to minimize fragmentation. EFI code will provide two helpers if the platform supports unaccepted memory: - accept_memory() makes a range of physical addresses accepted. - range_contains_unaccepted_memory() checks anything within the range of physical addresses requires acceptance. -- Kiryl Shutsemau / Kirill A. Shutemov