From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EB6C77B7A for ; Wed, 31 May 2023 15:52:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6BBB8E0002; Wed, 31 May 2023 11:52:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF63C8E0001; Wed, 31 May 2023 11:52:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 996A28E0002; Wed, 31 May 2023 11:52:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 84C378E0001 for ; Wed, 31 May 2023 11:52:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 29FA9C0276 for ; Wed, 31 May 2023 15:52:11 +0000 (UTC) X-FDA: 80850991662.04.57F843D Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf22.hostedemail.com (Postfix) with ESMTP id E3680C001E for ; Wed, 31 May 2023 15:52:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none ("invalid DKIM record") header.d=alien8.de header.s=dkim header.b=hTxgDwfu; spf=pass (imf22.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685548329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PjJvC25aHbGALiU6YVgnG9fmUYnvsHAivYjN1VpUWL8=; b=2sxbZsdEtb1pL3/KfNCQbZqCj+hgqKRt+0mlhNMIhckSXdx8BP9IwyyHw+FMfgCbH+9FhQ 82D0Nb15rlMPWAxLBJvEZDN4Dxhhom+dqTSjkRMhqwslQarSoqfgO/DTrjrRH6nn0yD08z xjPVSay1FPyYfj+waAnxw3lIzaPnqpY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685548329; a=rsa-sha256; cv=none; b=PJXdtQOW5n+C8ONrMqAjX6npZP7g4h09Y+ZJ2L30d1b+L7JIXFVGhMMCKt+bJrWavSER5o 6gaSi3ty0pJpewrd7UOQ+sVrYeWtdQUTNY6twgWoDUUPWnHXNZn1BFly+v4O7lub3QnqFe qeNhiinhodttYuLMT/8SwH4uw20VWxg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none ("invalid DKIM record") header.d=alien8.de header.s=dkim header.b=hTxgDwfu; spf=pass (imf22.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from zn.tnic (pd9530d32.dip0.t-ipconnect.de [217.83.13.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9C3121EC042D; Wed, 31 May 2023 17:52:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1685548326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PjJvC25aHbGALiU6YVgnG9fmUYnvsHAivYjN1VpUWL8=; b=hTxgDwfuCwzRv4XyrSuZ1Qa/JoBjVnYer95z1d/ZhV90LaqH0lo9D/xw19UMf4qna+zqJN PLvs3Zyviep3I4zsBKo5jRh/OzsXXIobNdM1eoy13WyxhPFbpuCfTfMj9xCgpxQJMzYNj2 PFcu9weh1qnAloA4dGUNGjjHbMOIB2E= Date: Wed, 31 May 2023 17:51:59 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCHv12 1/9] mm: Add support for unaccepted memory Message-ID: <20230531155159.GIZHdtH20Q0FsmN3OR@fat_crate.local> References: <20230518231434.26080-1-kirill.shutemov@linux.intel.com> <20230518231434.26080-2-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230518231434.26080-2-kirill.shutemov@linux.intel.com> X-Rspamd-Queue-Id: E3680C001E X-Rspam-User: X-Stat-Signature: fkfhec38ogb1mud6so16iematm1iqf6d X-Rspamd-Server: rspam03 X-HE-Tag: 1685548328-822616 X-HE-Meta: U2FsdGVkX19Gwrv5w100kEw8CoXouWBjpp9FxUJ3D0go0O4fI7Yu52vTROKIrtL6Vg1o/5T3vGvVhnvnTjCG4GEGAtuJ6ZLywx266VzrsACwzGwKlTlHvxeuK3x4bbeiTkI2dT98k2fUSWhQ0pSXwoVF6tD3wPRPLM2qUf0lVslEYPg/mjtKod7rNYnHnhR6Wzl3Qjy7Atw8pHMB8ZbQ29X/WiC0ZV9pAXigXzEKA1hJGR44aj8NvIs5fC03lmmrNEUVtsF5j0Od2qLWZ+2kIuSAASWmtmoBDPpex7J3pyilpCkfiT/yrpb0z4MP3P9OFD4Za/BLZ6oCDucaan3W/XQTjI1Ink69chYHlGp64OHKqCU+TCX3qNID9P16Q4prF38jszmd8tIL6RScMfcjtm44ohySsPK18Yk7MTcLmQVAjhxrCTkLFBS6CF5ydk7fY8zYFM7dgUncdpSLctctC8eYoVLPlKHvoEEO90jVb1Qkfzh79EXJAFWWG6L03JdsiXiqKD2v/z4YyW4G5dvCiMSt71LuZLDMOtF92HaEiwVlfoS4wWragje95ljiyx/w6h3NSKbcWdJ2gX9wE8BelWVGeYFiq/ZLx/VCbVMaHLwtB5E3Kr9lI3ZRFkAuaTxjiRUtYdTIR9XHm+G5bEiLtPT2YXJ0+z50QKHu9N7ec+pWuE5empA7s/emmbC6aQ/9YJICMwz6qvJYbQqnsD7LEI/EPAjbBa6J2qOpVe4945rz2UymOrdd1O8LQF+bhFA+zkPEjQKDkt/2XQs4Eh7hA/Xm4UgmjqjF9YAs3BDnLIi0qcgsCSNnKLikvvISI250elWX2ll9x8IvIIfAQXkZM6lr8HZv63z9HcESr+ENATb/JpeMGGTPHORqcOBxY3Adbj34ZT/kf5kAu91xetq5gGo6HHJRx4VTJWUiPDnAUwTBNFesvvxUrNbaReHa1xikGZ4KtDogL/IhTFXiqnO WKT6EtC9 2eZnekhTj7VJi6r5shw+uRjn6Ca/uLrZiAGujCbSLqXV7ruqk0asjNraL7VQKg4rjE84qa9yuob7/+jATKe6eTPgcMs57bOhxGFy6uWlf86oQQlCTpo2GpxKpopqkZKx3eIwL7xPOSK3aidhhusyDs+9AzPk61qEwZ7mCUMhfcdYlZyoxNeW6KC1tg1cnfZkrIaBTgX8H/oENfrSDgSDFWpeaIQnVHZp1UIBzgMAecBW+IdeSX4eGXn2C2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 02:14:26AM +0300, Kirill A. Shutemov wrote: > The patch implements #1 and #2 for now. #2 is the default. Some s/This patch implements/Implement/ > workloads may want to use #1 with accept_memory=eager in kernel > command line. #3 can be implemented later based on user's demands. All this remaining text should not talk about what is being done - that's in the diff - but why. Drop the "what" pls. > Support of unaccepted memory requires a few changes in core-mm code: > > - memblock has to accept memory on allocation; > > - page allocator has to accept memory on the first allocation of the > page; > > Memblock change is trivial. > > The page allocator is modified to accept pages. New memory gets accepted > before putting pages on free lists. It is done lazily: only accept new > pages when we run out of already accepted memory. The memory gets > accepted until the high watermark is reached. > > EFI code will provide two helpers if the platform supports unaccepted > memory: > > - accept_memory() makes a range of physical addresses accepted. > > - range_contains_unaccepted_memory() checks anything within the range > of physical addresses requires acceptance. > > Signed-off-by: Kirill A. Shutemov > Acked-by: Mike Rapoport # memblock > Reviewed-by: Vlastimil Babka > --- > drivers/base/node.c | 7 ++ > fs/proc/meminfo.c | 5 ++ > include/linux/mm.h | 19 +++++ > include/linux/mmzone.h | 8 ++ > mm/memblock.c | 9 +++ > mm/mm_init.c | 7 ++ > mm/page_alloc.c | 173 +++++++++++++++++++++++++++++++++++++++++ > mm/vmstat.c | 3 + > 8 files changed, 231 insertions(+) Diff itself looks ok. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette