From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7225C77B7C for ; Wed, 31 May 2023 11:39:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EF528E0005; Wed, 31 May 2023 07:39:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 451928E0003; Wed, 31 May 2023 07:39:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2053F8E0005; Wed, 31 May 2023 07:39:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 094508E0003 for ; Wed, 31 May 2023 07:39:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE32A160390 for ; Wed, 31 May 2023 11:39:04 +0000 (UTC) X-FDA: 80850353808.14.915A1AE Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by imf03.hostedemail.com (Postfix) with ESMTP id CA7222001F for ; Wed, 31 May 2023 11:39:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=KR1Cof9k; spf=pass (imf03.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533143; a=rsa-sha256; cv=none; b=67CPS0wJgpokKATps5TGxNc+iQ53Nrp+saeSpUrCDMsmq8omX+YfeKi3WJVwAxsgF2puzu LSOmJ+LKH5b0Xtz9kvwoIK9/sM22FfYHAZWmSm8vRMnVN1ORMQR+dhBTLOeewRGk+Q0m10 3uQk1GfrERgeY+BLetCTsWDoTgn3a7c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=KR1Cof9k; spf=pass (imf03.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com"; dmarc=pass (policy=quarantine) header.from=wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qfskpwS0Ujqesmx9nawoFccYGFRFHr2duV/SZprdJTg=; b=qsTJ3rQ8K6s6D2wRA+nOCsp62V+ruJMwcoiUeol2mD17CnnXWc6N3aOqxYXSs37FUvHSOE VSjCYfUEP7rEI6RPhbA80qhZtN3MHaulDc1lMKsiHJu2fY4Tgk5/MMSA2PsKEMq2wVNajM UyzsEl9R4Up8SWzFlyeMN//tV67QCRs= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533142; x=1717069142; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8KwDx4F6OBY0YkNe6TbB7WM/40haMFuwXNEas5IG6CQ=; b=KR1Cof9kfSLAQH6QWvxfdFWHtrPloeG2fRY5dOzt41llA+M9M3cmXjrI c+WZchvO7ZageyegSU7+gPWXEQa2wy7Tuno2xLjXht0HxZpzUpm/hIVy4 NKcBI1ZVx0DyGtBAZr3cveiFgRQ0r7SAvGymR2BjQIhyjJXx04042W0J+ I3CwHFCTukVh7aP2Q1N/GFnbmYYmvk6vc6U4/ltYesZPe9sSEdnxMEnD5 u5ZJQELXpwUAYAa8/tQqFRO7VFN5tLoWlTTXFe8/77j/a2uo9//5qYbcw 5hFpGM05hhUh5+oYYq34YgTAZdpDLEWABtodT9o4QBO9l1pG/BmsOCe2U w==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="336547333" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:59 +0800 IronPort-SDR: JTYPrkc7rJ7jWMoxDkHI90GALwdDX3Y8y7O0+Q7Aeia9huvgdzSzHClXQxdleCB7kG3k+v1tPm e7R72XI4zismYtKRk+PSmMvJXxv5grXXUiwZ2UBYHSe4CoGndUMYtBX/ok9R37d7VfQlvayrbW pCiV3HVam0cwe6nw9dwR3vuVXQnFBSXigLei0Hr0iFauG1BpvQ2OuZ9XKhgsTf7+z4x0QSZve5 7bsZYjSE3WjLCCIFcjjl9pMr/jeRrGWXiU/20u6W3OyPpgKAjDPzRD3av8FqjXegiUJ4KJeEXW w4Y= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:51 -0700 IronPort-SDR: kXD2zE1oDj1STXgFj12eWJqC+g53lVF/sDVYCzKNzqsX3B8MHuNYHjvbNqBg/IWngVga43fuJW UB2prKHfRH14hXjERXQk9GHFguINGWkaKV8x7I2wEqlscgdwRiIRceKStpgVUCt5SslqwZJyQl 7tsCQvOTuzz70FFBFLcEUHEj3i+Q/yBI2ynrXP8D76ej5ylc2y0xECp8Ke3FRSAHvC6VZIqjIw vtubOzX2q0tueOmnGOoVTrnkvAtlKCCU616fgM7DlDVdkzps1br+Nj94Plbioxi1DpRrUD6RuH OS8= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:56 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 17/20] block: mark bio_add_page as __must_check Date: Wed, 31 May 2023 04:37:59 -0700 Message-ID: <7b1df30b0db4cd34a3c9d66c9c126dccaf2eb52f.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CA7222001F X-Stat-Signature: pcrguciuzr7btpbe8mxfrb3rabdgkxg5 X-Rspam-User: X-HE-Tag: 1685533142-532991 X-HE-Meta: U2FsdGVkX1/KOskBZEQUrnDz7syd7TOKje924qY/Mtslh5o0KQPAeYLcLXWM9p+v0KWUcO1NRB6OUUJ2e8+KhGgqOYFoAw6efqHWTCbMi9r1DqUWboM6o/Ef+W3OTryxubOvWLWuEyBkYoz7GY2ezpn0ePVNtxLKbvsXeBmD926p2FCZWNOvEoH+WJijUMjMiF6WKQjvOYmc+2QZnUQERTwFN1K3VnsON2UjPqiCHO+yfX6YIZ1q+0pETcYbgx/rxgXJpD6CXulGmnirvR5xS78lQmCQkDfJt2dhuBqDc3mBhoUBmGJrT5afoRGDU1IJEkACHS6z+HnzheXrcxEiOIlu6T0bzh8nd42ZD8RjDxUrlj66klR/yquHQrXo/CTlvODnRi39u8gU4Jhd4QC33oAyjUqsaLOpV8rDVINQioUKnWLLYdiQ2P6MvfutbL5J8k9gGZwijlRAhocR9kkj3Wa6bNre9ZwtFp5uy8ccWGw4TtCS3jeLzNPuFWp7+L8KLXTK1sSMVK5t3ECJFag7PRAiQY1pX5XLTHpBMe6o5uYEkh0+3dlEaHgM3otumDeEHVpRRTqbaPsnjS2Ay+v+/iaMU2bLOfYNBVDKBos4vvQukxhi3ZXU2ANMkUR8f/96UlP7HSfqYSrdSdNVTQgPgDF2wJNIzkE/y1/8lJiogsaG8pf6eEEu0hR9aXcUhcjd0mpfr3OnTiYbupQEubdMC4oGh2GB2iODXEh7TZkPNJTBruj3FCp4VHiOY34/5il7pzvGfnTV524d2i/bOt+bxiJAUn6KLMlOVITeJhU5m9JU6Zn80qIrHFN8DpF9wcc1i5wMlJAsv1THfACwABr21yDmpneyh4xNshF7nyZr5BuNJ1HD5O5YKDc4CDBLBw9YeOIWP4OBgp96bRgPDbPrK55EueJQAtTGLCdE6FDCeI1kz6t8RVK9Glr+6ybrZrlpq8NxJ3OMd26yoOsPPte /SZ5giXj clV6Yff3zeB6aP/1KyeqAiNOhNIBPsuG5/Y+OzmwA4rphjTdzzOKwU2yi6r1+44Uhi7BAaT8vgFWF/HwQBsOJUMBqh/MsGosWbMU7g/PIn50eElY92kc0gs1IjatJ1zR2JnK96JLQj7SalX87MVBVPPZ+k37YNykE+I/9duVeTHQzZVrsjewoP11XpAHoNw/ahtNuB/2/4QlP+TlK7KjVZ4Ho81VgYtzde3o2473/RsvalzYJ4LkKHMT87ZYwLiGlX8MgTVjQA6sVSTCZ9crVmyJdaxY3IM/ZePtfqDl3zryxNInzoNzuU4KRsrkJ4wZy6kxr8KwcZNSSDv1s4SHNSoB4/4qgK8iDVprqOSIxX0pE2YFCewWtEVPXlLjl1Ndddaf6oqbqGWDuJtNpnavR0mNclg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113759.eKIUXbucQ7LxSIBjNunvWvBe02xPaBbTJI8A0VasG8w@z> Now that all users of bio_add_page check for the return value, mark bio_add_page as __must_check. Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn --- include/linux/bio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bio.h b/include/linux/bio.h index b3e7529ff55e..5d5b081ee062 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -465,7 +465,7 @@ extern void bio_uninit(struct bio *); void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf); void bio_chain(struct bio *, struct bio *); -int bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); +int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); bool bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); extern int bio_add_pc_page(struct request_queue *, struct bio *, struct page *, unsigned int, unsigned int); -- 2.40.1