From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E35C77B7A for ; Wed, 31 May 2023 11:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DFFB6B0074; Wed, 31 May 2023 07:39:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1686D6B0089; Wed, 31 May 2023 07:39:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFD236B008C; Wed, 31 May 2023 07:39:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DE6396B0074 for ; Wed, 31 May 2023 07:39:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BB861140366 for ; Wed, 31 May 2023 11:39:02 +0000 (UTC) X-FDA: 80850353724.04.A8CF83F Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by imf21.hostedemail.com (Postfix) with ESMTP id B14231C0006 for ; Wed, 31 May 2023 11:39:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=aiznXkil; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf21.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vIj6KpJJXGI4GjCHBbNFJm1+SIz5iVkLzC/I2Fd0ozs=; b=kUXzk6aTxXA10Uz1b6wvrqVeImfQnzUJgSyPMQQgJe+XW1go17Ve5GByEOoChTpOv1b+oc FWGrPAvAimuN6G2OoXyK0A/MewXsi9NUTKdARivqYEtZyV3LUYIExfW4BD0bCkH7gxpoGH 1Qsi6qV5mZRj6yRsXdsvX/uP2XL4Bg0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=aiznXkil; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf21.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 68.232.143.124 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533140; a=rsa-sha256; cv=none; b=Aoq7hD7jDdJitLmjM3eW4IJ6wueLadPH2n4qf6KhetQSBTT3KbIkyY4GiFzpzL2mSHGElI xE7dvkcCXPdyYaKzuOwrT/qWHr/rfiraAWFehrdmwolT6fnCpy2Ms2hJgbLnEoR0Yl7ucr arFFESWqo1X6vJgSkTyHEhgfpO1adzA= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533140; x=1717069140; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=C+NYxtWZcIKLiQW8aZvWShDgl/gtDFIUIUOTPRiObYM=; b=aiznXkilqndWp0EB2cbv5sg0g6rKvNhf/iNPgufsi+ZOR4//SLtH1HVN Yiiq8AOdIkh3KXuc4bPOyK/rOg6W3iXifbX75rFaPU3BwMwxBj/BTW0sP sKQvdSeOUyI5zObticiOm8qIyt3EXuKoWsDicZtdYPmNKGxksWbm3uyB/ +up7QHFFLXBOaN46/+9CoOYboOzPPBEQRGwhMP/GjcmUWkSkmcPNKR90m Gb3+I4P6aCjxrB+1QoG2D0i9y4+ypIdunCSHQeIbf0CpdHzfqPf5x3Yk+ f5lw0p0HELKZ1/Al7sXyIbgxlYk8igq9i2IcvZsg1YqCAqeXwP8RIRYye A==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="336547330" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:56 +0800 IronPort-SDR: VkcH6Y9PC0J1PaGh6RKghkgo7ONvkk16zIcC2FdCIFyVop8d1GFMyxyy33E9cVYi7Y/NFTqpRZ Yq1D6tbzfjeOO/0Vj0fkErtC+0sbm+YJktCZeDJ0xkCC+EWflFW2LjzAU+y94LGbkJXUfIdjSV JWopFZYFq9Sqn7Dh/2TekRycXpJS1vkWHmfxGgwHNFANvpncHIc6TYl71oQkWw6nDHMgNnBi6z JInUgYxEJ1Z+jdi+TW5auruJmkGNuuvWaZGU49ZYeLRjeqa0Z6c8W23Ij7T4RMHgXdVM+6771K H5k= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:48 -0700 IronPort-SDR: PKSrcm3NLNbiBK+MDQubevMRCFG4qYLLpgaKSxArlKlOXwW0E2BOzt5f10GZ8a1A+2vN6P0M26 WxUV3N8icLO2ZI2b6wUvGTR/5lBbq92cfmOjXbzq+xJLRd95oOr+yPHrEb9f4OyqGbaMvtJDpN u/ss2e1pjPU9QWjjEw6cCVIwv43Blx8EnaXRymC0CiQS/6JKngFCZrNfKU9sh23zLkSiQp8wJg /p5T3+o8yTKVEDHWcCFvmVOZj2XoVpeJcgdYtjcA8cYxZJnOw3mdTok85yL8g8qD+jojKuWwK2 3wA= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:53 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 16/20] dm-crypt: check if adding pages to clone bio fails Date: Wed, 31 May 2023 04:37:58 -0700 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 53jig59nsb1fsi1qyy91xxu3b4bjtrbt X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B14231C0006 X-HE-Tag: 1685533140-129115 X-HE-Meta: U2FsdGVkX1/7uSgI1r99BJklaYqx1B374xyTOg3WWeZLnUGap6KjpTckxmZc/QfTLqVw2+WxfmGnHI+qt+qslhESMQXgODytNcsQwv96gWdWhPlPo2kIM89QWKA2RUKCddSXvI5VIeGv++0pSnpn2VQ5mbjzM/S52Pkg86hxpPUPH6mavSpmwCJN37cgE3aNCCkP12dJo2gj8J4JAGCBslyrmVdKZDgfrz+KsZhF1crtDUT1IV3I25B4dGo42RV88SFHxUNwQbrrFM7zm0PVExEjihzFgRD1Xm6AhI8pZbZ7wbU4qCmFZ4R4c7DNhTsKfOc2ZhczjtLOIF8hUbUHcgyTLOgaQGPbE052fnHV6bZ+7y44E+S/lz9JISjrazASvQDSHTpG99uADcUWoSUb3an68PcaKt7mGwFRmhjGYqzQYlXhjKE5U79WPhCVGnUGsdJFkF8/QtZJGdjnQdKMImGmHf4mWkPYx3s8csIahRUg5fWsxgfVndNEcGFKxYnaD83Y3hXVeMiy7XBua8vC5M8P1HekKfiu4RSNvTX3+zaYs8XVNw+ioG7QksKINPHb/Dv8FhpmU4+5FzbXV8b1olKC4dhLQ1LktE3K2NtMQFe9Rv5CZ4B28gPLnbdu/v0kx1JQOAAf4VYm3FMsL6rxqyGmYIzw/pL6pDxk4wkKm33vnIjqwrrc2NDsR52Y5C6TgLlxFCaX1yaTXkQtKOH9YuBLENW9Ln4/2uACA00yJiJIVMSG85F4Jved4qS0YSz2eJxF/o5+MkP/hnxTbQaDjF4UGQlhWqBGnABbF567tzU1ijNzR4/00J4cYoP2WuovBUOPbkxqL9dr/vNwO9oeUtLHf55Ttd9nRvz3dKqEEEICJ5ZiQig11bvDu9XF4vTQEkQhWYZeSVHH3EQZt/dxfDwOpSI/t8/TSK7FBJ+o2UMjQ0/+6U6eFLywbZC0ZcXisDLgEMplAuvzVkVSUhR QHru19NS XThe09AfRIcCnSGor+tuj6DmjbB4bGDuvcLvvUFWyWtDjaY1CoUJAW8kErqMUZAwwljU05DC0sIJsnbxytZcl8JfSRKwLhjrDtBsAF89xuIxK6wAR3k81+cWSflQFTPtIoGOBpwLofQ9nbO4YydcbDk7QHEjQbs+sw7ghFYjUsWXiEk6in19qOzbPCqDWjw0ahxn3FUiTu832OvVnGlbBl9AFHCMUX7fYcjVydwZXmXSlLKLTqrjySfWmVFmXJScCpacLJGfsyWQg/scGrd2FA9QwtprIGbxfhJLR3wnDJs3azwa6rfgFtF1CW6jd7E3Mhy9R1j1ETsQ7vg3YjkZQnPLjqIuERoCiUuinbiAl3G8BVwi7ezVT2sgVL4AmLDcVUWPuQXaaCqZaCZTaTF1VmtMBnU8IqwslYVwdOi9/FZd9IYnHJ2BMxE7xj6ivhyoDFEl5hJGS/3oIXbSw5QrAvUTeog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113758.RPbb9t1aL0r9LoBEDFKnTQLh1QR9gq92dj8r9FqD81Q@z> Check if adding pages to clone bio fails and if it does retry with reclaim. This mirrors the behaviour of page allocation in crypt_alloc_buffer(). This way we can mark bio_add_pages as __must_check. Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn --- drivers/md/dm-crypt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 8b47b913ee83..0dd231e61757 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -1693,7 +1693,10 @@ static struct bio *crypt_alloc_buffer(struct dm_crypt_io *io, unsigned int size) len = (remaining_size > PAGE_SIZE) ? PAGE_SIZE : remaining_size; - bio_add_page(clone, page, len, 0); + if (!bio_add_page(clone, page, len, 0)) { + WARN_ONCE(1, "Adding page to bio failed\n"); + return NULL; + } remaining_size -= len; } -- 2.40.1