From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188ADC7EE2F for ; Wed, 31 May 2023 11:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6C3A6B0085; Wed, 31 May 2023 07:38:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1B306B0087; Wed, 31 May 2023 07:38:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895348E0001; Wed, 31 May 2023 07:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7AF7F6B0085 for ; Wed, 31 May 2023 07:38:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4A2A4AE44B for ; Wed, 31 May 2023 11:38:46 +0000 (UTC) X-FDA: 80850353052.22.3CC4875 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf14.hostedemail.com (Postfix) with ESMTP id 4A789100011 for ; Wed, 31 May 2023 11:38:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=l1pCDHiV; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf14.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FSfLaZ0uUnz+itbfEoh9diG/Fo3AxNs8ZFZ3+lYsS3I=; b=I/8rRZsYuoTcf2wZeE0yKo84RTvSmt8fcfntd+cKzY0I1OdxOt+Nop3Czz6QrvSIqjHZ4y im9vK1Csn1Hw2PegA1LxuiPX16Vtknt0sfpmfmIy7puOQDM8t3mrdpI+u1j0jg8GcaieDW pX0d1D6CLTUGwJwvwocXGH6rZjUxZxA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=l1pCDHiV; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf14.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533124; a=rsa-sha256; cv=none; b=gqVyUl2YmYhlMEyWmuq2nrh+82srE5LIUZEObL4gKGcXl0TCjounJgTuMVd26+THX5tzHp sV+bFJbkt9gyr4gCR+UZmWFMCpWlMfOwlUsON8qvfg+WSIQ94VjHBHXao2CEqijPr+KS0c v7ye0akQMy68hm6LVFnQPpeZA+3ks8c= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533124; x=1717069124; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=feBhECdTKAjH9l6zrs2xmhiYw9k0zkjzEVMqz5jiOVc=; b=l1pCDHiVRcwXk7hY35JlV8NQy+R40d2k4bqy+ufnGaZhGzbRwwmz6U2f 6C0X9rDnQZA70vJWFm7mlEf4YvNarTZT2Vg//lHTzAsrTOxOEyEkLnJvH cSstC6ouh1cq/eCswI7YQN096a5B2nC7RDzc1F8t1U8L2DlSV1Frc7GIp G+eiaOC6Oay7jbtztMVopodKlzi9hxx7lnJU8oey3VpdPKg9ICndHH3xK ewam3ykP+Wr7mYZO3zdJk+uBXVmzwYXqFQ5zTMWq6NLQBc5ty/3iw059I 8KeU6R+FvS0daiEHxqm9dY8ytgQsqsks6OUCPtHajQpHZyTOi8u90CSTQ A==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001346" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:43 +0800 IronPort-SDR: mefiguyI4yrGa6n5Zy5mDyhyqMuDGPgDyDNxPLOTiFl+QLvEtVIll0Sdg5vW77xKAZxeB/eL4h uZghDMJKDSU1VzwwmpwWjDw03mKqeChJJOClx4quKuYdQZmWrbTCXOUaA3bT+q1JaINjmNAaQZ oz/A7PfFGMFaZIg89da9sBvMTbvZAXp36NgI4QH+JVZKjzw/UWCblI0VYxtrXgQUfjcCFiHJIH Fdk1qa0lbixC/rLf2Pk28tExStwjMgFne+WZxZS2bMDySumA56LExnpPg5jgHoqBtY8WAGgV1w wQI= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:36 -0700 IronPort-SDR: zYArTEPbqkWBtrkzGzRnMoIeR6kiJOkbvPbC+wGWwjDAMGDQ/cy/2MI78K7BOgCC2XJ6gqSpdf A7o6UmKIuMnpXcmVh+C9TxLx90rYzweZjQ1tgUKsWmKXL/PC9lM1LNqbbWUYDpmLIhPTLj42RT zswpIBd2f1HASE4CIrKh7YhmZRaI1PyBkYmhDhIEz2sXZcZXn6VO49DRc7ZJrHVczIbHQYhju1 wqAT+uxNfk0B15/0iZirmFqbap44kWPKR26CUcQC7iK+CJF8mbcx+qIQh6K8rCeJcGhKuNUxwk VLI= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:40 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 12/20] floppy: use __bio_add_page for adding single page to bio Date: Wed, 31 May 2023 04:37:54 -0700 Message-ID: <7e817bf13ca47fd863385997c0a9794221df7781.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4A789100011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jmu6zge3dcfto1fffoajgxtdpg8x6m66 X-HE-Tag: 1685533124-395191 X-HE-Meta: U2FsdGVkX1/us+xdp1xT9I44KgsY3ALGr1D9sUGyXcykRkFKUFj1uWbfAbXJLmmt5aJ94juaylYYPz4vZaoCh2gPJuVN5+po0+3wDDKrAz4J4pJESlGrRrJgh0y2zQEGG92nDS8jCJdEgLllpuXoikQjAb04Zrh2qKXO07gr0TaAgamg+d6ZKkESy9EP1Opt26fLr/whnkIpf8eirdiwBfuIvsvwDLFmSqk9w5icx+fCLwAaeloVYHpsRe1uVNyGk3JFQDGtuXDZa36D8ltbuyTPZxZum0y146POZMbDEvv8JYoHKb84seB0FUFm9MTCAY+dwEwLtYijzqtgqFbg9XekbufYUrv9velWV+e4fUOEEryUpiZ17WpvnKrPa9Bk1iHerBu3oZ0pkAqajtxdtLtqZcF2VAD4hTcxuHRLPaFHmKq+99S2M5CnKeO/heyUkdvVKv7VqFZlCrSG01dW4wi+NTKj2cUJQs/xzLH5TtERjkCxpx78IgpJjB2ynJI1Y2pWX8bX/t/cKvOTnLggCsK6HRNwrQru/n7gm+hWpCE72/uxrz1BqJPkt8Jkmhs6URJP+7KT7ApGJXiU9+/W4K4pob+VJ3lspcA8YWVUuBDvC1XuvGs9oQAp4MWiaBIpQ9dQ6pnHAH8hIqi2KHgfVkgtanTuwkSlNXksqfChugeZNle/MhDuk/CdWp86tTsFYnUo/4QsZ8T5C9GsOLHJr3FNjStF1v7bwus2keAg7fZ1KcrxMHOuEAZLn9BaWv/1rQpgtmyPwll5CzWvQkicmFhzKUYdIoMCCGlgDFa8bkdaLN9WZ5M9lF0QA7Df3xfNlLjxVRDYoP8YLdOXc9QBgs9edYXxZV3gndR7FfZRsOvDo6ErWDm8xATjPPMhao0ak1I55lr2D9ZRxsk5yjd6BxMnwLCnbosRKgvONqpjmaquo0gs9i9Kk7oUSOX7I+9hsZhg1eFP6/76MArZjTg 4uwVYDnQ dvcHBN9j4LrDaFdtNkj0HRJU9QC6Tk8X575dQ45AR7IEa7tE6XhIdnh/zwtqjILQzUqOmbUWaAxsbvxG/jGGVjFu1wdhqDMurttc1yhA7sA7raC32aEtsRtaZZiEws6BhBDKsaNxeM68i8bxpQ3+Fo/QR53ZY7vG6dc3UaogpLofF3iqCrsWi/CjEGcpgM82pc33CoGWpQJC6iQ5uNlxssLUIaJZIOBu47LX2p+wWT1C1vMB5tr2bL8pCnDE7xPzktsIvKLtg8Yg1sLHpcRM0bpqXwpcCZzbARSqpK6rwp3IKYvLAJTcCQj50ZxlZ3ZhDup1KmxPgPSKOEAg/SN0I1Yv57BIdNrRw7SpWKPnAAiBIMhyGRMI4DGJkSHrSXeRhXoky4BLdCs32cQh/VRBHclkAlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113754.FO59dFH8gJ6AmEcFjN0IYIf-PCzRTSEhLJZoDYHMgiI@z> The floppy code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn --- drivers/block/floppy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index cec2c20f5e59..28ec6b442e9c 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4147,7 +4147,7 @@ static int __floppy_read_block_0(struct block_device *bdev, int drive) cbdata.drive = drive; bio_init(&bio, bdev, &bio_vec, 1, REQ_OP_READ); - bio_add_page(&bio, page, block_size(bdev), 0); + __bio_add_page(&bio, page, block_size(bdev), 0); bio.bi_iter.bi_sector = 0; bio.bi_flags |= (1 << BIO_QUIET); -- 2.40.1