From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D00C7EE39 for ; Wed, 31 May 2023 11:38:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ECEF6B0083; Wed, 31 May 2023 07:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49CB66B0085; Wed, 31 May 2023 07:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33E006B0087; Wed, 31 May 2023 07:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 25B946B0083 for ; Wed, 31 May 2023 07:38:44 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EF3EC80361 for ; Wed, 31 May 2023 11:38:43 +0000 (UTC) X-FDA: 80850352926.14.9578ED0 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf14.hostedemail.com (Postfix) with ESMTP id E5FF210001A for ; Wed, 31 May 2023 11:38:41 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=XGqIAMyH; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf14.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VFstOFR9dzYVb1+kw7n2RDQsCPpdALjz5MVzELWluVI=; b=JOUnFv6Agt7zxktohX4f36jzPe5IHqYlR9AszQdCCEi421UqYUAX2kj70GLYvzBuMvR8S6 J7rqYm70frh9LZ8vE8DwAM6VLh+n6x4U6yeJ65HFldl0vMI4J+pDsreUylJKtpnQb7BoVJ ULKsdH6n8GR09dia+opTcUtKeeozjTs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=XGqIAMyH; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf14.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533122; a=rsa-sha256; cv=none; b=xnzNFWRXwc5v2UTxOkuDRQFfF/CDnLnVuZukrqOV0taS6ll9g4WsKxnYtQv74uPvDWdOzx wcu/anhgsQkl4hvxZpz1evs+/EbEgLkMaO9/8OZbDbcxgGLt3KGnnJlopZq/i/z47jKEeW cKDzrIx+FlFUeu4g1eA/OkEgQTCL778= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533121; x=1717069121; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eFPese9aJpJiKXeG5e/nRQTUpeUtTBckLQcuuv9Sgrs=; b=XGqIAMyHGfwcryeAM99HMHZZZInZ3mPYl/YYl5StjYPfH7eAQJSkQeBF A2YweVxWHMqosxXpbOQHo5o3nk6MXOM2kX/+U4ht6DHR52BCwycDBw3/5 i5DEa4FDc5gYoM6X0Su2/7yrXChXchfFapGORVfhKLFWLQEAoTtoj9wGY +dIy1LC25NJv03cz2RIL+B9CxMqWCrwiFuiv1A1BM3otpIKhHfDn39su1 EbNp0yqtShiYmCQHwKUQnDoddBEDz4Gwfyh3AqQXSQKR+kX8FTA3Me+9q OeI51chsU+tO095aYxrnMz7x328x3MYX6pPsBAkon6PogVgAuuA1NyhM9 w==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001340" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:40 +0800 IronPort-SDR: 4JqLtrX2Hb+nyjtyj71imEqTo6YIVLEPaCdvNci+MjZ0tl/oLN5QJvVZxqBfRmXrb0p8bPTo3P xVoiU8/lCpLnEKaHaI691/yF4LdCW5R0E09wxNft9or9CWGYOrn3jCfoXhUUFOcuWfd3C2c4oz VbJ90L7bW9qUTEAMpiChqtlVl1eIFybjeX+EfmMYA+i6a4+/YR8YrQ6nWV8q6ONfh7GRXHXuQE zvuEyHOQMWwcv5wklszPSbhOqFPRrX+7YuewmmTM/1mKo5dF+uOsOPOwOZ0HVRQklmc7Czrbtp cLE= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:33 -0700 IronPort-SDR: ujmc5KoLs2DdynhiOjmCBXuRbkAVlZaPLEkofuqzDp+6R/G/lfzWOIkJ4otd+Y/NwVPeJknlMa nqO0wauwh/h/LndRpEByTM63QCqInOoAtv9SPXGQUfOBk/R7A2Upc+PH8FkpQ3kOkBxabSx01n FxU/FSeRFYb5OQUIG1immw+PrJLj/4ofWGsdxlWSNgU6KcM+Jy0YyrdLhWY33+3QGX9WvZMDg2 wGMO5YfHoS1LKUknGpUHGRw0ZtsrLt3flydd2oM7EKdd/f4za5a7A4H2ygIdgtB9hbWYzpsUVk 0Fo= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:37 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal , Sergey Senozhatsky Subject: [PATCH v6 11/20] zram: use __bio_add_page for adding single page to bio Date: Wed, 31 May 2023 04:37:53 -0700 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E5FF210001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: q57zq9qpn4oktacgn3r591kebmtdgmgx X-HE-Tag: 1685533121-704678 X-HE-Meta: U2FsdGVkX19x2vutAIVxrBHIX2Yyyz4W9wm7YhxEOTBlONYZrIIqvIuxIkOF2vP++X7AUUU3vxEgSYCVIZzH7HdzUdyTz3lT6WQmv78tA95uDInqV3XjqTQ3Cci9gTMqBdvnZpbwICRQvMGWbL43B6oMnMbFGULLc6zrXYjFOSeqs/3uMaE7TPMq68Q2Z7Av1c6t/CKLOmipBhwov5QHqRSaDOERTExSM/h2cISftsD+5gCGfEaRL2ICxAzUL1h/C37DpANZ1NpS4IhoN51cPHl8GmgxarGiMXlRwwwOTk3mCHxZTwGg38fFki63avyCOw4MquIgTvHjlWO5tCTq+KmlhOjwjBB9UTTVx8pdl90472jFMo+/c9fg3PfktlsLw5/xwQxa5tzB3ra4Y8hElCzgPML9sehoaDrZ8zrbVkEEAi6/m9NA8OFBEPJYY3Vijkx3hf7r9ZkyL91V2JCFQrAMIH2W5mHrGSxEV1+7QfU7rGhXZS1WjGjLOCdmnJzucGFE1kM4FaMnpPofPObYQv3dBocNxHFeVafpPDO1mklIl7Vd2i/ug/SzeEVH29L4REGkq87LHyzCVPU/3VgbfJxfGP5s4Yz4RUZiGaAckuuOvTpQrK+m8ta5i9DPJGs2JVz3O6NDk7mY2MqehKsTmgio5joQXTlyeeaQq9fHsrvrsKxFAGHDNV8hoThzA1snkdalW81RMSEMxN5zVpLWOUmdUmBsk/kZTfReX4CJJpVuGYs3Pzmj5m8H1oUkh7v/HskRmq47/I2VU7JSuW6IM8AwL6qCXUkxmYBqEm+6BCRF1FMisGZRNjhmLVPqFgoYQU9KMZk1uPct9DJ8N4qPlNXVpWxLGXpaywXkXlItDoPG77keIyjjze+rEcznZydfTo95vlXJZFTpFUHqQJfNoN+iHiUMwNRi08E2gHf0k1xLs0xaDgF5gL64pAGMsPzwA3kByMtZReZNVtTbAd0 4MGeGd/s pGDGIDHTYWV8KMOEdd38FtINbI1qGX3zdB/n5Hgjgol/6h/XVkqn9M/i5chD2jYYBLQ5TQCrzo+ppkj5GhpRbCENqjgx1GxRNzmRyj43QiAHZjhTSvMPAtkhe3/MHmH2uJQtd2dXrKomdlgG72ofIaepMyPH7P7EQAF1SYhdR4K+OWmJrB9SY6XHx6LuNrDxgqLjRc7EmLDjtJe7NZas+LoUw1ANn3KDpOw6PYb5vg0ub5T2oomf338cf1n1DEBxWmvihAe/X98BliziTXNaOc0w3s57e56XvtE2SLqbwhMjKqOD/kJa+8nv1+lLb3HFBgkHcCr19FhK8G2TYiATDdvFx+7QnkxqZ5T/G0uT/Dzr2ss6hNr8bFv/xWTO6e0bti2s5BcwCTt/aj7s30lAVsCSs7LF59B03Qjxbb+PHCpeodlatLunvZUx8KOtrdln51/lJpR4mONWv7bs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113753.kd2L57jrTN6jQGWtoAaDweMmp9QNMuE0upq3r-OJ3U4@z> The zram writeback code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Reviewed-by: Sergey Senozhatsky Signed-off-by: Johannes Thumshirn --- drivers/block/zram/zram_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index f6d90f1ba5cf..b86691d2133e 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -700,7 +700,7 @@ static ssize_t writeback_store(struct device *dev, bio_init(&bio, zram->bdev, &bio_vec, 1, REQ_OP_WRITE | REQ_SYNC); bio.bi_iter.bi_sector = blk_idx * (PAGE_SIZE >> 9); - bio_add_page(&bio, page, PAGE_SIZE, 0); + __bio_add_page(&bio, page, PAGE_SIZE, 0); /* * XXX: A single page IO would be inefficient for write -- 2.40.1