From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E74C7EE2F for ; Wed, 31 May 2023 11:38:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F6816B0082; Wed, 31 May 2023 07:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6146B0083; Wed, 31 May 2023 07:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847136B0085; Wed, 31 May 2023 07:38:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6DF5B6B0082 for ; Wed, 31 May 2023 07:38:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2F16F120377 for ; Wed, 31 May 2023 11:38:40 +0000 (UTC) X-FDA: 80850352800.21.88DCF82 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf07.hostedemail.com (Postfix) with ESMTP id EE70140014 for ; Wed, 31 May 2023 11:38:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=NAC3sbVp; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nmPbEXS+MlTpk7DPeTJmCFg9pOUjJFv/4XmohKW+HK0=; b=R4FoZ/MLqjQp8r3zOVTNsRV8jjE+apLz8ne6RhYjo2fEDY44p5ZevBJpBGDNsXs2FnRWmx SIwExQEh48QKI2gskMJU/E6Jk6IxlrcvFwTSbL4ckQfYLQ7nLTgXRgueOfgextloOc1a0F Q1pynH1V1rqZmhi9lYqKiKG7raeM/nU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=NAC3sbVp; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533118; a=rsa-sha256; cv=none; b=iBuSMngYiz+dMPCEdjYW8xbpBqbQ95L8ypnudh8jcquqFU9v/gEU0okxrYj015pUFhQKz6 pcCQTa3sDhHU0UZresr7YMeppwD8wZCqem73xkc9OZgXMEKMDByA9Zi5aCU8VNVHbeztGL JjrfrAnalxTOolrvhHtRBrNv5zSM6+o= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533118; x=1717069118; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l3onFYf+ZZCsjR7ISuwDOJFQGwH0Ly8JQt0dIZLYRR0=; b=NAC3sbVpvkP0Jk0Q5I54OEE2M2rP1dpuZjUdLFXCng5ksduofw8U5YCU 5xRR6goDaTd8t3cmBwWMUWtCXz9Z+TF607Gq7aYifUFlHB+S1ITXynXrC 3/7dB97v+CH8/QMX0uyG4xS2wao4DzJ91VpwEfjI2Xq6chf2dEvN+dqPx EZxqqjKOc3VMIxVLxiNvi7wKEM+TvOhSblVJACXKLow6kU41/Obx/+/ML eH9JjMx0ZexTug5bD+2BMb3R4NMbBVNo9u0f9mGac6RfqhTLQgxj8QtaU GBQsg1OEXzNWcOWNYLFCh15ncym12VIIdmGOXeawWWsnfudXv/4wKsIm0 w==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001333" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:37 +0800 IronPort-SDR: U43SgpeuhfK9+5MCAdcrOVBU+PnbHT8NisFPK4BRRmktd2TOK9wEUEW78d8IMPXDFKr5xsAVX8 R00YtQNECzKh2786NKzzUje++EO1MvxuAKe/w2qY/lMnKVPk+n6dsDbM6u36EJNoiOdDkXlLDr 5Q+TlZmDDA/z6O0oDThJkAMyv9IijsxDFGljRHDRotVhCLQSYOqVBakr1xeH6oYwHU6tpPy5dA cUIq/slfLFM9CfrLRaW910w8nBFBp5IOiH28PsSd1a3dZhAZo2XQDCBMlW93GHbzWJFbsW+gD+ 898= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:29 -0700 IronPort-SDR: PvLiMFMrjPn38X8LB9ZGsZBO3/tqYDJaG3pniIaNYat6/lxe1f7kHf8DiqwXeKwppRmi9ZRGDx 8S9b9hlB12DQNIpsIIMRgHvk5QMkFOd+qw7k1/VRYZhaL95XYJRY5hEOmiTHcwzNJplush40g2 DSCxuqW0Vs4L4hlmoXnbi4NsavII69FPyTU73lwkf1UDBtgWIFJrEdBeuJDRrHvdLhEQfKcn3/ NBJMXnXHTKRIgKnhOWgNUM2eSMZeShoP0sN6Q18EP0Lc1qDSzdGax3Z143F9n7Y7Uh9ryF8RCE Bzo= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:34 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 10/20] zonefs: use __bio_add_page for adding single page to bio Date: Wed, 31 May 2023 04:37:52 -0700 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EE70140014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nzfjthgkr4c7kjspp5nzr5ww4sohz8ep X-HE-Tag: 1685533117-99293 X-HE-Meta: U2FsdGVkX1+Efvsj26XIEtMh5ynnAE5e2Z86uBfO+GLbL+u8Yd97EZUjix5mb40opZEL5mhV4Z7zx9LoN8T0Ch998qGWnupOnbQWFZLvprags6PVhJhuBIWoJKWfkzdHXYuRyUpMP2/tb4fTcIFt0+zw7INOHiq1a0eMlx7Tm7OFgOkrw77+xRWlNyd1tHbNrcfuBo2jVw20A32lTYbIfYY/hATXfM/JGeIFALCOsVlX/xkPOXBB9BRF3FHgMslBA1jnS7ArWZctr9LyiL/rRmjPp2KgAxteAuRLPiUzp22zP2l31Ym4fMi9RBoFI6iAxKpl/18rPNrLn9uFySNoS40MuSBXa/j1zrVl3tdwkKlYhWsO7Sl7DLn6LJXh/Q9gYmuG5U3ZlesyCFSlziQNB0ci7WmchaR3mEKLKJWq9S5+toGWXMtFCNF+dfI2I3Xhth4SHG6gkF/zlwVfdaaPO1n1WE2AMbJkz6DkHIqIEWZghEQvzVMaspSjcesg1XlcNpo1tPR0Nr8uWi+jnYoKCV3H9Abpmb5JgbBcarlVSkjZrHo+6TlSriGAba3YQHXfzENg1/UHgriBXLENRQ2pdmraRG9K02/n3vLmkbjji3AFfcXdm/5qt6+8ElrwjRRtxJDSPpzT16fDC1eAxPEjqMmO+DboBkY1fCpmFZhVF9ze3o+2ZbBkJg5vnEtzoI0xUG5x9NnewZbcayjF8SmGGFTMb25xHRbtJqPptMsWYpXb143NjFQzjhNkToN0lnMZ9InnAoUKLGZt6j8XWjcTKvkcYfFVuLUOByrLIyn4zNvHp77PiGJJ0NFi9FhRKhvSDRvgg5K0sSYmC9HXcm2wAsJbkOh8daKZVqqlfgfh+jhxn5pKvk0/U2VI3WlsVTmYAMK2gmF+Z/j+Xxj0YJ1bJ/RVckHEV0DfVrTyL7+9gmnUwZliiTTBbmMMpY2MfCOAhIwq8YFMf6hA7wyusp+ hYBv6Egb XwIkHTkueqSl44tbYbQKN4pbiulKsojbVGU4gOdnq6ICtUPxbnEwPuIs3ZKxvG+/1wpkyGxg1ZNUJosEQwAj7q2ecdJ0SQqNS7+VY80Z5bTIKtvwe9HUxlz49vdsUK7Jpr4bhlaqcVlLUCUSiawh3qTl1CPJj4UaIMpTS30I3h5JaLdHYq8IZyaxyzNgmRvFl+tOOM9FEVpogdMrOIpaZjTJxn6IBFSjJ3pVGVPXK5x9vub5949T5og+mfvLNAxNZ55YZC3GGaI7SW6nqr5s1TSOKQyTzXQpBSqSeJ613HA9h456Uxn177LZV4TQbHSmwnnzO/Kh4tjdvkJh46PYJPv5GEaEXooszGXKaU4wikND4C5TdehwcyhCyJpxRcj0vy94KLPc9uS4h7TpVZPY/PwsaTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113752.CFKzYTRVBGgF0NChaG8HEI_v-FeoZRH1pp0NPeQP1FI@z> The zonefs superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Acked-by: Damien Le Moal Signed-off-by: Johannes Thumshirn --- fs/zonefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index 23b8b299c64e..9350221abfc5 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb) bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ); bio.bi_iter.bi_sector = 0; - bio_add_page(&bio, page, PAGE_SIZE, 0); + __bio_add_page(&bio, page, PAGE_SIZE, 0); ret = submit_bio_wait(&bio); if (ret) -- 2.40.1