From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEA9C77B7C for ; Wed, 31 May 2023 11:38:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DCDA6B0081; Wed, 31 May 2023 07:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33DDF8E0001; Wed, 31 May 2023 07:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22CF86B0083; Wed, 31 May 2023 07:38:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 145126B0081 for ; Wed, 31 May 2023 07:38:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E1B69120377 for ; Wed, 31 May 2023 11:38:37 +0000 (UTC) X-FDA: 80850352674.06.DC77946 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf29.hostedemail.com (Postfix) with ESMTP id D2EE1120021 for ; Wed, 31 May 2023 11:38:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=GUm9NVZg; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf29.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gby16rdkQKJc35hmFAlcZKrX7L3pd6WhaSEu0owJcMM=; b=X+PwVLIB3xTafMw/2vBeEUnlCifHrqY9MH49rEQn7dT/EGrSNq8zQpwS3J8maqd/rCRzef gIyu8jy3I2HcQ4JxpCgG3A1X8uq0/8sxHMA0OLOVmth1Susp0DoD+s17rQW1S10WT7O7L4 Preo65NnDNp54XKGL4miTqP/XbVfMQQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=GUm9NVZg; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf29.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533116; a=rsa-sha256; cv=none; b=lXd5wz4js6j31+CyOJjbPG3dsqIJ5kFdxFTd4ddkiV982X3lGrxYIYk3SIGdl1Gkl1uf2v ZPJC8t8Ju+o3CH6bCrTSHZSJMZmImoLC3116ADe6xgrqEu6UWPqjbdFPgKqDxhzKzP+g/N EU4zQh20ouBrkXr0nbH8qodYAIX+pH0= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533115; x=1717069115; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=k4Zj5ateI81PgQX8IcVmz/ho3EHE64HEcz5aupY7/XQ=; b=GUm9NVZgeLtD9zfWJX0T3hlanwaqHDmLqD2unPsWzaBp7nSVRvrWa4X3 q7eX7FKnnxsZ50dBOSiktxUWz66QTXQFRjtJkhCDHVu+nhoMqUl0rGqVr q5zkKFXdXM8x3BEftfG7GuSRrQS9URWA4MnMA9cKhPLJQ1+zWZdu+XlJV ZfNIZU7T/oUsvraWXgCCwvPh9VGxnNCyLbNR3UEvW2QkT1Etv8uC+qby3 dtuv0jBoWn7GqwtPOB8lL2LCDygEmuqn5gplqEJVT3ryF14DedH+lJoLT dVBXOidAZXU8CZLAEpPKxtL8FZma/Kd/M3VjGvDBi+TMYCK8oMcmqz1Do w==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001327" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:34 +0800 IronPort-SDR: IMtdKcMLKGRpFvQQtpD6MI7ZoVxQY0EvAar6PtZP+8hXFJ+Egc34+5uzxd732m4C4rvHkqCQea 3uolCTl+F1/ykAYkRbG4GDpKwD8O6hT6cQs4hY9UvFdT1/EuTd1sYgEqP3C+nu8TPnTywHFQJR DVf1tHXDaDmyQ1uIXndwe+3vQ0uzLjScGVSu2nPrsiyOxWdwst/YHB97als2Ffy8uDMlud76DN YaqX6vecXhX/Fleog9fm1GLCXkUmDPLN/Fes6ceVyEdjZdznZ4BJbSnh5ZPEBs11lWexDVUsXc S1Y= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:26 -0700 IronPort-SDR: G8WqXACtyoR6HPoSq2YriEVlneh77SFhenTvEqq6WpnBq7KKM+sPCPm+GrqQFqWL+B2pTKVDpG xA0kbC9UhWyQ36N+cOeiqopLeF5+LPepU5CFaDA0g3dKAvpWpbwRf4GJeNT+WE2RSXfotM/9hs xUlEW+B1evXMrJEbSgp/S8wBvwpwsamqyQBaDhQZvWLew2qNZ3rVv51YiV34nwtOhpZaHa58rL f5PFDgZKJqwXTQa+B22CtHfK4E7KltIjz7TZDFO3mEiNIg1g7wdLPWOhPb+TiaQ+tA5euwAF26 u8w= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:31 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 09/20] gfs2: use __bio_add_page for adding single page to bio Date: Wed, 31 May 2023 04:37:51 -0700 Message-ID: <15cfecbbac931aa18bfd89cede85bcde1d6edd77.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D2EE1120021 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wa6ai6cd9qgwob61bijd56rb1kxu81zo X-HE-Tag: 1685533115-827745 X-HE-Meta: U2FsdGVkX1+03Wa0iEckOpgODPOX3+aR7+uhWY+tdGElq6STGgdm8z8NKFZ8WNe9roaR0j1VaKGgMHhZpMYGXskPKaIPqBY6mt5foMvw8GhbjE0qvlb2vOv9FUvLf8wOC3WhVNrjEtRRyJ5WQDyx5CqBl4gdD2JYfkFRZK7NqWMz92Kyk8tOKdnPRR5Bh3SFwvcgsfIFNz/Ia577WiCJUSRY1oS629vgxmyD3bwTBHWeAQDXeNmoIORG9lZ4j4oIwXSocssBNingvXEGvZ/WGlIRuzmp5d0ANmNpPIssfoheIAAo7ISA56JWNpPgDKiEB+0w570b+IjFy6vUl4IUvfHxukrKriPfmmoCV9Jo4UBV/9z0r6anbg16CFAQ6DpTasJ3X/6gLqgIJ8XYIeA0AdYAJHCs3gImeBu8Q6IZQN9Z4ghT3AY2R7hLxwmqRMreCws6+NkH+M1xvxVSrRSWNEcG1o0IPsOvKgFQPFuRaLhNNu77pnRIcNjv5ER4l6GXVe331jh6F+GvbPnLyI4bv/fG8kyXVTdcFx0HcFlRjzU4PFEW/1FIVe+gnPCu09d97i9O6UUl/3DLdT7zLv4HVhveenc83xwkRWBRBc6pvm5C48zOXAJnE5mg5DQEXqd3qZH/Ls9OOKl/auWxi0jy7bAZhDG7CboEWfK+StsTTyOyL5b2hbZL4j/jPHXNHhlUtYYdnvL6QSqDZEgGriOoACIZCEdDEbUAu665wyr+FUUZdnGUnAJuuH0VkJqGmSrqKMQykuRGHzZgLdY0MwDydbz2qmQ941ctIGhShknaBxa0xf7DK0ZkMg9V4yuOsfW14f0phHu5VzC1/gtuNp/knZmDogfBIoCayzSBCjCacBlJwSJGTKfMdaL1Gi1I8hTkPXVV7If+wMusZ7+4cESdl/tAM+pjz66V0+7ykMzRI5JwJWe1AVp2YWSbFAj4SvZqhQ/adO5ZrUk/sY+MQxd gAsOmekX prMVgO5j11v9JSI6xOrb6NGAYsaLuz9OXo7EU9dCvuZAcr2D23Or+sZOSwKaSIl6PArS0HY4A1j6eDcZ1WCiP4YJmj4Ly1KeYD0FWKcKwr3a2HrNBydhQIae0Lw69+EvlkWy+d1WwAseAqqScaDK2EpkJAfiSEUDJiQ2hAqTwxWsN8q5Hc/a/6ug4IYq6UnBozV+ejsuLM1cNttoSrHxb+wAojH5/M36PXLbsN4lXHfPasDhjpmVlCQwM2q/6XacwRD9Dq/Cz0cN5IdK/y+SuQ2qFCNFRHk9925ASLATQo7Yk3ITGUGVaniWKE97KRXzgQCkCL8OMKOjdmJhrxSM6j9LZ6BMyY7663LAz/2wkz9Qwv4CDVzaY3pG/PlKq3nm+swRhtvWj0GIW7vyHxdElvkhrpW8+5DPGKzi3xfkYvvoYiXA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113751.lRmzycgp_z8UAKRD-E_f1NYPlD1DDlfTs66IaBhl-Ck@z> The GFS2 superblock reading code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Reviewed-by: Andreas Gruenbacher Signed-off-by: Johannes Thumshirn --- fs/gfs2/ops_fstype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index 9af9ddb61ca0..cd962985b058 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -254,7 +254,7 @@ static int gfs2_read_super(struct gfs2_sbd *sdp, sector_t sector, int silent) bio = bio_alloc(sb->s_bdev, 1, REQ_OP_READ | REQ_META, GFP_NOFS); bio->bi_iter.bi_sector = sector * (sb->s_blocksize >> 9); - bio_add_page(bio, page, PAGE_SIZE, 0); + __bio_add_page(bio, page, PAGE_SIZE, 0); bio->bi_end_io = end_bio_io_page; bio->bi_private = page; -- 2.40.1