From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C07BC77B7A for ; Wed, 31 May 2023 11:38:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16A966B0080; Wed, 31 May 2023 07:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 142126B0081; Wed, 31 May 2023 07:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F24F68E0001; Wed, 31 May 2023 07:38:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E55A36B0080 for ; Wed, 31 May 2023 07:38:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BEDA814032B for ; Wed, 31 May 2023 11:38:35 +0000 (UTC) X-FDA: 80850352590.27.B418D17 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf07.hostedemail.com (Postfix) with ESMTP id 95EF440012 for ; Wed, 31 May 2023 11:38:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="T/Nc9CNV"; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v0H6G01iGbarR6jkv3pBNWGf0keH7ufLZQ+rs2S4Px4=; b=dCt8Fz/aW6HN9TsmmsHso9XpQ7vZFJH+iIf2HzTwl2nYxF7P+fTCy/igMR0Fg56S9RCgzX BRX0EPPnFraglabp0a+KlJHgSI+0LziSS0wfB/FX1XfYHtOc69328NIiYemrysWNQ8cm0D nnw8n6y57ZNyJicj5IApHW8HFSlheNA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="T/Nc9CNV"; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533113; a=rsa-sha256; cv=none; b=0vCScAbIM5dAndjYwDIOjZ45COwxKRzbvMFsnuq51LARMBz80rt0jydQMo53KTNVvtlRxj bDOXuELwpYfUPO4AJxZ+ARBthSxg9nzzHMIpFu5LBPSevxTvjNHEb5vZiDY9qvIKGkTUB9 9aMvRTnlcIpD6wIO1asVxDi6P4JZvag= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533113; x=1717069113; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gSS6s+Y+KR0NN3bBjgfAzE61ZLWZg7T5kKisYNE42s8=; b=T/Nc9CNVfIPsha9SUSWMymnzRvpOy0VKRzZl5fWNJRuz0/jH3XpF7OX3 c+/NgzatBa08pvr4oMe4TFyed79gGiiYuuAXYw2Yem7TVjtAZDpB51J9J /4dcVwU0buFO23SsU1YYZkrjh5wegpFQDZ9aemPCM6lFb3vyv7dMQNnCE fZ+TgNA4E9KTRJOQUl+3y4NnfvvKhKicrcufZfPWCfZz2ez/6OFwq0UlR rLWRMjO0HrIzacd5LePY5zUkpEwOFejaR8Qw55pXxyzECGBZ/Lnia1fka CGZOBhopV9y8ZwsiQVC4jESnQaDPo8tfZpB8tbJZXEsvKnMcIdMYOIjPP Q==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001323" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:33 +0800 IronPort-SDR: Mj/NdHCVB62ZaSvMQJp5nMEvMQaZNK07YrNucCbFysWijWTt+JOInDU3SQQi3M0V33qoX51sLa 16C7cuqwujcwxfC1omPFM7O5kxndOP0U9/Jom4Kp7pxMIv74D62/inU5Vaca25eTgCyJ3XKkIk z4mRPsuQ/NsGIUHXEMMWlVGgmCiO6eLffrb2vlgESOEuM1LMbNaooFiWhhGlO6YoNSlrVAOfio 53v4W8tzslJ1iceA6Vob20eFfUh177b0E3BkPHDEAKs0FDuxNC8tjERKJZ+lKHENlG4G5Tsi+M lc4= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:25 -0700 IronPort-SDR: JSgXyBZZok1EXDuZ59SW6lRFhAXW+X80OO8hGmbMhRKYw54A3BGs4ahdFTJW4x7o11w7KSXrNK Yf0BQeZji+eI4DS4IhNjMon94S39jdYIUYfoZL+SiMSAhkxxtQburFqTkK68xDLMfkqt9VKnpH xv9KqHWSF9erDxT0pTa+AfbeBeEaG9EEuPMKZIv/Vh9IQ4i3yQmCWEAqY2bGMByNKMtgMzJrha YzvMbDYtWOjxoe42zCd893EgbTNzNqZW/HcFI+RT7saqnoZC50PN6bDeiJLtXfELlio4TcOBPV Mnk= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:28 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal , Dave Kleikamp Subject: [PATCH v6 08/20] jfs: logmgr: use __bio_add_page to add single page to bio Date: Wed, 31 May 2023 04:37:50 -0700 Message-ID: <328ebcc2da2307aeb03ce17957a73547c1222e34.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 95EF440012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: fckncut1xnraea5uzsr3mwrkaa3m9bwk X-HE-Tag: 1685533113-267396 X-HE-Meta: U2FsdGVkX1/P4YoO9IN3JGPntiOSkZf2G6Sel6eQB7uM6Guq1jLW1cBxFRgh8GgBsJICVMCXHslfszDlSnUOYEMcOFyU5AaE5tipJc/+bOOBX4M3BLfVXuVpYdG1dvlGym1+C5UqjpBI2xddfwfiO+tKZsOaU51P/rMvAItHWHVglUJNf5ppCyfCWjkvFf2fpy83cft/dFrHtOt4hQ+vcJ8kCHuiwQEZCPE5/NlDntZBmY8XEhpZ0By+Go+cRe1rJ6osdaA4q96cxB6vJH5IImWX+rg69bos4YZtpXZj37Evpkwt8pNqFazwaQxX6mKEzDz5wWSM/Ffc4kYY0o/Sw/FERf+NDCvH6Bhz9O2BSBrT+tTbEBbLwGZjlnfw53ZhGrKf/M1V/bwr8tHhHJXi29G4yFxpuS7k5ltvZ8bt8XlbTVaEqm5p1iz+spaUFVFC3eqlrIpHIMhZatwv+B2SjnqUsV30bMPGaLIuiDybG/zmJeaWlsGCwV/stBmZxnobKDN5Oq3y9srNljoQXgiDB9W8HhVl2w/vhqwN7g/8taC0FSOYVwar2P5pMVunR2JcmUhikFKYimI2jkgk+pnYnf/spmqDj084osFsHlY0Uqnvx3SAoFBMG4baK00TD6Bu7Ochk73JpCBRsMgWNmYrOFeDIMgSFVXosJbDdYO4IhEg081mkEU6CiqZfCA5LEYxYJ4Z+Pte8+DhhxdsDaH30JhiHZ2OE8bU84G+g32mGYOoxoou8AtM4hGemOZbwZcYwreFIBwhSwSuCHWF+uNXiQ3cVTHCcp/VdQ6FlBzfJHTIIzmW+xV1A3qlca2dm3xRruUCRjNaaaVqqk7Bvom6IzEoFF0qi75nalUOUGOetFN72b0lamobHuTIqlxu4KJx+tttgGrkHGuCdZkm4vawZs+jhePP52GXVSddRhQIYS0rUC5sTbJArd3J+fgy/oHBy5iL8sCxBa5VQ5W1mJ7 9h5erlgB RM2urpmfz8mNRdq49nt5XiDRhb5U2+5a8OW6EOC72LejzAmpRcB9Gff2cvu8rVarW+L3MgFqSaihjMtc0d0+zE1pwH2gyRTzkcrg2VrOa5p02549YWS9x2966ASVutZyeLyM5jHXSBeqCLMQERB6pVDbWIhF3l7GI+XYHU7JY6pDBdRBx7jzUaIqcPDVvMQVMcZ3a/gZus6Jbcsx2dlrtIL4785u5pXRJXjUE1j2rKc+arAaVhlC/3l/3P2I4KYAzK9mKVrJ1dKth/aOr0N1GcjGmFkqNS9WXauLyi518sDRaZMobWCKIM1pMX3xTBcPpe0tbZvXVm8GNP8Mnc9gnLPTBVn6Cx/TiyMGAWSpY+ZM2gxSyJDGGWvNED4/cGB10uC8cpGRF3fQ7V8TW2qtFZULjOgQncRtGklrYF3FNE18AIRk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113750._qmb7fcjoyOAYMlg9gvOYM_jCQlPtapmPsqIh5vliAk@z> The JFS IO code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Acked-by: Dave Kleikamp Signed-off-by: Johannes Thumshirn --- fs/jfs/jfs_logmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 695415cbfe98..15c645827dec 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1974,7 +1974,7 @@ static int lbmRead(struct jfs_log * log, int pn, struct lbuf ** bpp) bio = bio_alloc(log->bdev, 1, REQ_OP_READ, GFP_NOFS); bio->bi_iter.bi_sector = bp->l_blkno << (log->l2bsize - 9); - bio_add_page(bio, bp->l_page, LOGPSIZE, bp->l_offset); + __bio_add_page(bio, bp->l_page, LOGPSIZE, bp->l_offset); BUG_ON(bio->bi_iter.bi_size != LOGPSIZE); bio->bi_end_io = lbmIODone; @@ -2115,7 +2115,7 @@ static void lbmStartIO(struct lbuf * bp) bio = bio_alloc(log->bdev, 1, REQ_OP_WRITE | REQ_SYNC, GFP_NOFS); bio->bi_iter.bi_sector = bp->l_blkno << (log->l2bsize - 9); - bio_add_page(bio, bp->l_page, LOGPSIZE, bp->l_offset); + __bio_add_page(bio, bp->l_page, LOGPSIZE, bp->l_offset); BUG_ON(bio->bi_iter.bi_size != LOGPSIZE); bio->bi_end_io = lbmIODone; -- 2.40.1