From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6A2C77B7C for ; Wed, 31 May 2023 11:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8E0E6B007E; Wed, 31 May 2023 07:38:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3EA16B0080; Wed, 31 May 2023 07:38:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B05A58E0001; Wed, 31 May 2023 07:38:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A0EBE6B007E for ; Wed, 31 May 2023 07:38:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79EE7160374 for ; Wed, 31 May 2023 11:38:33 +0000 (UTC) X-FDA: 80850352506.20.B42129C Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf07.hostedemail.com (Postfix) with ESMTP id 196E940012 for ; Wed, 31 May 2023 11:38:30 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=lrd8keci; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1S2DSWAZA9qgvAvQBzAiSeR/Df+u9UWYi0qKutiToQ8=; b=X0yd/WkSR9AFkYH/DhxosBLptQJWkQyFPOEKvUIn9Nupkvt0L1DvjB9+ItCKnLKLYAedAP 48gioo4RnqrIlXj99HWmHFlbuOuEcgV5dZoaK8o9WaCqPq+IP+I1OPKPbB04yqTSLie3gB lg+dX1TAMeGRc6Pemj65HC9M0KZiAPw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=lrd8keci; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533111; a=rsa-sha256; cv=none; b=D8cdEQFqyk1omZFKU0Vssir8zAZ7SewfBiuZ7ktCUPdtja521ViiFBeQn80mb+yknMyfZz /+lmV1qjj6KZnMq2LAYQ9t442dUeEdVZ79c22J4bFRytwvuvnI/GO2Lvsg87Rmy9Mw1pfW mDEeXA1wDhrM0WWuL86+E6JB+oit1U8= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533111; x=1717069111; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3krWE0DP9xJWhQSqe7JjRJmAUx3KR1tDfQYkyCcToNw=; b=lrd8keciFdRZvWSRS9tA7iX5mv+kexndL83N5EFkHFUqsa7LS9U9fP5y O5OUnJhWFpK3rbd1IzWAuicnAehNt487AMuCTlWFcKuHj4DeMHVsPHB0n GKAJkmmmIEzDKNBmr+4RbVvPCGo+UcuILQy8DAAsEAs8xVmXb6pHLuRUG bano4/6ax08kGl00/OzznV9bnVesmlrX9HxrF9rhsbFoFFS1JQKmF/y8m EuKQqGq9eqr8UTWUNKurYY23OSmFnhB4Im+Y8Xq9dZj9s3Gc5H35iSFtI t17P3vqxvQTMv/lcCeNyjUtj8IoQ0VVyRRLuEpt4DRsM+Jcwn3KGTEYB0 Q==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001319" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:30 +0800 IronPort-SDR: wGFTJnaIHIoZVFx6nwTKA3Vb00hybnIZFTfA0j3EeSXy6AWt8QDMe1P60LNymPlOFdgVj6VI3K /tjzsa78YCKdM9iae+OeZk+1+TwxyzCf+3cQNiHhN+sRG9BFfvzeME51eO9EA6GYs1SUiLAgB6 oc50/gB745OWpeWdb4Ubhe1uivS7x0L9OWljkcssei20WiONUnXV6AhYVQv+GRA2qi7H6X42Kf hpDco1/ekMzdHMSdHlYntGHThW9gTpAhxvEdVBx+8zjb5Gdn1Qme8X9ekc6arSKQ/IK7XMvbnV NOk= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:22 -0700 IronPort-SDR: 47ImJaGI0R9IgPMsLaQXXdNwrl6BEebozUMm1VHcJZOy8vHI0VguiDlLtNbCdQ0iVmIlwZf2KH MHqeMR3rx02VYb9EZouZVxWQXSWQLNGu5k0JnkvB1/MmstC7zczZtC9/Xm9nqDLaDvbUVAiLYq 4BiFarfx+Pmel2FLUYvzqM2dKdGWHPP/5Bq1M9lybi1epLOXbOCcLT62MykPChljCayYuf48Gw SwqcdZmp/HRFZLnvhq54wc+8zznlM1jWToLdgjEKNUzcmtTQh/xrIaFC4s29CsGWXKlhWyjqWE ITw= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:25 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 07/20] md: raid5: use __bio_add_page to add single page to new bio Date: Wed, 31 May 2023 04:37:49 -0700 Message-ID: <6cdf62501852fa43493ba866a49dfc9e859aa5ee.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 196E940012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: y53u8wwhs7odx3eb81zu1n4mwpxf43r7 X-HE-Tag: 1685533110-274222 X-HE-Meta: U2FsdGVkX1/S/ReSjg4nUsEa7VwjFqdQvqt6KApEzbTXRDwPmSbQ6c5aCc9w2XSl9WSEU4of2JJIVIxWJgs62dBk23GxLteoLzWcyLSAGUhQHIUn5me+ec6uxc6j8b3idJPt+xMKTGcuZuCAZbKpORS5hLO0QvaDT27RasiW/D6nLBPRK4/hozHn8pieMGvcmda5xm4jixk4zmXOFReAZMNutFbcSXvJjv2J5eem8jzvx800VPnabgWUABQ0JMM3vELrIl764hNnlqnbquA6Armmk6gVvVXieav+vMuFYqsf4Gt6m1Jz21tcLMgSDsSpzPYVZ40q3npczePy+pqrOOkl8sVipIgnMLGB7McQWwDyooJqrFP+ckhVKiPSmUOpRP50SaloBl2n9cvHiczZetg2n7u1cDvfivtv9gGMtdPOxVy8bx1IwFwZoYHk02z4yEBfCkDfMS0DiPIq/mN2Ha3MlqfhMqhxG3JfeD9Z+3YFhxhlzr43lRSmJmCUMgEuWEPmdIADtIEfS1sL2JxQnM5DsJN0YAVIDnypnF+UpTXkv/LFhTTSB3XwIr+5/rXLE4JFo0JhbiyqhNIPfr4sujAhwrBffbkApGmq0yAkHFE7RCxikZvcV5GS2kV0igN27WiR+ZTYeAuusezE6ezW8PnpwHu7gixoj63yeVBhJ1FZf1qXKB7JPccKzv6wTHvx0m2dM8++klLV28QDBXA86iaDJFTzNflbH1tAIYWGB4VGc0IVyHowCyrcXlgD78MLdGR4Vw7+591zWBt94Unc+EI0hc6K4M+i67F9xyOVBJjY6KWtk57kpLc9bdNH8t/zJmH3Do7MMtuK7UcyqyckRcjc9Jgl4ARzZveGgU24IXrErWm3nOCD6ONZgq4p4wmMdAkDpnlr7u05NUE+58d1kcqNS5eOM0Sf+POi4KhgQTlOZoL7t3HOA6dTxrt8uDGSggcaxMZNxs/kxAW4Ky9 1VEPv19d NNJPFHCpWvtRhhKhOYBIJ43oPUOfPxt7MXHDSm2kbdUUfoZFEv1Rx49VPIDbcxzqIpaca3U0UXYgY8omQVxTGx9xX6+cft/SRtNY+T5ziwQw4DHZjH3g7OxH4BZbkm8An+YtoW0Ov3pVzUehtiyH4uF5TN/+froxnjDNnBOFyaND0G5xPyLu3P2obxPUL7RrUWWFsyGR75Oy0Z1R4Oq2TuGHMqs9GpveD1byiNwdAD3/WOWyq/5mN5N/b/WwhnHsd/DsXY1fX8BKVBl5otRBzbxXR7aHs8zBqQbQnHQG/hDYDwImfSyGqqunlkC3xzEJzIOfs2lBs+5kZuCmwqOSL5v8+t5c4QswL+dPpOAwz0Eik5DwicqdQx3DAGWwAIWvPyDjrbxvh8/ttqDvNbSLVeuFYdTNMXSqe72O+BqClumcU/2w/Es/Tb5rumAkYZ153uknMgiRI0GYT9wY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113749.QyKkTpn9e_Mpb3hroxi1RtssmRXGSI5t2AFkAAOojIY@z> The raid5-ppl submission code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. For adding consecutive pages, the return is actually checked and a new bio is allocated if adding the page fails. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Acked-by: Song Liu Signed-off-by: Johannes Thumshirn --- drivers/md/raid5-ppl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c index e495939bb3e0..eaea57aee602 100644 --- a/drivers/md/raid5-ppl.c +++ b/drivers/md/raid5-ppl.c @@ -465,7 +465,7 @@ static void ppl_submit_iounit(struct ppl_io_unit *io) bio->bi_end_io = ppl_log_endio; bio->bi_iter.bi_sector = log->next_io_sector; - bio_add_page(bio, io->header_page, PAGE_SIZE, 0); + __bio_add_page(bio, io->header_page, PAGE_SIZE, 0); pr_debug("%s: log->current_io_sector: %llu\n", __func__, (unsigned long long)log->next_io_sector); @@ -496,7 +496,7 @@ static void ppl_submit_iounit(struct ppl_io_unit *io) prev->bi_opf, GFP_NOIO, &ppl_conf->bs); bio->bi_iter.bi_sector = bio_end_sector(prev); - bio_add_page(bio, sh->ppl_page, PAGE_SIZE, 0); + __bio_add_page(bio, sh->ppl_page, PAGE_SIZE, 0); bio_chain(bio, prev); ppl_submit_iounit_bio(io, prev); -- 2.40.1