From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F1CC77B73 for ; Wed, 31 May 2023 11:38:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27B676B007D; Wed, 31 May 2023 07:38:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22BDF6B007E; Wed, 31 May 2023 07:38:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F4BE8E0001; Wed, 31 May 2023 07:38:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 020436B007D for ; Wed, 31 May 2023 07:38:29 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D890E1602C8 for ; Wed, 31 May 2023 11:38:28 +0000 (UTC) X-FDA: 80850352296.24.5861D04 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf07.hostedemail.com (Postfix) with ESMTP id D42114001C for ; Wed, 31 May 2023 11:38:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=gFz8uQJq; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lesC7ZHzHc7ah/ToJ8yOzNcL34jZPc+O7TdhQ2cqcu8=; b=a2cRIYcKJdLqD8drZ3qIgnBulI5fe+qX4Jpq2DLVzrcoSUxTsFHvDx0GNy9iSggI4vsovy P20kXibl+LmAm3hoTfzKVqKweTLl/feF70bYf+qDpzHzjAr4kG+3LOCKeT2BcZTN32yLF+ tNNI9fc0s1kE+A3+LABQc+JGBysrd4c= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=gFz8uQJq; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf07.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533107; a=rsa-sha256; cv=none; b=DYigOyqeZhagT2FnuyZNd5aBE6RNloTBFTAPnbjTfORmM4TJhVQmSYUIog+u+sgbJiVWCM jaf7THb73okaaV12Uk9D3bYWxUzIUryAlJkuHUFs2ukrHm4Qt2PoWvKcbgxX4x9VhVNuG4 m9zTa7pjyrF0s+P0zDUxTNdFNiWJjkI= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533106; x=1717069106; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mEDf+2bPYBdApkRtQGcrKQLhlyK4U4yv8ooj5C9H9Fo=; b=gFz8uQJqZ1JRQA2MKmnHYbKyg2YdkPjGn6hHRX9bUybcfF+0ll67w8tS rkVZ3KJwqnFGvtuKa+ns5IoxbCPf7VEBtJTYvSaerAw8dys9Un+fREmWG 22/yeAxzyWH+wmLdJd5G2/kewXYE0z/A+lXBVpOT9QYAD8fn+nVkms54p fwUrzwG+yngW5Yhf7WX866wII/ETgh1WjY/MgqFF7fK/QaEky3hCiphZm P2FbKmLZYlf1rF6JDDgk2wbjA2GdWz9pQtVCtDwQpp/36ZqW+zgJIJLgN w8AnjMBxh3hWBOvHV5WvhnWkaPWymL6GKjZa/gdYiRp3DMPri27y6PTTp g==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001312" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:25 +0800 IronPort-SDR: fuJvDaxUQ+aYpZTSpD27muOJ7m+BhtrLib2I8+HHv0clkV4L4TQJjSr5CjQtEXTjMK4PoUaovo gpXyrQbYe+Qu2VtlBd8okfQjYg5vY1p1zsfp3pVlPQcG/ldBPiOBBwIhGv4VnM4EzmpgAc44sQ ichbySYcYFpx54Br56mop7iqSfZLimW+5k9tifwXawftPH4sYA6dWD4lsr/pQ68f12Fk34rkGF iUaI6tDwIfHwhL+rr/1pphaZuJ90pxCPEQehIPIgayjgYGmM9PdeRkd9NWkv8bGBbYPPEz3Erd 9WE= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:17 -0700 IronPort-SDR: aNTVBj/pNYOm8LQW/Ysyt++eETiXP7If4qejTn0fgwq+ZBvvjbFqnWjX4cdzAcsB81x+GtufD5 4CHrk3zAtKxRtt5SrrV2bu+MNhH63gMrYcc4D4gKpDa93KWb6m58gjDK9xoBngjeugS4uWE7z9 NwbSUCGGc2OIi/GQCF/6Y8t55/FhJdhT39gpNtonggVW3HmW/CajaG1O4A2XU5aP3EL6Og0AOz J6wM93B7s7mTIZOtB8dnVwSE7Xkm+VtttBGZJwZi8mxnvp3q64E/M567+71xJT/zY9kw6Ysvqx QD8= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:22 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 06/20] md: raid5-log: use __bio_add_page to add single page Date: Wed, 31 May 2023 04:37:48 -0700 Message-ID: <1ee0465c7b2634a4435e65a4d0b06019a73d8389.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D42114001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oz9fed6t6hgqck78j4n5xjot46jfqaaq X-HE-Tag: 1685533106-907323 X-HE-Meta: U2FsdGVkX1/kczIq+nD71zs+iu7uEo48YrSHg4zTZ1ms9iUWAygl4o9/hbkB8FZz4OdBTVzlHZOKG0RpVqy99a3FhnWaN0S6/BFFEvb95T9ybg7q8LaBdo3f1Q/co8Thvk8l7MUpF2Nlyoy/pYb+vqCGMquEyH9vL/qxUrTYsY/ovgoZg+dYdHcIwGhHX5iMJfHR4hkkAiSSHtQ2pbwtEi5Q6BR9tR4R3wMVqDzlGFzjyjRSzZOAfpvZ1Oal6HqsJVEVvfLlns8muNBWSZwtaOzqCMFkWR6e+d8F7IMFwcRz+QqUZmSBdt8iJD3bA8B7cxGzDrV9hNvoOXA6zOyErOPdJo7wi5DrI3aGVmXgvgrldFUp9qmEDonaiCaRMfv/M98YlXc6M5+Q37ptAn902dfMxNzJGCUGwgt7ceqPKeKaREZurMOrIEhhx5TOIrrMrmLEjMpFOwBirewgjpCuh/+loONv1sDr5O08JEUb0ppum08nJz3yB5b2+ael/qs+wLDJbV75g6eMkjHyqWYEPhH3ms1rnsWcGVLtOOHUVu78UjxL4t1xD7WU86kx26hROMLAdlJopyzDFZM6N2XdBKkRDCFjghK8mQnfzyohrPFIiW5OwUAJo/+sJQX7UcmB2yOnQ/RgsTDxUidBf/8Qe9L9NYidd//aPJHbYwbT/hQTv9ZpSUpRNgBDlVPF/NX4wgtMyNEe1zBWdiSKSTKy8rkiWdh0y+yiVyxl+1ddwEBZ8dKosbx0ksFchwEbOTMWsntDNrLdHfAFZPatCJDOLn/YPl/3ve1gaFekw7kt96Vqi8ElaSH9/tm1F1EaYjeGwT2vCvMIsTO/SuXQQlY+0nT4bLLSz74z08Crw074T12Q877Djq6oMWOPylo1c9T/2qn/oooh8oSNu8jH1cLVEL2S5MXjrZmROF5wO42OLWJKW14Ryv0pwLcD3EZSqHsrRCKSG4ALmf1dF27B3GT wVqlN7GR +gxzJbQ0si2u2pH1YkCFAQ0wzOjQjY9vNzMzpnBOJH5SpeWkS0mpTuakMHb9wGTP0FmIG1LJ6LNH9EOigvZB0p/MlAfrBWd07rpHuV4Jcd4BnQMefJYQDUsmqraCCnhLoNm1RrRoW14F0qbTb2zVw+TGm0DqSBO/pdEzC+FzkVDhRM2gdc04MmPoFOA1dv6ruhsL8TE7gGLN6ijul1OMID5h4CXrrxI6ZWKk2VMX8O1fDnglxEvh6No0I6+I+4Hm+KA9vmUKoc1lMVZ9ecotx6NPw2Bt67C4VmBBoZtNyyjsoNyh+rEl4B/pAkZnhy0W4iNjXFu2WZHM72w5pXetvI0chUGUwav7UB4/QBxYvYQpNHGDxG7KXnWX/6NK7cgaTcs9J6TYsX1YFHKXixIhJ/YjoTNDovzeU0z5cOGjzO3FFNhp/rS7un4CenFTuVFwln7OHNBWcShldcpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113748.VhYbKhBKRYZPaU1lI2PYf8LQGUsZRZlHv2lSMnnZqUU@z> The raid5 log metadata submission code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Acked-by: Song Liu Signed-off-by: Johannes Thumshirn --- drivers/md/raid5-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c index 46182b955aef..852b265c5db4 100644 --- a/drivers/md/raid5-cache.c +++ b/drivers/md/raid5-cache.c @@ -792,7 +792,7 @@ static struct r5l_io_unit *r5l_new_meta(struct r5l_log *log) io->current_bio = r5l_bio_alloc(log); io->current_bio->bi_end_io = r5l_log_endio; io->current_bio->bi_private = io; - bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0); + __bio_add_page(io->current_bio, io->meta_page, PAGE_SIZE, 0); r5_reserve_log_entry(log, io); -- 2.40.1