From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCED5C77B7A for ; Wed, 31 May 2023 11:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785AD6B007B; Wed, 31 May 2023 07:38:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7350F6B007D; Wed, 31 May 2023 07:38:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D8486B007E; Wed, 31 May 2023 07:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4E3D96B007B for ; Wed, 31 May 2023 07:38:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 20F101C734E for ; Wed, 31 May 2023 11:38:25 +0000 (UTC) X-FDA: 80850352170.23.30FCA39 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf30.hostedemail.com (Postfix) with ESMTP id 19DA380010 for ; Wed, 31 May 2023 11:38:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=NOKEOh77; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf30.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JaOdRASqHT7xzwXc2NQuDZOUhvsv6oArp6EMJMX683Y=; b=PRhbiUVaOg7pHN6yTs+eN2UMQeSlz/pqjC+R/JqOo/By+Ce9taKDiqfURkftj8mV4YV67L xk6Yl5nC8r++noYFERkou4Ut0FCTzioSGk47UnIYKT0Z4hEUArPdvWJ4VQjJZeZFRwUwYs 8TpysuwRenTijs4Ng5V+nlzhEd9f9Rs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=NOKEOh77; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf30.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533103; a=rsa-sha256; cv=none; b=MjkyXYqSivaVZStTDFD27Ywk4FN53hmLivjRDPWefOftH591nD6YXqGIAIvWjoA2bb9enG qXrWFWkT7SC5+b0B0K78PyMsGdXMQaKGW/QYdK+k51V4iLnYv6X/eDHzLrqMwH5W/SLWD9 FxHHU65mxyguCnyT8pbU/l2CgrXFb/0= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533103; x=1717069103; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I1+TGenMrGdtSWKYS446AepXRO4LZgePrjmNY71VmmU=; b=NOKEOh77zsMIuGfsvJ6/ZPwlFF5lLe/WoURM39gEnbKGgeQp1bBYpafl fNTzBubinLIqMuBgRS2byRg/K46NWodXlMdA5DlNlqXznBBVWTQMbnuE0 S1tVUUV6gHJsMMtdabILVELt9cqEv60AMWOY0HA05LdGzzgTNN2GU7oc9 GnYHfM6g/hSB6dWiiTCj+v0Zw82u3nyXVSxa5NSZ+6tHY1d03rG48rKoJ KUtDp9O/+AUiCar6qgL60yRuPQub59qzMXIrQPfxOmNzfwkpK0Y4JH4vX 1Q0qN6Z8J1nzfeBP8tdR1NjxSSifL/wCBccZqrSX4kmyQnzZvmNnBjK5h g==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001306" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:22 +0800 IronPort-SDR: KjskF28W0nR/WS25XNTIjZZ6MOUkA+qjyJCICU8v1MDLSSx+eflDL50nFr5UKFgR+r14v2xyzC iSLVvjd+8i8PIQtIm7blu+3ZrYIf8r3TRMa4lL69M50TGGviurYTWziXs0m6P+DcA9uiqt9DKS LCiEadYfFTABEdo8LOA7eaUhEHveIONnKcKTCyOQiysNTNSAkI3HRt+/A/kAVWayR23nNbJyPf c0GLKVyCp/3DK4bjuw3lm9Ja+pyKQsVcJN/wlEuV9oiO9TGGjiB/hHz0rzWQyCCsadZFB2z6ow YOk= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:14 -0700 IronPort-SDR: lAQlFwod1LolanzvJjaARoBCaCoqlzlJvddh/3MsACWNQGgD14eFzSLN0liv2+mcfhIC77P3CS 1i7vOm3aUOsXwXutLoeFQKJtrw73hgHopJDe51ArWDkDFNwHKprY9j/qv61HzysMLWNq25shOE ylF5Nu9ABGp3+xkDejsFGtJBav5gx4Hsxuy03mMTMqo0HfVvI8JihYKEedehepQ4Il5YXjmQCs OYEX1WwJukJjMHdMpbV6GqyvWS73AlArLwN2qD/OIOwugmkreMfF4mPgARhXOeBr+pacamAGi3 hsY= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:19 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 05/20] md: use __bio_add_page to add single page Date: Wed, 31 May 2023 04:37:47 -0700 Message-ID: <8b046033b3b073d1ea91c45cd278b7aadd0b7e1e.1685461490.git.johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 19DA380010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yu8188r6ba9zbqjnhufxa3jcap99gupj X-HE-Tag: 1685533102-497810 X-HE-Meta: U2FsdGVkX19Wq28BduYQPksuIoi5tflQdZnCvU1tpsQseo84qAqEhkocQvKrojjya0S+7M8VvlbAbFeo917fVYDXJy4ejaFH/u2Rhmrk8iLdRZzaIlTSQNAEWm1/vNEcGj/hrZUqyzxfjjosVBbBTVa827RSqy2t97evQ+VRLW54iDR1m4rBDUAfIJHu8ufXR2vz4iONRThfLhByw2FIASOwkts0HCGj7lH5aF8IsXSXSog93WUX4/Ejb5+sqMAkYUoz3eDjSmUQ6pkPGlYekXpVwLB2xXuSjc13R090LQPHhqU05wEqHc0BMOzlHU9bwZ4t6dUsyL6dysnPgfmuIYq2C1kr++oH/1MBTXL1EtQFiZm9Xa+3sp/LV2899kVdm016V96PbZ+dhFrQe8YvuoJAy/updLXLA1JyQj+/U8seOHbCeCSBKBTImDNYZ/bdEoG8Zz1KkvX96tztEqEY0jHfmql7w8l0eWYT4JluBBionbs8s0SS4WupftjJb3PiALsj7OiBloKZX6bmfG38x0X4LbFRQR61koLB/e8pJ8L8Q4ZgbOY8/5+saeQdFuQ0x+oyw8aP4OJ1KM+c9TyuDdtt0rSLHPgf+EO0LFOSbzz8UbdXKJk6tseRyg1XjRp5ncfTLGx8XPbubNwDtt9WYzTPnpWRfBOwVVvSHxrHu7dWd10aLYlUBKdefNWGtGtGNqb4nl7ywsU/f1uyoqM5mE1Pe9KjvtUZTcr7qAun34hsLM5gr41jFW/lBr/zb0TW7Pisp3uNOpW1U3hJsFGDTCsnIunvKmXsCrr2s4CPzql2zg9GK4w5Ucl5gX3ey1C1sW7F8JXapfeDqXNjnTC4Gpnq/hO3YPHFmD/FNy8KiZg+ENpe1wILBGgigTDe4dJ7i2qdN9Hpm19+6AvS/SCJGRHO6FhF00WtYyd0veQgUmvfreLXcGxMsgmFuqbowgVE2si5gC++x8R94wjiOIH aQZYOxWS zxq8J7h2LYnowOrlg03r//V2f8kqVw6v0oP/a7PUKpC0NOspwBMdcIkdWDA0qO6QpEqvXofJrVxqWezpzUtDoQpijN35pjyNT5YI+uRttyu4+iY80Qq17kAbC1OFnYDm52Iz7YHoy7UZJw7aTD1ShcD3DjUS/Bhz0KkCxzP4l+XtiKQjq/6Gg7Ks37vGL880VJx64/XRTyHimc/30YeJ4MVoi+cnhziZaYOsgTt44oDfkxGkV0YwePf907s1filxtQlJGiGkdKoAUx52J6f1uXLdJ21mttGnWsQ46xnCBhuzM/PN0XGEQg6ATHfkCdmY5F7iCujb5VQl9VrS60INz08jopY2jx9orrsNg7X6NVBYc2jzK/39zrxeF1NuAIcjZTWTHRAhsz1dg7sYccrYFh1Llw1f5HumNpWz9I6cH3TBfp6n+YOXk454Ys+yLa80dCZBm2cH+kM1A/XU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113747.buXn1xC3CLOGpLLEQZITHpUSpCT6WvQus3sxLGEHazk@z> The md-raid superblock writing code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Signed-of_-by: Johannes Thumshirn Reviewed-by: Damien Le Moal Acked-by: Song Liu --- drivers/md/md.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 8e344b4b3444..6a559a7e89c0 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -938,7 +938,7 @@ void md_super_write(struct mddev *mddev, struct md_rdev *rdev, atomic_inc(&rdev->nr_pending); bio->bi_iter.bi_sector = sector; - bio_add_page(bio, page, size, 0); + __bio_add_page(bio, page, size, 0); bio->bi_private = rdev; bio->bi_end_io = super_written; @@ -979,7 +979,7 @@ int sync_page_io(struct md_rdev *rdev, sector_t sector, int size, bio.bi_iter.bi_sector = sector + rdev->new_data_offset; else bio.bi_iter.bi_sector = sector + rdev->data_offset; - bio_add_page(&bio, page, size, 0); + __bio_add_page(&bio, page, size, 0); submit_bio_wait(&bio); -- 2.40.1