From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9239C77B73 for ; Wed, 31 May 2023 11:38:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ABA76B0078; Wed, 31 May 2023 07:38:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75C866B007B; Wed, 31 May 2023 07:38:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D7406B007D; Wed, 31 May 2023 07:38:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4924D6B0078 for ; Wed, 31 May 2023 07:38:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DF8DE4039F for ; Wed, 31 May 2023 11:38:22 +0000 (UTC) X-FDA: 80850352044.07.39082A3 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by imf30.hostedemail.com (Postfix) with ESMTP id E5D1E80010 for ; Wed, 31 May 2023 11:38:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=LhfMnfRX; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf30.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685533101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eoF6iuNNlEmd2vTdAFbwRg91T5G4Yt4OJwZs2LN0KKg=; b=fafQfgLeJIWzaUFL/MhZPwhRuCDyeblxgWuyBxgmG33l8ndTQSbYvK0Rf1SvnxQyxkxI7r AweZcP6Y/xZhEhtFfeMpA+qnP8F3p/THu0Cldppsl3Itq+u5GscXHvkZzibf7dkJch7H4P 9vd0uLNr8ZYCbL33FP0M0+BF3Mq3wCg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=LhfMnfRX; dmarc=pass (policy=quarantine) header.from=wdc.com; spf=pass (imf30.hostedemail.com: domain of "prvs=508ef2a02=johannes.thumshirn@wdc.com" designates 216.71.153.141 as permitted sender) smtp.mailfrom="prvs=508ef2a02=johannes.thumshirn@wdc.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685533101; a=rsa-sha256; cv=none; b=m1kAUNSODRQczkzLRHlXMSmolwH+W3ggMemFNcTbRpEmrm3+Sy6YJxLV4zIRRqvQIIir+n oqQw+C18l/Qlpt6j3XJ7Lc1fWgPp+lFo0Ft09Q3y0yHBb3z8VXrahQlPOlT0Bj8voveeoK UVzMHzNhGEW0LO0fGJeR3/PfaLc4uxg= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1685533100; x=1717069100; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=asDmkxFBDABNDNnwDePSoyQARa0UoC2pBVbkyHt1eyc=; b=LhfMnfRXfffi6uE1CzBNy7iBY7nC5/0xzcH1ix6A1kN1ITuleRpXBEpp K3U9Oh4hxxE3emmYPk5lP2w1nVgQidsjcUcSLITv7vEl1AJhCapK5niTW Hx84UDHqECXXMaB9fTXA/C1MNGf6zeH3WW4pOUZvCVS8OIJZct+uC6Ii+ /pFIaeXq4HkK37+tGQ6UR73TxpNR+FCB5zzoOJr4L+1RNAFUvxRYRYKYh OHvyUWCTsfOLMver3J+TjznUTbHCovwgzfbizZFZrqG1IWn8mvgjOFMJX GtFZfVpNAWd97kU86HV5BB5keZk5ALKjc9q1/fugNRPoblAeR80n982pz Q==; X-IronPort-AV: E=Sophos;i="6.00,207,1681142400"; d="scan'208";a="237001299" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 31 May 2023 19:38:19 +0800 IronPort-SDR: tRuTbSZkSJ+I3dqTIyVFx/hUOAoknZirqBvBASMr6/heJx26JiVWL986PReViuKE6KDpxAhftW cU4f4/4GavqdlLMtMGSJp/TuQE/NeNIMXbNLGYFh3pDl9tqTUOhDvDZM6QSXc2DCuxmwNTgQuK OeFKKREqD5+ypRQ8l6sjHATOiRDktKIEvVI1pcpH1Afk+rw/HlsPuD2edBNm+yu2qqsXPfPyJ4 krALUVIwAw79WEEfk6EqwUSo0hlZ7Knfr08Fq5PK0DZGVXZU9WmLVEaNrgfFretj+4jPvAHipA JHo= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 31 May 2023 03:53:11 -0700 IronPort-SDR: XC7JyXZtD1AEkO0rA/hRbgeGcSTw+VmUUN99NBXvCxdDrY+InQanrPuCKDB7CLC8eMRPlGmNC3 QiP8gcRERHHEIG2OEk87W6d/a8pDEb9iSfZ5KR8Ewslc87cWwPB67fwIXQHbcXxPIwG7ZTiBzn UT3zWjl5Bm65XKzrDX228nUzYwsiSEBs51Wqjf1alb4Y4TWnkLeV2j77LU2xqX04I1XVfiBigu 157hk7ifukR1InqLyOYwym+YXVQDfpTSDWIoWJGKIyijkdJoXxA7tfXc+of8uv3Y1diMJUHEdy z60= WDCIronportException: Internal Received: from unknown (HELO redsun91.ssa.fujisawa.hgst.com) ([10.149.66.6]) by uls-op-cesaip02.wdc.com with ESMTP; 31 May 2023 04:38:16 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouha7@uniontech.com, Johannes Thumshirn , Damien Le Moal Subject: [PATCH v6 04/20] fs: buffer: use __bio_add_page to add single page to bio Date: Wed, 31 May 2023 04:37:46 -0700 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E5D1E80010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 73fahk8onfrt14u3s7jmx4utpn4do64y X-HE-Tag: 1685533100-154281 X-HE-Meta: U2FsdGVkX1/LPS2CnsnjGVoHiHyzhsXzseqT0eMOcu6xMpUQ1xxP8MMXmxtIJAKnGxrJO+BONYlLsWp9x2Bq4mq5A9f61Z3nRGhX2WvnQl26yZGJqMUXhPOZYpDWGU9U/Zwav6W7HK3a27KdCPgmvQka7iT7Pr9RCAF20xh0+vsaXQZ1nWbwBUFcciS2Gsy1RuyqAqesAsTeT6KQHZlvBr2JNGL730hGrAgrTuffzueb99lxvTkt+3YYyhWNBWLXgYTwY+hdWy7F1u56on3aIO8v1xKUCPE4s+05B6t6sTVjjDeQT6XE0hdpBdamS8fYLYTE3zSDf5JZcAm1Qt96wAEszGvRVsHpVK67dy7+rVNnKugO//bfOEzuHYlh8qaQJl31O2K/JQm70pOZEyzvWa2mHYK7DcGfHjpsKBY0g2cXXmxqOpcGa5ysJ+YFB6sM4LH79MGG9bJqyO8Oh0Z0cqte8aKvfb81yAeE8pMrJO2gCcxSX8m8r5tpdLqkzKRDLTCkZSdhX0JezorCTzFuxjMDSyUx6T03x7invbV+vZjhleyAlhkb1y197JFiiwgIBeODsj6GGoImkr3J167q7BogaFc6oK2qW2MKWXUo/pf5PoMxlYJlqnX6p6DdKE35dix9gnuErR/yUo3yQbclg5sstgidR6ZYwNeNEq56MeusHeF/Kksns3TJKUb45/NnsC527oG4RpIibUjscLpwsqTyWTT6wodGek1WbcJgPMn4/0hVmMWTV3liGvu2shBxRizgwe1Df93f7H8U2QqSIHAeKbBYYrtb1NYykaHxO67Z0HiEZBfERNDYeecjUnGVihhCVHoEM1HYNF0z6go1fTpE2y974VZqPRRSgx82Oz/v2o2fvBxNcJmKz8XxDSk774TAP9XH9iSNbFmrmpmTbKfGyBOL50BxGXFcWhl+BW+hJg2v3I5fjNlilvq/euvn742g3FHkzMhLH/kLm0P 7rLJ379Y kam/TAidh0rzrbsS3CIEYUF/FAOWXDs2e/eNf99lVHU5jKPEDppqWxOlDLIzfzLTeVjchQsRVuI+L01yoSa7cw4G6kWcny6/zefZwHSBGqUVfaS9i0XX9+J462IgtzpDvR/Vp1NIltCfR/HB5wg5DLA6RNMst9ly0so+BR0Y+Lfg70ozBRNqE8e+ebVPcpAJsQBPKNRbMH4OgMu8LneuKKHIiG4q/4CDuViytmN0AiZmEJTSzowt09YvkaE9OVfR5S8dcnwBL9KQUV4QCWrfYWCwK+cAlYeKJNEUZtG4vsxg0QiFRTvDvKVGDMsJIIltDJTm99pxXX9XiGONfubtYVF4+428lJ3zDJRTJVdeNZ4lgZ2+D2hIg4vqh3GTMhDidptvy9M3hH75G5zpEMg5OhVH0O2WdD0OZsYYN9Lje+s/xonvMZHiGQrRdWvSqyN1N6C2G8dgsnc9HHiNULj7TXCuGdQl+Le8Zmg8AsF2TrnKKeyqVSIXXi0W/C4Iss7dHORl0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Message-ID: <20230531113746.SYNqpwmfl2T5hhr87Cv_FlyjpUZCxws5kcqn5Qy9aPg@z> The buffer_head submission code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn --- fs/buffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index a7fc561758b1..63da30ce946a 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2760,8 +2760,7 @@ static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9); - bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); - BUG_ON(bio->bi_iter.bi_size != bh->b_size); + __bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); bio->bi_end_io = end_bio_bh_io_sync; bio->bi_private = bh; -- 2.40.1