From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B408C77B7C for ; Wed, 31 May 2023 09:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED6158E0003; Wed, 31 May 2023 05:58:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85A26B0074; Wed, 31 May 2023 05:58:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D75128E0003; Wed, 31 May 2023 05:58:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC2E56B0072 for ; Wed, 31 May 2023 05:58:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A406880254 for ; Wed, 31 May 2023 09:58:48 +0000 (UTC) X-FDA: 80850101136.04.8D1074F Received: from out-6.mta0.migadu.com (out-6.mta0.migadu.com [91.218.175.6]) by imf09.hostedemail.com (Postfix) with ESMTP id E275E14000D for ; Wed, 31 May 2023 09:58:46 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lvO7SWW0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of qi.zheng@linux.dev designates 91.218.175.6 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685527127; a=rsa-sha256; cv=none; b=FP6kvq+8VANjXIwgigfY/jIEhudeEga6FsMRzbktyx4hzJAswxIrVkdp9su738ymhhOqNW MQZNP6ZfxF4+N2YvF0rbkmZj1AbkuDCj4grTUMvx8uhZvo2Dc3JVEg5aWHmUOsKoXIxNCV VkysUaUN6mBBqFb2G6eiUzxFKkznLzo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lvO7SWW0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of qi.zheng@linux.dev designates 91.218.175.6 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685527127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cNetM4XBa/Gbuqkaq6l+2vD89eQsIgmLTdtu3cv7dk8=; b=KLLC/4Jw+29Bw8GEhcQEWTcso1hUcJa4cspZwaNMSGFlwY4hbo8IVibfYjPmRUQloCDYo4 bxjexNE5O6KqId8pSGkqm3Wj1fVj6k1Xzq3D4YabbO+D/q5QOQ1DmVvIvafwEAYtOTPEPc EHlmRXg9Hb5ZLkMrCzJkGnTHPq8dmy4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685527125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cNetM4XBa/Gbuqkaq6l+2vD89eQsIgmLTdtu3cv7dk8=; b=lvO7SWW0g6amQil27w7Ch1WvlKqI4Syaj9ZKVX28hbNP7t8j4/5bAKuiTPnmEYRwcznnpM FC4tcITydxIA3hqHO31xf6p70DR7WKVF4bsUNWyhiAhBcj85YqAuj7QvPpCBdGQUEYFJeW 8/DXDI12VzN61sf4+h1P/9MfcFO1sIc= From: Qi Zheng To: akpm@linux-foundation.org, tkhai@ya.ru, roman.gushchin@linux.dev, vbabka@suse.cz, viro@zeniv.linux.org.uk, brauner@kernel.org, djwong@kernel.org, hughd@google.com, paulmck@kernel.org, muchun.song@linux.dev Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: [PATCH 7/8] shmem: implement shmem_destroy_super() Date: Wed, 31 May 2023 09:57:41 +0000 Message-Id: <20230531095742.2480623-8-qi.zheng@linux.dev> In-Reply-To: <20230531095742.2480623-1-qi.zheng@linux.dev> References: <20230531095742.2480623-1-qi.zheng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E275E14000D X-Stat-Signature: 9cdibu8waw1em7cjd8iderhdt3ckka1n X-HE-Tag: 1685527126-21962 X-HE-Meta: U2FsdGVkX1+1S38oPeinIYyMt5pj5q4WaO09zKiPZQr/BXz4Mmu6JU/cCkTDnxLHizO8QWhVPVrGXKE85Gz0llblCDKwxNriwM7b3RCD5A2tam4VhLD665AquXM6xgqUfwrMlRakRg1uDlmPm9+LvPU8TYwUe7R7pbJPREBQ9n5cV43zSGSDCFAqwFyZMi3moQ2/5y9e4eyLxn6G1TgskvKAlMPvt1w2ikEDueb0jUDdP4g73jtxV086bPWqATHHdz1+W3ekCk9HFXBMNt5wC0htQqAQKD14gT0NrgRekEStWc3+MPTd11sxSmYN8xGAiBBtldT5FRN09AabR7yvaj9swg1CEcq5rxsSAKURQ/+vzaObyHU9Fe4yjvbbG/Ay3QeZUyQcIe/BRMSORzK2ogoiykTPOAed58bpJb3++TzWUpaJwPzdhgxwFauIbNG3IZkzXzUAw7BNeXkL5zYLHjD9+LdMdE4U0NwsjtdGsvWoa8IBS1LcbV4cqUzt/Wy4smXZ6HKNtugoYrRJOsuv+q6oLhAvJF4MjC9Z1WBwKc1ymK2BN/iP6yLSrtVT0g+BsTBQHNxbzOZIgWoMH++8xaij/OCkszS1GTpu3LRoFKgHAQEPVsDcJugxBb6gwtNd+6umEqQwGpMfF9XFt3mCcps60193t0eShi0u1ubR9OgLauzbOGfpvICPFR1dpfOsxJ3cVaP3ZKelCJWTJC6bB5Dlws6B2e/Toekr4rKJFSL2IE/MhN4GLlyobDyDuQeBFdyvjyMEd7lJkkiFQzuSKXpdJD0GboWzcSgAFMml+edOrr19m6naabAmvGQk4rvXE6xJ+A26+B7VuXbKdI4cZKU3C0u+9/OXbbsvdSu2HeKFniuArtkujja2+wNYt6/hYherquE6uVUO889MY1vnN8Dt+obJ4cWSRHzWF7X9T36+S6EHqZ2V4qxgc0vpVs+4GMteTRD7bi1a2LXqJKD hiz35Mv8 hFDP4hSHGxGypAKY0apv3pGwI6x6rr6vSQFvPFVCv1aV6ymav+hv4qsNW/RL+zaPFTs0pMKqn3QTEOWVjVmyjsbVapkKfIqwJkBP092r7z2ToUlSLZ1GxBh8UgVZKqiF/EMBZGnSOCbAvE98yavmzymf1ztwbblPfmpGRuQkNDa5uYs03VWIO7U77ro0d1Tx91QK6AyJ+ZeAF1WFqh55S2VAKwkQhV4wp0Sr6UnqN3HKrGewLqr6FrrzmTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kirill Tkhai Similar to xfs_fs_destroy_super() implement the method for shmem. shmem_unused_huge_count() just touches sb->s_fs_info. After such the later freeing it will be safe for unregister_shrinker() splitting (which is made in next patch). Signed-off-by: Kirill Tkhai Signed-off-by: Qi Zheng --- mm/shmem.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mm/shmem.c b/mm/shmem.c index 71e6c9855770..a4c3fdf23838 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3930,6 +3930,12 @@ static void shmem_put_super(struct super_block *sb) free_percpu(sbinfo->ino_batch); percpu_counter_destroy(&sbinfo->used_blocks); mpol_put(sbinfo->mpol); +} + +static void shmem_destroy_super(struct super_block *sb) +{ + struct shmem_sb_info *sbinfo = SHMEM_SB(sb); + kfree(sbinfo); sb->s_fs_info = NULL; } @@ -4018,6 +4024,7 @@ static int shmem_fill_super(struct super_block *sb, struct fs_context *fc) failed: shmem_put_super(sb); + shmem_destroy_super(sb); return -ENOMEM; } @@ -4182,6 +4189,7 @@ static const struct super_operations shmem_ops = { .evict_inode = shmem_evict_inode, .drop_inode = generic_delete_inode, .put_super = shmem_put_super, + .destroy_super = shmem_destroy_super, #ifdef CONFIG_TRANSPARENT_HUGEPAGE .nr_cached_objects = shmem_unused_huge_count, .free_cached_objects = shmem_unused_huge_scan, -- 2.30.2