From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE8FFC77B73 for ; Wed, 31 May 2023 09:58:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5126E6B0072; Wed, 31 May 2023 05:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C30A8E0002; Wed, 31 May 2023 05:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33BB46B0075; Wed, 31 May 2023 05:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 26D5B6B0072 for ; Wed, 31 May 2023 05:58:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F11D21C72C5 for ; Wed, 31 May 2023 09:58:23 +0000 (UTC) X-FDA: 80850100086.09.7B6D6A8 Received: from out-11.mta0.migadu.com (out-11.mta0.migadu.com [91.218.175.11]) by imf25.hostedemail.com (Postfix) with ESMTP id 297D6A0014 for ; Wed, 31 May 2023 09:58:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sxRHWVlL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of qi.zheng@linux.dev designates 91.218.175.11 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685527101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lnzxWyBrjsXVofp7h2XNt51t4g+fsU+gJXs/ea1cFR8=; b=q4XWrzEum9+ZTZC5hV96/aqxsYsxs9RrVoYH15ra9IT8q6c5qTclW6n4HrTSVsAgJpRJB/ RzTRUz/2tEKGH6M4JwXMGWxbzJkX3ZcmpaW9uEoBWhr/DmRyDaOiHIr4JvZFdeJhLYr5AH KxdVzuHfugrd+4f7PSB1An0Ms9Zy0jw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sxRHWVlL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of qi.zheng@linux.dev designates 91.218.175.11 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685527101; a=rsa-sha256; cv=none; b=KmSeh7XiQkM+cEP51SdGrLXCIy2ViGdsSISsR63yh+/9kxcel7OWDHFKFh/bbkwemNCURw F+r1ScTAnC4hQKvYP4WTGJMraILT9mec9DBN9pKiIFbEgBHcZNja/AX8c8G3869zlyVTj7 PbYR5Frw9nXMuehnIVD4ED52Mif7Otc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685527099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lnzxWyBrjsXVofp7h2XNt51t4g+fsU+gJXs/ea1cFR8=; b=sxRHWVlLu+rreVBFxwIJMsPglUs7BP6JtCkUt3t8Jj4/N9ua1Q2/SjbYdZXtKFG7R9C7pt 2t9WN+oDIJxf1PqTSf920IDKgkWQRBFGYeyKYjIsrWLrD8tL2dxfTRirVmdU/LhybNhnyd QK69UVOEAmxZHnZIIPi+vT1ngAY56cU= From: Qi Zheng To: akpm@linux-foundation.org, tkhai@ya.ru, roman.gushchin@linux.dev, vbabka@suse.cz, viro@zeniv.linux.org.uk, brauner@kernel.org, djwong@kernel.org, hughd@google.com, paulmck@kernel.org, muchun.song@linux.dev Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: [PATCH 1/8] mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu() Date: Wed, 31 May 2023 09:57:35 +0000 Message-Id: <20230531095742.2480623-2-qi.zheng@linux.dev> In-Reply-To: <20230531095742.2480623-1-qi.zheng@linux.dev> References: <20230531095742.2480623-1-qi.zheng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 297D6A0014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: a4wmc1tf7xyaa1endqqbr9ogrp84pd5z X-HE-Tag: 1685527100-480301 X-HE-Meta: U2FsdGVkX18kJY+/UMRikFUIicF5tJ2LQnYlthKAusWQvk/qBpShapp5zz3H5+ryE6HbvxaLa0Imu35cX6+Cq3dxqMjlS/vCuQ2tapBGvcfVRV3yo2cvlM7YMZzJWLXsM8L+M5SFrokpP2Iv7TLAvZfQALxoUqInOtw2xqvOHx9qV+rbPlt1EI7Nr7LL1ImT5BdQOFfJ8ZmG5nmgBkPD2/aj0H3Me6xFzH6yVcijAXRsN5UsMDxR5WOK470WxlFBPDverP4ZAMQY3Zx80pt3RQ06KsZjHUvNRpkXlhZVjtzF0AQHGgxVZLzTv63ZF1bLTjYOdScQqelOR+tNYx2Rbpxd2p27nhAFoFhJSAeKocanX5ooHsbujNhKKY+mD3VghW1jEL5RCvXHQObhnf2GBNCzbLlH4WoaLI17vS2Tl0YFzkEodXAkcZKueUlKod4Gb/ZM0O30f3awIUU5frlGkBnrbdACyHodqsU+ZmC2CR2L6slqLN2zdfgIgYFn9a40Qd9pA2DR64lnLjKSPdB7NOE1lFtsI/XQs6HoE7FNEpDmrcmd8P47M8gr9juZrH99Cq3jteYEUM/EIZeCyxkU98kHTb664/QMSGxeaRLHSf5BiAGAnKv4yXkAnFQ0fduwiOay79s7zWgcEfRejpMtI+jwynA9Cs4wswJvwnzV2dwFyWf1s8S+WlK/XWjLh8CBm0aCQudQOwAeLDGj19QlKE7kCL0gpRUqKo2QgQYaehCXpXXlu9bth3uKghZ/ogBg1NMR+N44WXpZwhNKc5lHjDp/L3KBUc7wMVGEBUs1j37+lZOYIJT6hm3CRgfU9/UwB1kv/9eLieuLH5+dvESSjeav68Fcc5/laeQdrYqVMo4qpwN7ZDjbXii2xIAJxDmmpLnNcB2mhQCIboRdALN4NeICdy8MTDS4arS7RqQ8LgS8Btk8yLmmGYy8Q7A1/wiRF6z6+RN1caAhKpzxxdO BIYiCZY8 YtNgSpYRqUJUJFNiaR6i4Css9joYydCHVJlTaZSinQGmI/J+0EnZxS9FIMbe+B4Fohc6Shw1WHJcz9peXs35FyP3y0JdCjgPh5DnFGSKyTw0GWEe2jD15P8p0bjKvWc7wWMYDQCsZAduvflM25zdT3NzcWHRLH9pSnD73Z30OKXEPjBUMjvEs/Qi6Lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Qi Zheng The debugfs_remove_recursive() will wait for debugfs_file_put() to return, so there is no need to put it after synchronize_srcu() to wait for the rcu read-side critical section to exit. Just move it before synchronize_srcu(), which is also convenient to put the heavy synchronize_srcu() in the delayed work later. Signed-off-by: Qi Zheng --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index eeca83e28c9b..a773e97e152e 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -818,11 +818,11 @@ void unregister_shrinker(struct shrinker *shrinker) debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); mutex_unlock(&shrinker_mutex); + shrinker_debugfs_remove(debugfs_entry, debugfs_id); + atomic_inc(&shrinker_srcu_generation); synchronize_srcu(&shrinker_srcu); - shrinker_debugfs_remove(debugfs_entry, debugfs_id); - kfree(shrinker->nr_deferred); shrinker->nr_deferred = NULL; } -- 2.30.2