From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774BCC77B7A for ; Wed, 31 May 2023 00:32:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12CB7280001; Tue, 30 May 2023 20:32:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DCB86B0075; Tue, 30 May 2023 20:32:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC09A280001; Tue, 30 May 2023 20:32:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DE70D6B0074 for ; Tue, 30 May 2023 20:32:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AA6CA80380 for ; Wed, 31 May 2023 00:32:58 +0000 (UTC) X-FDA: 80848675236.23.DCF8D9C Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf12.hostedemail.com (Postfix) with ESMTP id F28AC40009 for ; Wed, 31 May 2023 00:32:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TawTdME8; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685493176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9bKCXPHe0YOuABv6i7qr9SVnl8HcmD+dM1abPDF8sOo=; b=fic5fGgbEhC/VjU3YZPwbxrhMzBrUXLcTA18wSajH3tUNw67XxvrCtaYsOgi88la3rfnyl Yo6qa8+htJGws5dX9gx1/LR9KkBgK+2smFkEsGKMi3JGMlp2r48Sv1naCx+EUSzAMjsgtW dx6XHPY3yx37TVUk8JB+CmFkh0HXw/U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TawTdME8; spf=pass (imf12.hostedemail.com: domain of lkp@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685493176; a=rsa-sha256; cv=none; b=qJaSlShrW/m99KkSOJzAe2FrXj0Hnjmmd9fKyetoWhRQXdE6R8/JUxGMxjFYPeg6iq9qf7 MoXZ/F5jKCUwvnHlajlO0A6a/cBm1jhmKlqEgeIHmubfsaqBVHbK6afOmYfvEzfoCt6P5o H6ByKZntVaGQH9z64SalYsoWVTAUDOs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685493176; x=1717029176; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5xEeiekejREC8LvTn5bR/XyYrA71WsI2XilvH/Jg91Y=; b=TawTdME83j4auhqg+y7tohyXGJKmMo0Ssg5z0qUBBKS9R5AGTPFe+fNB sN3c0kwLXXfxr8fgketxYYHPsNnR+Jl+VXlMy7UCMRraELLLG4Gs4p2EE 7E5yVDY1km/nrf4khtoDXgYAqyZF4iXHPUPp0xC+gIEv3Mc77CnoH3aiM 9hfyTfZxIk6WJjtgTMBPqeaK9ljoRvUx5ADudoOyZkVESUBJEpnvs3U+U BKvEPrdaBfdc9TAvPvxoMw+oIHeEWG81b7HU4kBQEfQ7y4ftwnra1ntgV yaQImknjrmeSt++4Uy/n6D7McRsuA8l9WSLeO8jlbK6aFf+MkmW3sPMWZ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="441445155" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="441445155" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 17:32:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="1036803686" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="1036803686" Received: from lkp-server01.sh.intel.com (HELO fb1ced2c09fb) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 30 May 2023 17:32:50 -0700 Received: from kbuild by fb1ced2c09fb with local (Exim 4.96) (envelope-from ) id 1q49li-0000vz-0c; Wed, 31 May 2023 00:32:50 +0000 Date: Wed, 31 May 2023 08:32:26 +0800 From: kernel test robot To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@rivosinc.com, Alexandre Ghiti , Joerg Roedel Subject: Re: [PATCH] riscv: mm: Pre-allocate PGD entries vmalloc/modules area Message-ID: <202305310822.dhnyydJC-lkp@intel.com> References: <20230529180023.289904-1-bjorn@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230529180023.289904-1-bjorn@kernel.org> X-Rspamd-Queue-Id: F28AC40009 X-Rspam-User: X-Stat-Signature: 9msx8haydtyex4try85165ztixy3gfey X-Rspamd-Server: rspam01 X-HE-Tag: 1685493174-724579 X-HE-Meta: U2FsdGVkX1+TtAXRnRtJq8eoUje6tHXZnO8zE8A8Df66F7xqcDCpCsX0PTLkhyS6Q0zwjH2W0nkWw3MZHbl2TNbe1jt2WZMuf4k3OO6+su3V4LLmUi3J7gJMpQp75n8F2Q5TlxsAv04MgO9ik5irteWEi4oBs5dlozvhwPn1Ie2EzONKraNv5Rl0OisLundgTeg5hJfDmu/Gg5CW6COuhzXJgGhQTg5hqhkHlGI9t98zG6Br7ZpFwGnQwNTh91mZhJwdF/wXSgqN9sSZA8XRJr+nf3SrVXunX8pIdyNHZx8jBdlNbjevWbpTwpcQv9e8CgA50PeDnO0W6ulEOaaA+7yEerhbBIP0NxEXE7dWNjobftIW1IzA3CaoWnwj4eIre1pFi9qMQGAmUMbdHA4WZ6as9TLijxoc98ZiYyn9KQv7cTpysT50bZ9wWTtqt4fZpCClX07kzbH2hCjH28adCJ5XdtHbg/lqn2GlQIRcq1Q76m4rfk1gKwNlUCVE9qLBO3K+IVXU7dVqXp8hueKlA+17n1bpHLybO7wNP/T7nygn0tiQmL3QbJolXKxZD/CQjPGP1dJ/iADPJrJgTMKi0bIf8u6jSXu8fRHkZ/MgfZroFKbxIYG9yLtrGJ2IvN2miU2UX7gpJASTRwV8cHL9h4gnNDWqCR+0IsPmYdpchxPnPaDaKfu2HHPw6+sYQe6z9+6eZGERyEEGNm2xpC+O+jPBWO58ulgMKuxjNX5oNJ7QoSVeAzSKhQSDzY90J/doKZKCXuT1ieOSpSyUaCCflmcWhm7KgIOnJ6S290JsnytRgmeUdZ+5bVlXpgnYonGN/gHK5PzCK02l2NuN9AKvVl9cv5jckTEuIX/l9HE4i6AmNILq65uOwYZN78SBWeGoEgEmlwl9e8hDwFYSb1UV0sjxATbKunzoekM8L9Zy2aGT8jBIPd2GV9HHZaOFOPN8wUkooHtF3fPUJK3fk4Z O5XsYsKa ehNfgmf3T2jT3suHowLl7xDZVkeOQhw+2F0pt+ZSPSsrt3wGvSJHEbeSPiJNN0Ojb5+ioFqtFfXivwRd3xVviQcLeCGRX9a/MImXjPnZMzqXCBc3bOWf4F/YTQDutv6+dp4JnRTqLWZeFGzlVScLbTrr+OmcP9JUHPBAjHO/FUBbx+k7ZSmDY3v9t+bs8p7riVx4LoPA+5d4HWa87tF44VZaOZsXabY0fbrUcrraK56z2zdd/t36r5672sgcON8aCFVm6med8+GWx1Yzi7zlVIoO7qCDcD05OeyRKhSXJe618Zzc40IfsIicmvo3DlHuB7y4reTB2Qv52daLUXRGxlQYTXwVBmiuC3pPIelWghHCmgNDAdzDjueNH3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Björn, kernel test robot noticed the following build warnings: [auto build test WARNING on ac9a78681b921877518763ba0e89202254349d1b] url: https://github.com/intel-lab-lkp/linux/commits/Bj-rn-T-pel/riscv-mm-Pre-allocate-PGD-entries-vmalloc-modules-area/20230530-020212 base: ac9a78681b921877518763ba0e89202254349d1b patch link: https://lore.kernel.org/r/20230529180023.289904-1-bjorn%40kernel.org patch subject: [PATCH] riscv: mm: Pre-allocate PGD entries vmalloc/modules area config: riscv-randconfig-r042-20230530 (https://download.01.org/0day-ci/archive/20230531/202305310822.dhnyydJC-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9383adbcdfb7f850149742579615e8c174328a78 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bj-rn-T-pel/riscv-mm-Pre-allocate-PGD-entries-vmalloc-modules-area/20230530-020212 git checkout 9383adbcdfb7f850149742579615e8c174328a78 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/mm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202305310822.dhnyydJC-lkp@intel.com/ All warnings (new ones prefixed by >>): arch/riscv/mm/init.c: In function 'preallocate_pgd_pages_range': arch/riscv/mm/init.c:1381:30: error: implicit declaration of function 'pgd_offset_k'; did you mean 'p4d_offset'? [-Werror=implicit-function-declaration] 1381 | pgd_t *pgd = pgd_offset_k(addr); | ^~~~~~~~~~~~ | p4d_offset >> arch/riscv/mm/init.c:1381:30: warning: initialization of 'pgd_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion] arch/riscv/mm/init.c:1387:23: error: implicit declaration of function 'p4d_alloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration] 1387 | p4d = p4d_alloc(&init_mm, pgd, addr); | ^~~~~~~~~ | d_alloc >> arch/riscv/mm/init.c:1387:21: warning: assignment to 'p4d_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1387 | p4d = p4d_alloc(&init_mm, pgd, addr); | ^ arch/riscv/mm/init.c:1395:23: error: implicit declaration of function 'pud_alloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration] 1395 | pud = pud_alloc(&init_mm, p4d, addr); | ^~~~~~~~~ | d_alloc >> arch/riscv/mm/init.c:1395:21: warning: assignment to 'pud_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1395 | pud = pud_alloc(&init_mm, p4d, addr); | ^ arch/riscv/mm/init.c:1403:23: error: implicit declaration of function 'pmd_alloc'; did you mean 'mm_alloc'? [-Werror=implicit-function-declaration] 1403 | pmd = pmd_alloc(&init_mm, pud, addr); | ^~~~~~~~~ | mm_alloc >> arch/riscv/mm/init.c:1403:21: warning: assignment to 'pmd_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1403 | pmd = pmd_alloc(&init_mm, pud, addr); | ^ arch/riscv/mm/init.c: In function 'pgtable_cache_init': arch/riscv/mm/init.c:1421:45: error: 'MODULES_VADDR' undeclared (first use in this function) 1421 | preallocate_pgd_pages_range(MODULES_VADDR, MODULES_END, "bpf/modules"); | ^~~~~~~~~~~~~ arch/riscv/mm/init.c:1421:45: note: each undeclared identifier is reported only once for each function it appears in arch/riscv/mm/init.c:1421:60: error: 'MODULES_END' undeclared (first use in this function) 1421 | preallocate_pgd_pages_range(MODULES_VADDR, MODULES_END, "bpf/modules"); | ^~~~~~~~~~~ cc1: some warnings being treated as errors vim +1381 arch/riscv/mm/init.c 1366 1367 #ifdef CONFIG_64BIT 1368 /* 1369 * Pre-allocates page-table pages for a specific area in the kernel 1370 * page-table. Only the level which needs to be synchronized between 1371 * all page-tables is allocated because the synchronization can be 1372 * expensive. 1373 */ 1374 static void __init preallocate_pgd_pages_range(unsigned long start, unsigned long end, 1375 const char *area) 1376 { 1377 unsigned long addr; 1378 const char *lvl; 1379 1380 for (addr = start; addr < end && addr >= start; addr = ALIGN(addr + 1, PGDIR_SIZE)) { > 1381 pgd_t *pgd = pgd_offset_k(addr); 1382 p4d_t *p4d; 1383 pud_t *pud; 1384 pmd_t *pmd; 1385 1386 lvl = "p4d"; > 1387 p4d = p4d_alloc(&init_mm, pgd, addr); 1388 if (!p4d) 1389 goto failed; 1390 1391 if (pgtable_l5_enabled) 1392 continue; 1393 1394 lvl = "pud"; > 1395 pud = pud_alloc(&init_mm, p4d, addr); 1396 if (!pud) 1397 goto failed; 1398 1399 if (pgtable_l4_enabled) 1400 continue; 1401 1402 lvl = "pmd"; > 1403 pmd = pmd_alloc(&init_mm, pud, addr); 1404 if (!pmd) 1405 goto failed; 1406 } 1407 return; 1408 1409 failed: 1410 /* 1411 * The pages have to be there now or they will be missing in 1412 * process page-tables later. 1413 */ 1414 panic("Failed to pre-allocate %s pages for %s area\n", lvl, area); 1415 } 1416 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki