From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF3FC77B73 for ; Wed, 31 May 2023 04:29:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69E0B6B0074; Wed, 31 May 2023 00:29:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64E456B0075; Wed, 31 May 2023 00:29:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53D6D900002; Wed, 31 May 2023 00:29:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 46CD66B0074 for ; Wed, 31 May 2023 00:29:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 229D4ADB1C for ; Wed, 31 May 2023 04:29:50 +0000 (UTC) X-FDA: 80849272140.12.16CD0FE Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id 63599C0023 for ; Wed, 31 May 2023 04:29:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685507388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZN7W/90O3kLBMc8fqaosJzJD80Vb+MTzvkpB3ZM7GuE=; b=F8r9wPG/Cv7UYN2pl0MFaFCdm44QQcUb+SmQm1fgPxvESpZrCf7PTZmBX/SU0AcasegnHM ux8dqux2FVnrIvQk7QuhkxCHGdWgra3pSsZLezSDqvhVJu9F6c0Yvs3e65ukmSqSZZKhtM ekppNGtYx7TArfmZce95qKtO+ss/Iw0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685507388; a=rsa-sha256; cv=none; b=tan9ZXTZFtwEOqwCgp/g1iR8894FAoEt/F9cO9nRBTpyG0pm3l3lvBFyQJ/+75RdtYGFTT f6wA7LFG/JScypfn9al0BB/nNK9NZN2VoX2IrnVOSMMz52nO4A2kky3acNb0n+1J7C7am6 jVWVjRbG9eqdk7FrbB4DZLpeRTc439s= Received: by verein.lst.de (Postfix, from userid 2407) id 95A2F68B05; Wed, 31 May 2023 06:29:45 +0200 (CEST) Date: Wed, 31 May 2023 06:29:45 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com Subject: Re: [PATCH v6 20/20] block: mark bio_add_folio as __must_check Message-ID: <20230531042945.GB507@lst.de> References: <3d45098a7640897cbace54713efe10d88b74c160.1685461490.git.johannes.thumshirn@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d45098a7640897cbace54713efe10d88b74c160.1685461490.git.johannes.thumshirn@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 63599C0023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d15rcn1jsigyp6zbkenb1xeyganfwjhj X-HE-Tag: 1685507388-773375 X-HE-Meta: U2FsdGVkX18JSLKmc72K1/ywWw82xe8AAj8E8cPCTHUH1vvJm+zBLP/ggVdKeewdYjro8r75uzRmuLcgFRc9LhAbGXxyQ1LWs72XgKxSaaycDPKbSREhFMd98xdmG+JfZ6gRokfzkULSECFgWWsNlCVUx0N+Tm4Z9gdIN9yPgTnSXDMqAh+O1cQ2/iVx6awckBHjIwSKTle8/6dkDB+Q2Cwh9ykrwhqtmVU2ivPG4v5XiIqMteB5h9ZossIHhxOrWlUUpifdTzm+Lx7nxy4kH4/j0/goKoIxcaWiEC/jk8uu0MEIEiEEQqXrJZJ9Iahp1DBLNN6KllNvs1Cc+zwNf5UA1gbiIZI5uN7MtOeJICSDEl0epZ0jdilzopuR/uOI/vUJmw+QuLIba3z2mK/qjo1VKT1Nd+Mcn51v/RAy7Q261RzHsm9cCoULh9l9CXZuwBgZKtlr7XQYDGmJVMUcgYgwaSJWqM6f+CTSqTOKUPG4cZDKTqEJc9j7xIFUtx1PF7vnpeJ+ln3RRBkDcqOfMg2vuMQEYLrqRNuJDMYTGfyA8id0+7ehe0ukgxb4pPDd300F82qS7nqhhc3qjJ8p89Hk++bvVcC1fRszBPgYRAp6sci9+AHDiLo66diccTUYKi+cEN07GJGNr8Mrfyei8hkY1/epStjAMJ2FUNiXTZhvGYpdMT3MNFvAdtfcw7FvDWWKBfwkuPTQqOj6ZvMU70gyibX7ojqy60uvoFj03vc4RD6ngZl/sEvJQxV/kl0BiB3C6BijMWUFnAdn0Q2I6EpqIsYST/T6fJ9xAqDE3G+gdg7X6UonBI1p/aGwlKfnM0Cyv0j48s2wh1R/uZuMVcwbeAiF56Y0M1lTsx8b71OhsA6Vzdu3yvDQKweFN7bYQsZM8Bofo+XEkcIOG9IbnuqDWyiGcDe/qb11y6tJPZR/Qc+80PPy1UH+dMmfPfsvj5yCGfQVaqS10F3J7w+ RNL6+IaK Oe4/MjGtKFyoEzT8NTn1gGqb3Ugpl0uQOu+CbV94tpR9UkzsgerWaRiyJMoih8e35HYs6PEB81dZE5idL1dgQN2wfu6rAuka5K+ApDjR7qOngRi+W5hUKFvSPJ/NuSm1kfhDz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 08:49:23AM -0700, Johannes Thumshirn wrote: > +bool __must_check bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); Please spell out the parameters and avoid the overly long line.