From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCF8C77B7C for ; Wed, 31 May 2023 04:29:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB9226B0072; Wed, 31 May 2023 00:29:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C68956B0074; Wed, 31 May 2023 00:29:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7E8B900002; Wed, 31 May 2023 00:29:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A461B6B0072 for ; Wed, 31 May 2023 00:29:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 74BA88016C for ; Wed, 31 May 2023 04:29:28 +0000 (UTC) X-FDA: 80849271216.29.A585506 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id A206B4000A for ; Wed, 31 May 2023 04:29:25 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685507365; a=rsa-sha256; cv=none; b=nrg2rWt4Xxqm8AWmg0ATlh55fn31xRhFLlI38c4Rhtahopgh++M/aZDI0xK/Eo5xe96D31 WhMJfxcr/5Dl+uOWLNTE6ygoLq3m6oO1IvZBACsTN43RXyddsezyfcCp4chz8073GiJifX n/N5q3nt/8JTI+BVBxHlEpMJ9iUzAgs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685507365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=leH11dwbOSmF0AKgzaDc/1q/H08+HHZZ+qxyef/EibM=; b=u5JFmAZRRsfQmizO/3+gU1+f/ggYfK/TTvt+QOFTy0BIk8+x/a7jnFeYEKcq+GlLh7LlvI LZjgXMohvgL+1Q/BWv0shXRKIsn13Xn/kJk1QtG7TayXm5rD2Jtwu8bSNtSSbquvnx2PUx 0bTH+3yzKM5W87zLAmw1+GaFJP+NUNM= Received: by verein.lst.de (Postfix, from userid 2407) id E36EB68B05; Wed, 31 May 2023 06:29:21 +0200 (CEST) Date: Wed, 31 May 2023 06:29:21 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com Subject: Re: [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible Message-ID: <20230531042921.GA507@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A206B4000A X-Stat-Signature: kaoedhad3adfbqcojheidjrm58t5uxcx X-HE-Tag: 1685507365-810717 X-HE-Meta: U2FsdGVkX19g7YIyFWdb9erfmJeyGx4CAyU07NPQTDKLem4XcXKfolhcbATZMrl94N2PDbMsMBUM0v/xQ2DFK1yaa1U+p/ndpxHGbP2jiuEjPrWkoB5GDHtMhlBdYXIb/tQfLnrDnbmrKJEBvvT3AqsevIdv8mNk8KGq+SZ9xunvZXbU07GxVC/cfZzDmOJtpAd6CYI0WliNN2PFMfGh6AR22IKi0eDV3oTSB6lapCpVYIBE/tKvhAZX13PNv5jp36b43Y4ZugQHtIuDp7mDEcdcf1ozNJhOXtw0JgmIIiGnrlAifcg1GR+3I88GurvG9fVxqBEOtzzAcX2tego6AzYvRtTzyRrtPdBbTJ2TANTJNshk18P7Zr/+UKwV7/JA4UgVN1XKAFInJAoSaNVDfOXfi13rb9HHA8A09ODeFSiTxOgmhV+0HcOHBDRddSrBnlD+N3vxTdfwZ0JKd1uYLBz1+RmZb45KGyAKxp9vI+qp1x1sCrxLrU367v3IaZAKv0sD+fk8748WsGOPsxPXoq3+861231Je6pV6pJK1FGQK9xmizgde1soPtoKbNs32T9Pny7vizU0QV5buojSd99LycILUPupbfh1vw3saiMM80dbx1EIU2wBO1i+MvLkwlWqHeusdWSm4ji3yMuOkQbQbpw0JS79ZPNazDwGmmYzqGtfLDTOF2PLY8nWDrPnLxN5hEwRxcPFExV3FylIzz6XIPMzk1bmzoPnT3KYHB8rsljW0jJ5DhmHrT9oC+S9O5QicIxlgAbGJ82LDAURXpe+/WuC5CevOVuMRGd2ZoF3psYz+kvCMA+do1jOHM1+HCWBDSk7B8OJ8S/6PI0UuokyzbiaXd9+c3GVHRu0UHDCvp9A5NYWepzaunwTfhxOcUpzGDtgJ/yIgVHBUizk6FrHSqhaB6l/7/k3i+5HCaDCEIW2R5tKdtsfjhT2t88xGGrL+GQUFzRKpzDBu3NO tkrICKs9 x5Edd3nkXEweE9HoqYNJ4PLjkWDhVSSUUKh/jI5HaoPx1Ot6ffCe7dhq8UO9Gtznig0ZIPWEWHL+1Fdaz7q8nQOCgCioGEmkZizkc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 08:49:22AM -0700, Johannes Thumshirn wrote: > When the iomap buffered-io code can't add a folio to a bio, it allocates a > new bio and adds the folio to that one. This is done using bio_add_folio(), > but doesn't check for errors. > > As adding a folio to a newly created bio can't fail, use the newly > introduced __bio_add_folio() function. Looks good: Reviewed-by: Christoph Hellwig