From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6910C77B7C for ; Wed, 31 May 2023 04:26:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84DB56B0072; Wed, 31 May 2023 00:26:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6A56B0074; Wed, 31 May 2023 00:26:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69F1E900002; Wed, 31 May 2023 00:26:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5C0B26B0072 for ; Wed, 31 May 2023 00:26:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 278F31A0161 for ; Wed, 31 May 2023 04:26:57 +0000 (UTC) X-FDA: 80849264874.16.B63249D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf17.hostedemail.com (Postfix) with ESMTP id 6358340016 for ; Wed, 31 May 2023 04:26:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685507214; a=rsa-sha256; cv=none; b=6qD4FaXJy+aZ0lsiumVOdbe/kmSTlB4AT+WRjMrMX/JVx8BtAAKhC7Aob+gV/rIXgZ8wOo jelWvnjBv+oU/YnhBQpK4AqTzzxYt+7XUVp1DDCxk1NNWVfNDLEpliFBK2fmQq3jQgDlhG dGb9M1EF7pkFnl+7yzwOUoBvhok2yaQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685507214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5sN6vFID4Y9NF66kqBa6RW+qj5bqKbv/Px2VdKOmM8A=; b=5cUvmRCAFugpe/DG+PBuUEvCLsSn+9odOvPH9cHZjfZX4rAiTZy4tVsa3GA99Tl3SwWnsZ /+7guRK3FQjYNaJSw/7t27qdfZOzJdmPyC4OWh7Xqfsm99FChQTlIoUvCv/XZbB1MUu3lY e0Wk0VpEaq3gDsgzbJTK+ARlabEwkpk= Received: by verein.lst.de (Postfix, from userid 2407) id 89F1768B05; Wed, 31 May 2023 06:26:51 +0200 (CEST) Date: Wed, 31 May 2023 06:26:51 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com Subject: Re: [PATCH v6 18/20] block: add __bio_add_folio Message-ID: <20230531042651.GO32705@lst.de> References: <5a142a7663a4beb2966d82f25708a9f22316117c.1685461490.git.johannes.thumshirn@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a142a7663a4beb2966d82f25708a9f22316117c.1685461490.git.johannes.thumshirn@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6358340016 X-Stat-Signature: prinacr53gznyzy5oyobx8bpw39rf91o X-HE-Tag: 1685507214-542942 X-HE-Meta: U2FsdGVkX19RxyP+DzIZJAj3MbsSwSUmrb4IE9MzrAfU4DClWgYw21XAUei8OIMn/NcK6akvPa1DPIESFnxvll0v6lYZTOWpZAGh0tavK0ULhvTKtYoUC08N/h5OO+X3chTFD4txX4GlSck59RhCNzR8bl+bpIlri3uavaUgUnyxRgPsdh5U08bowvTY9UhWsrKMWId3BxEqTPeEduy195ulx5yCipC6Jrp7tw48ycRQvkR5XwXykN+ttIys6hqCCXsk7L6pbfbTIP/b9ek8Ew+grDoktRGTR4zaSvU8OSwp8YKYi6MsQy9Lcii0y0a5dsSRTEHsw0xDK+IdNElSOxrOlNChyyA6B+JcG848NPSNMEjQqX+iNOwItCh6iMMGjy/QZVKd8mY17pn6AbgzHJu51CtPdXOBgSQ8BnP0ddfbs4s+C55SwUX+qo7yWIPpE45d1naDymQJx3fCkGQNfNXaTxnhneRPN9dJ/SyheBgWoPzLqNw4CXHqe9qhAt1cEyTHdU0rUModzIOX5B5QXvfJ1rMxb/3Ze86NpOKtCTJ7h/Cevyxf+/PO9KnujG6x3FX/2fQz8aAbP+a9UJqAJSyhhom5WT4tyTEOoKdedBovJkUoSY2apJCAGtUv+jTzV5+QoYFdDngvaBXt/Mz/ahImnvsLat91tIZVTU3cS1EIaYlc9oXc5EUNEXz7jk2jYl4SMUfdzpjga674gOVJO5+bKdKFh2Jn59TPQWf7QP1ImXAv64h9bN9GXcYgpfAelMspJrP8eTkdgOVn8iDaweWCt3VU/rAx1Kttifw6Jp7gWoOMuNy3dDLhEJOrQuLGwowt9IfCvntQDfwHzUoElfL3cgG+6plItgJ44btYvnnaWgwX3BojOoU+fFhDoij2JiKvcwj0qhDkgaYQVV7WvnIbTL2U5BWb+UqfRjo22j2V52pi2pHmP6gxpCcGc91D/x9iwCTaOSoO5C+EUf7 +fvc96s/ JDjC+cs06BNAd0RIvtdObiDZhp/MHaL5dY0LGeNRHNOGriLSrOyBsN50otCZ73Ek3ce+0KXYT8pn+4BQWJT1KnO4fV9jE51p9gvzwrSLUaBjD+K8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 08:49:21AM -0700, Johannes Thumshirn wrote: > Just like for bio_add_pages() add a no-fail variant for bio_add_folio(). Can we call this bio_add_folio_nofail? I really regret the __ prefix for bio_add_page these days - it wasn't really intended to be used as widely originally.. > +void __bio_add_folio(struct bio *, struct folio *, size_t len, size_t off); .. and please spell out the parameters.