From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682A5C77B73 for ; Wed, 31 May 2023 04:25:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E68FD6B0072; Wed, 31 May 2023 00:25:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF1986B0074; Wed, 31 May 2023 00:25:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB81E6B007B; Wed, 31 May 2023 00:25:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9DFA6B0072 for ; Wed, 31 May 2023 00:25:54 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92B2DADAF6 for ; Wed, 31 May 2023 04:25:54 +0000 (UTC) X-FDA: 80849262228.14.704E079 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id C5543C001B for ; Wed, 31 May 2023 04:25:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685507153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zmy+FiXHIoyijhmzPIC9ZVW158RGIc90QzMA37CEKo=; b=hdPOtutUrH3aZTPiXlyFvO/KTc+ShHQ3oTl/5gETHQ/7nGyx8yROyzM2hdc/cK2vA9/qqb M2WvoAvrtM8v9GoFDKK+40VlmqFen3PKjXQdu+HtfAT6Pr/EqkBUDsk4yUSpM/xdFbZdaB LSxU2cjnlwx1OWE01qicwWWbGES8ZyU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685507153; a=rsa-sha256; cv=none; b=NKt3ievlOGvpk5uzwC2KU1uRXl9qQaevgXr+PPRTcIc4+l80Umh/1MPHZGgad5Nz19GKIY FqFXtmk41WKAQUYKuFJ00XRelNq8ebYY2D8Cvuqjgk8vMbM+/D0mNWt9GHg5UCSLjwko3V Kjlvv5lmE/Rh1+I3nI0SuxfCjYu6sOc= Received: by verein.lst.de (Postfix, from userid 2407) id CE4DE68B05; Wed, 31 May 2023 06:25:49 +0200 (CEST) Date: Wed, 31 May 2023 06:25:49 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com, Damien Le Moal Subject: Re: [PATCH v6 17/20] block: mark bio_add_page as __must_check Message-ID: <20230531042549.GN32705@lst.de> References: <7b1df30b0db4cd34a3c9d66c9c126dccaf2eb52f.1685461490.git.johannes.thumshirn@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b1df30b0db4cd34a3c9d66c9c126dccaf2eb52f.1685461490.git.johannes.thumshirn@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: C5543C001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: gpj3bj3nqg9j9ns5ppow1bacfxgrj8fp X-HE-Tag: 1685507152-230708 X-HE-Meta: U2FsdGVkX19ZzychdU+viNX0n4/4uBRfnkzwc9FlDTEZAh6OvqUKqvDznNCHBIPVTIPRKXEIxfECQakgMuIVqVH9GroZn90ubx5aWM97+dWZhJZ9yk8Iti+rTcaHN3yW5GbyU6kdDAujel41wcAVQdgZ4N2im3R/r3q4r79TFzDjDVwZy4S3E+Gou3r+sG/QwO5jupfhSHnkriryJgJNAT6LYtdOwHfKG5Rdpr7qn6JqINVe7lxzXmifHJDnzmYACx9BK7iG8IaZBsOAn3ZE1kVfCDh/+z2AJqEzIAvhWvxtNSKHCZfRJitArAjo24Nbm4qUX5evmhkUVKuq4PAFhwFjnQzz4PKp5lkFB1+gFNP6WFdXv7UF6qs3lHPGpJzOlPeEHM95TD3cq5754GBfrXx7iTJwTDSEB7B6VkuM31cb/mGZ+htr9OoFb0lDJs9gkTIwmsTWa6qUJIExW91/hCw6UeTp6CD46Mju2le3XPjG0X7b5hcoKYOGn2iEg3ov1JbyITBUtRwyTclqcJkPiyDyIlkWXWIMZ1hHWmwZkMvNnfWDD3JyKxPsuT/AAxzwpJItfjA4fWQRDB1aDvTjB1rEwD/4Uq4nMOdJC30326ec4RK1FloiW7WN1Xs05A/BeiPAKTxZEgnT9UDe58msNaNOL2qVw7IjNSqg7hB0B/RIFe97Lp/r6Sj7G31Tin+uyrtdVqPhSJVoOWH87NPSOApPoUnxnmm+M/0+fBWejHJO24axIIyahxbZRz9fP5z1l37ZSZ796RIoBlXwC6Za6E10S0C3NQ/HwoOU8mfIwYBHLkDxK6QH9TtNgsguFuTDaFqsvd9TpXtZqg7MrRQF9fcub0F2tUwvgG9UaAFFQmedNhJXCFodFtZzILccTZWJS7Nx3PerIinbF5BkGgPgo9M7kodMW0Aj0iKSWgXZ2M3vl2Ly5qsrJWpNXsctqXeUo/BXPY88KSUZgK6TruI gsJqTh3u J2WH6YHOOyLcIPqrtbp1HJdbZlWG1tPYlXokfwM8UjwwzdV1vFWCNLalsss9N3xaMJCAGWl0nf1+HJxEQ9QIYDmhqfmRoKnurB6wSwL/xK1qt2gADkuqOFgPEH1yIXeE6ZnIq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +int __must_check bio_add_page(struct bio *, struct page *, unsigned len, unsigned off); Please spell out all parameters while you touch this, and also avoid the overly long line.