From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A873C77B7C for ; Wed, 31 May 2023 04:25:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16FD06B0078; Wed, 31 May 2023 00:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 120806B007B; Wed, 31 May 2023 00:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00EAB6B007D; Wed, 31 May 2023 00:25:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EA9A06B0078 for ; Wed, 31 May 2023 00:25:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C0F5F14014E for ; Wed, 31 May 2023 04:25:07 +0000 (UTC) X-FDA: 80849260254.05.E2E77A7 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf20.hostedemail.com (Postfix) with ESMTP id 0BEF71C0012 for ; Wed, 31 May 2023 04:25:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=none (imf20.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685507106; a=rsa-sha256; cv=none; b=OEat8U+/fa8d/4qCFkxXiUkp43JKCWf7W9Yy3o3M5UNdx3xEbQV1o4CohAq0OMtAlfsgfz z5KU4jhZ4P0xUj10q0rSiQWUOEtYg4XWDrXZcPH4zCn9iJiiWs3dk/ncyumrzJVW1aQpF2 KAG69pZr+fsaDZYQiygq5B2FrCwI5fA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=none (imf20.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685507106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wPJGvsC2PJFAhmqOn46Xyo++6BgHiK8L00/8oF/qdXM=; b=AM/2lyhAvaiI2BykoB91yO5Q0kzMdkGvyniktKzKQ/Hm2+n5+CMShEUpTuO7PxoK88O5t2 Vr3/P/Hm8OXhR/+PSiTpmY4EbW9SFHJEzuiGRLczRYbOANhJzt0riwm8feGLVeK3tQAlhn /9+jfaiIpV8AI3P/qvw0TtnsTYuxyOs= Received: by verein.lst.de (Postfix, from userid 2407) id 28E1F68B05; Wed, 31 May 2023 06:25:03 +0200 (CEST) Date: Wed, 31 May 2023 06:25:02 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com, Damien Le Moal Subject: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails Message-ID: <20230531042502.GM32705@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0BEF71C0012 X-Stat-Signature: a7i6j9d3er9kcgf6athy1xhkphukiuxx X-Rspam-User: X-HE-Tag: 1685507105-328609 X-HE-Meta: U2FsdGVkX188NJyM4EkokhtxCeaTJg+7aHEij4PI1zFCqBK/FWK9go45bkjijt0Wwa8Atokl06HuR97TgANmdaUarhbqetn0GBnTPxrKmbGAgZCnSS8DgH8FOoZPmOFtHWLKHC/Q9NEISwQI0uXXvly/gAw/UJIG1dHXSIXMFVz5qebKKe//sqlb8aOV6N1Xh/a5iQ3Yw9mITutAdmSMFcLbI+EsxnidcO4Y+qijki0FRAN+ZGXSoXdTmrCHtUFPb3Epi0Utqg1ymc6+JjGSrvBeyX15CPMO4SHBvoXRalqHckDEkIM+rLNkw2ri/smGXTRQibFFz5DHubUj/HoRsS+Ghu8WyOl1l5XfBKqgdHt2RH3pz5gV2sSWJOqqM9feSVNrWLAamo89FMdQDK/vFEDS7JHjCkIwy9NyGH6T7l0urs4xVT9Z2t34sYY25pExG98pr6zQyyxk5dYcTfB6YbmlM1bq7lW4+9fxqp5N/sFrYQX8ADJW8mbVx1Q/YM9pp+U9TtERSOLBODwCSPBY+V61wcAfVmZFmYYGlb3bSM28EU7XGj2gt4QKVY1DaRpkEr8rRhTPJS3lUt3BXCx/3MOzUjIS7VVTWAz/2Xxi5RN+xfyb98tdsIavVBd1kFRkzxtk92QMggKGNGabUwUXmnTYqFS9wc/fyePsLXJsuNAUUPV90sQr1r4B4/YVsnl/KTs8L6YF31qNbAZf2YvXG2CwYcmC6/v2HzL6jBbtgy0w7pKlLGuSSGt34CuTE6Lc//AAvS/qnJmx1kcx4QZ5ECeyzo29bNHs3ZXxaAdKPhHDPQKJXLPPr2yRlZr0rGZNMv9JHN43qDbgTaPBYfa87k2zRTOTW/hoKLXJwUNmwzNnC4tH4LzlFzsm5xXdyoBcbsn/LGspROH3CIbJy3xPc9nxwdIqXBRK/WygiVlHX9oDBVYntgOnLLLMQXamNTxQQRM44+SCalyvbYBDvv9 +ascUzpN fGvLXLvPxKCfYIJZ194XVdqKjKI7G4ONBtJDqm/WlEXsue8jyi4IpIs4oJSfewkhFz/MD2l9nnK+uJu8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: To me these look like __bio_add_page candidates, but I guess Song preferred it this way? It'll add a bit pointless boilerplate code, but I'm ok with that.