From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5393AC77B73 for ; Wed, 31 May 2023 04:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E68476B0075; Wed, 31 May 2023 00:23:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E18AC900002; Wed, 31 May 2023 00:23:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D07FA6B007E; Wed, 31 May 2023 00:23:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C27DF6B0075 for ; Wed, 31 May 2023 00:23:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9D8E01C6C08 for ; Wed, 31 May 2023 04:23:43 +0000 (UTC) X-FDA: 80849256726.06.EC7DEF3 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf18.hostedemail.com (Postfix) with ESMTP id EC9161C000D for ; Wed, 31 May 2023 04:23:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=none (imf18.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685507022; a=rsa-sha256; cv=none; b=xEgfh1899znn00I+wXLv1U56lvM8fBDDR5EcYO+sNGZN1NNM59ltCO2bITnw8WMAw3s2zL obe0X9w1LwSgqYeHWRFFN5tGzLvzpFx2ZzwK2BhYKxWwc/kW4fbvE582AQ+CbZBFXP+8ak 5Gx8lGodWxjkT17BZk6RI0/J+cQOQWE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=none (imf18.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685507022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fs7J0ogDltyNtiDk92EpmxVm3aCy8RyBqdikzJVS1bM=; b=OWPTzNeRx9CTHVioSQ6xFjw8vYrsnLE3ys9aTj+EWR8AfjRIpuHmsMELG/MxwLEvXF1pLC Ms8fIRSoSUWM1s2QJqBiC07J/w+BaHoDZjW/hm1jWUcIc6NRU57rfZbGZUqDZvl0JCR8Tw Lfr7RuDoj6DLzktRTXHpfc8FVGACDA0= Received: by verein.lst.de (Postfix, from userid 2407) id 2A61568B05; Wed, 31 May 2023 06:23:39 +0200 (CEST) Date: Wed, 31 May 2023 06:23:38 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com, Damien Le Moal Subject: Re: [PATCH v6 13/20] md: check for failure when adding pages in alloc_behind_master_bio Message-ID: <20230531042338.GK32705@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EC9161C000D X-Stat-Signature: djwh6y4xmusuuozngupbysp88awg6wns X-HE-Tag: 1685507021-352462 X-HE-Meta: U2FsdGVkX19r5udYqy2gcpsHhRl5PGEAepc0pDiCxCKChUHA4RvTaIqbVZHgkPxU6dkyoB3tPbZg4PBm5ZdZ7HBarxSz27mQ6GVdx6S7Y5paUfqK93winCrD6w+CE5B50YoomGfaRuZTWNEMWx93oEfw3VN3fKosznaYeBpZZc8iesvgkaGKAOL6kr/pH8+SlqWoGQ7zMANSWxfTF1ohBAL9qWLb8Sv1bk+lhh6aBj6iZbq3zSColNqRnRCe/Xpn+e+FemhCl4+VjvMZMLUl9t1wraJ7wUXQ8Q17/w0jxi94e+J+rVOUV3KSO7SmxOeF5kGQm+wUzL3MDLtw3SYb67Kfnb6EapPjqbmsMP3mT2VJwufaBKNOTL5Sq4QwbD3B0X1cGyB11T8xDpNjeuYWXeotTv4CXwzy/L0Z5XCbaN9zZv28eJImTn88SvxWDbavfm+w9w2/jIQ0qYu24PvdcYFEo3tKoSvEjZ6EZxxwThL7ZKt8wHaz21NUb7N7Qqc+taWf4n73T5w+oTwH/1Tul8WjlgEmD2qnJ26nj+9grg9Mt2H2hgkR4GCG6UysbNsdcIOFe7bt/11x52nkam0m9S1eBqULjVvXpVhK+VcsOjRr1raLfFBvrVNf96F8Lw79mrTMjH0ib98m95xRRWOWtkpmexq7aqHTZFolcyUp/JTy75HpH6Djtu2PqaYofjgF3+POLrpClj71FQc7Ktzht0ogYCVi0OB1RfoQEKlXwjqz4V1gK72Jr7pwanH52GXdI5L3CiVvEWTUxDfeRDzK/z1SiL1sbhCeQ6g6jaTFctXmZRKQoRiAD6H6Thy65uUNXbLNCLl8cLwoG7Cor6bqrnhvPeAtc83d7t5sI774RZlW6ZE9lMFwRuIh2iRK29l8mCJ7GneTdq6QqFM1Ci7l0+cmZUYC4rMw1OVBPDC5WSujA5sgXvGoy/0572sCbdkRyQbzb/X5oBdbCtL0McA sDf66MhO 1qbAs6KxCvha82KOpx2lj2knQKowuN0eElVjxSFTiwtrgYzXmFvuY3peIT5XU2NXbwXJdAss1nvFbDYqwx5pnJwINYE71D6iGe/rFyM8jSKTfdCT8EzrMXtwr37dLmHunKBn8eEaXlIxuwUBKMicPKq/pZ3e/WeKJYsH+//DF5yAobCOTdIaCisuP/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 08:49:16AM -0700, Johannes Thumshirn wrote: > alloc_behind_master_bio() can possibly add multiple pages to a bio, but it > is not checking for the return value of bio_add_page() if adding really > succeeded. > > Check if the page adding succeeded and if not bail out. > > Reviewed-by: Damien Le Moal > Signed-off-by: Johannes Thumshirn Looks good: Reviewed-by: Christoph Hellwig