From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07C0C77B7A for ; Wed, 31 May 2023 00:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3959F6B0072; Tue, 30 May 2023 20:58:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34583900002; Tue, 30 May 2023 20:58:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E54F6B0075; Tue, 30 May 2023 20:58:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0CBC46B0072 for ; Tue, 30 May 2023 20:58:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C87D480372 for ; Wed, 31 May 2023 00:58:42 +0000 (UTC) X-FDA: 80848740084.21.D4C9BEA Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf30.hostedemail.com (Postfix) with ESMTP id EACE280018 for ; Wed, 31 May 2023 00:58:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Wc8Dk4to; spf=pass (imf30.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685494721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nWKTx1C1busGH1n86mFA2gXYIdrkaqudVwHZXoCwcUY=; b=RSwYU3j4KJb8/CZTQ7CA/NIYRkK0SeTQtq9zRRHcLlsEgKfFCOR4DA5LzvMcOZpK7DPj5F MtnzSvwlPJOhZyuUU2988C0d48S3HhrKwOD55bxEGdlBk3vTVwiV4m03pS36o+5mn8VNED CZTQlsk2LlviLicmFYwz/c48yFSsjwg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685494721; a=rsa-sha256; cv=none; b=Z+TadCtqbznUlNVoFztZp38QgtfRH4S+JSyxdYspPNYPYSj6vKx4cZ3bZM9OPodV/FK+Oo GLgam9Gq4DKa9zYnO7N9VEw48M+P6+EkDB1EbHxW7CKPIIbmnJ5xdesCepI6sYCP0iiMsF /XwsSSFY2WszwkopszNn5FnVLzhnCy8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Wc8Dk4to; spf=pass (imf30.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-256e1d87998so679550a91.3 for ; Tue, 30 May 2023 17:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685494720; x=1688086720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nWKTx1C1busGH1n86mFA2gXYIdrkaqudVwHZXoCwcUY=; b=Wc8Dk4toURb+GT/VEX8u/ZPyAeWW0viHsBDstcpqO7X3e2/blZHuN1+hmZJS+cl5oP bRV1ZSAobyuH/GVbroK8S5fQ+vcSsXZtyyGF8PtrVyS3KWmhtC1e/0pN2yyqrrKmWMyu oyrXQNAbInrdlWmPC7t4wsa0BwtX1ssd5sd32idOI2cuL0f0ICybsuPNZtKjqh1bZ5RY Cn5aeyib36tc1wO52dckv/VhJAkwJAU4er9DdKf+rKkyJMjoS0A2vE8hEGZy2foKKvNi Y2szGXUSLGg3gc5Z1VFH+/PmXsrKxsxJvM31zTpEEfhsQcMnM3P84P2Tw3Sx5ZCnvEEO /5GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685494720; x=1688086720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nWKTx1C1busGH1n86mFA2gXYIdrkaqudVwHZXoCwcUY=; b=hr1TfZ3V5rrE0BGX+bXJHNASOodztpkqWA5196BoBm/wHd/+2brCr/R570CwIramyJ IpSZgvsBl3lk1BvaH58y/ffRBP8Y2JFEWOtSrCUYtnNesjc15sNcajaAnitucpm5FD8s djVwRCh/lTuZPerbyTCP5zkyFXIvhYR2fzmhTaxiFqLmVXWPeLnkAb8rrSmfStpLfUtn qdr7QaTArI+FDytKqX52vFRW1df/65+4KYOODaQYqjjdLKWoh6mpgEbzkxY6Dd6JOyeT IwsYuc2Hi/Gy5AFIRCWFc6qdEGnaCHtCUyO8LMakIiXLFkV30Jt3iQu/q6MFuEGNKKgk cJEA== X-Gm-Message-State: AC+VfDybIyziq4vjAnXPAdLv5OJFgYuHyjf7AlefZ1vpqd84mA1Mu0wt 71JbctvxbBj2QQ24hJGFt/4= X-Google-Smtp-Source: ACHHUZ4S2eRbHGgRedMQgARSsQzR4FeyiMo2BgeRkIMvEiZvtHs3TgFqX5xzfyeRHHllfISc6pH4zQ== X-Received: by 2002:a17:90b:2301:b0:256:797b:5039 with SMTP id mt1-20020a17090b230100b00256797b5039mr4202403pjb.9.1685494719614; Tue, 30 May 2023 17:58:39 -0700 (PDT) Received: from localhost ([192.55.54.50]) by smtp.gmail.com with ESMTPSA id fs19-20020a17090af29300b0024744818bc5sm22404pjb.9.2023.05.30.17.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 17:58:39 -0700 (PDT) Date: Tue, 30 May 2023 17:58:37 -0700 From: Isaku Yamahata To: "Kirill A. Shutemov" Cc: Borislav Petkov , Andy Lutomirski , Dave Hansen , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com Subject: Re: [PATCHv12 9/9] x86/tdx: Add unaccepted memory support Message-ID: <20230531005837.GA1808127@ls.amr.corp.intel.com> References: <20230518231434.26080-1-kirill.shutemov@linux.intel.com> <20230518231434.26080-10-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230518231434.26080-10-kirill.shutemov@linux.intel.com> X-Stat-Signature: 9bz77e7okqpdnog513j5uqspfnqaeuce X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EACE280018 X-Rspam-User: X-HE-Tag: 1685494720-659697 X-HE-Meta: U2FsdGVkX18R/oDBrPnY/k2a9YE1fskmRF1BnaSWjkDxw8Oh/os2sjWsXylcko26QZIvIhYUPwqEbBwnlRNTDeeC9lW6tKL82UHBsxEIAoQVlwM7ukrKR2dC/brmplsmFLrpwqhsMcJz8BnOh6tv1vOxRdAOda7IHnSC+GwDluBimVdGu6TcUTdGvuEKVJNORiwDQPE8BEJ4xlPzpMdVeFHvwhYLcGDyniTGf5oY5MsVgUjT3j9ca9c5+WSsOEzUuzHaojPI9v83IFAfJ9NmKZrG7ezH37V81VlXZ2JbnvN6rtcf0HbmUcHC+6zvu4bdwVcvlpCTPE02G+/SgGk8GGx3Io3ccI8MdQ4TbdsDroFNKonMf6knVfOWPHSQk3fDGRc2vIJrdtXvAezW81cWP/wqqH9lVkjKuEBfVMwM+PVvlkfhZpqnIIiQ9Iijgh5oLVUMM8OXyAsi18O4xZufXBMtPLOV4bECfnLuw34vZgb3Jm+GywfnFjdzuTtYUF0vdMyAfdL+MEECoRBxHjycvlK3YcvrTDuHuFP2NPt6oiEZ9v0h17B9NI3Tw/jUuaCaeBjCu3SQghUFk0nX0uLZNH9ktognozB2spb/MOhlCg5lQMty8D1XkO6FGvMhrVOYZcstAuju3QVqFMbbuqouZAh6HQ02mgMdUxj5G6WbmMe+QI2hpFpsY+tzFarJSeG63x8b+JevXfk+8lP2ie7T4SM25SsIob8IfInkeJCMoSj/+OiFHh0c/2fACcxVc68BIEy0urJSJgxkHPB47cH9o/wJ34sacU8vLgMHQ89u4mTC9YZ3jBsBMuN4dMMbakr9dLz9GATLitQ9pr+M6sunbEwXsgB2fw/0TLyOc9+DKhcHtZT7JLFvFtCLfu8bL1iWfmwHno+rteDqT25zpyVXH4MQ0N9n19cIpWRbq92U0uarHwtpmkakVGH5dJmeO06u8zOX+/WDL5blBCJebmE SlLvueSZ /ypuuo8yq9ahgo6Ixtw8vzqFMehL+ltgE9xVqXrDdFzcqXF1BGOTshf1DJ+a+eeeQQuL6QOV56wCBtji77BaWAbHHO8n1IU5gjT3G9md9eLwyK7mMqi1K6hL711x0jBQ9gEa6dyrcc7ERe19HN3bEiqh5y1VZC2uvwX0k4simLfqtzFySshPz2BoLnJiZUTGoImFEJsPbHc9KOAUspro+OeE7YwIUWzzUQ9U4FOGzZHDIXTsP2mavtiZBnX31WkyvTYRDcYRV7XluPKX3UQASplFwlxFMzOECukTr1e9IMzo/0o5LbDPymRwIZvwfnoGUkGkFvck62eq3H+WB8r1jUzWvH1tauteACTd2bE+FoAk0s364fDkmUIgBuxU99JhDBer4eZhVMNHIBjWFJwoUnpaJvPD3gfCNUpabXpxuSQ+bDq31I7wTSye5IDG3jaF8Qd7X2Jn4oC2le/7Y3lQ5Dl5vBeyXrp71SWbAHWKPBC3QPFG0Fk8bru433lCXsAVd1HqbMPNFYuW0VsY21rYBpludL6i8/1bIS/MnBtfqwA86tZNXRbUoA9cA/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 02:14:34AM +0300, "Kirill A. Shutemov" wrote: > Hookup TDX-specific code to accept memory. > > Accepting the memory is the same process as converting memory from > shared to private: kernel notifies VMM with MAP_GPA hypercall and then > accept pages with ACCEPT_PAGE module call. > > THE implementation in core kernel uses tdx_enc_status_changed(). It > already used for converting memory to shared and back for I/O > transactions. Because unaccepted memory reported in e820 means private[1], MAP_GPA isn't needed to accept memory. (Or are you seeing TDX KVM/qemu issue?) [1]TDX Virtual Firmware Design Guide. 7.2.1 Memroy Type in TD Resrouce HOB. Table 7-1: Mmeory Typein TD Resource HOB. -- Isaku Yamahata