From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32637C77B7A for ; Wed, 31 May 2023 10:49:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8334A8E0001; Wed, 31 May 2023 06:49:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E33F6B0074; Wed, 31 May 2023 06:49:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AA998E0001; Wed, 31 May 2023 06:49:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5936C6B0072 for ; Wed, 31 May 2023 06:49:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 220FE16036C for ; Wed, 31 May 2023 10:49:44 +0000 (UTC) X-FDA: 80850229488.25.825A327 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 5AF58C0007 for ; Wed, 31 May 2023 10:49:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cxz04lOc; spf=pass (imf28.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685530182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5gNX10RlP5j+Lv15p6OwKhBk8Qra9aYQKe+4P/vrrts=; b=v7WiW1JxJlX5HQrMeoWeGe4URUFgOMpPVYFDACq1ks5o4QKVA1BureN5psLsgJN+u0B9CP f0zCudIYGm2qy8Hg8nNVHa1d5zQPuDVXnqpYapa6SRcbo419r/e4OVg27ykEl7xHijnzZK apfpxPjSQbXqpShAC+PXHmpma2lHO0o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685530182; a=rsa-sha256; cv=none; b=xf2XG77YAxcZ/YxhPgpVGaXPl2hpWvXd2c+QlHD+txPAWL3hlY2lgZD+AmmAJRFoZoK1ez fuAHCp11OvInWn6Kt4eAbunLLhdexpz1PnhfV+hO/rIqxiNK6AAXg+IVUIaY3hu4t9+pGk 9T1jnC8szFs4p3z0rK3GHLJ7tUg6jlE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cxz04lOc; spf=pass (imf28.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52B9F62F3F; Wed, 31 May 2023 10:49:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F38BEC433D2; Wed, 31 May 2023 10:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685530180; bh=lVRDlljIusYtHqx2sPZQ+2Cw41zWVjXdIT83etnx7V4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cxz04lOcwCUr1fIb2WDXimONDnalvdJfFvEUNZQ0QLv/7KiptWI2SoE64QrOUXdkz 6g450Y9qpiBwGPiR5+1SxfwkMLAYSuAcSKk8YUKTfXW8NHtvepLSWP0XCJz6iTeXy/ lUepRzRCzFXkZx7o6z725cqbf4I06nCaevZnRiTCobnxR3I7JoRvGxmsxHCXFt2DHY 2nf5jJDLT7tTXLPHxtrH7RZdQ5Zak3nkxwG2siwodjinZAsrdYvYHjgBYnpQF6fxAE +uBDNRBrZB1r7wCKbE9lBQLIJ6qFe112oHymffplbpVSnzB7KGI2CJO1Ro8azcEBzz rI3ASxrMLbn0Q== Date: Wed, 31 May 2023 12:49:33 +0200 From: Christian Brauner To: Qi Zheng Cc: akpm@linux-foundation.org, tkhai@ya.ru, roman.gushchin@linux.dev, vbabka@suse.cz, viro@zeniv.linux.org.uk, djwong@kernel.org, hughd@google.com, paulmck@kernel.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: Re: [PATCH 1/8] mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu() Message-ID: <20230531-notlage-ankommen-93022623b74b@brauner> References: <20230531095742.2480623-1-qi.zheng@linux.dev> <20230531095742.2480623-2-qi.zheng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230531095742.2480623-2-qi.zheng@linux.dev> X-Rspamd-Queue-Id: 5AF58C0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 49bdaz8omxagd455rkgb54iprg5c5my3 X-HE-Tag: 1685530182-193265 X-HE-Meta: U2FsdGVkX18OpbzEypmbjlEEKAr5nPNBYVewLij89mxe3iGVJDJS8TnWmvHeTtK/ggjDbQSBWOXOuJ07BnkxpBV6Ad9Kdmg5K5VJeEyk1sYoA3mE5HxqP7jbd20IVFW8nu0U+/rMH8zBe+lXzufngneHviNIW4hnnARrIrR4kLxQx/Einq9Re1LULzOMu41vIFQHgDAWI19eCiWvlnBvExPA/Gunc03HX0BYtw8+GbuxvYFlFJPK6H4cDEwcQpBKSLeUa3BVMT/+QbDo55eD/hVXasSQa3v7AJaSR0WTuYieZGDGBc+DAp+pBxhG+/PYu1Yv1WMM9gifLfJW10BeAoI1jAToTQrtW3vHrzY6GL5okwA7bWu0A+/3v8Qq/+0eetSdIAv4Pp7WhJWybrsAfgimQWpVLsgssJcWTHWZ5p2L3zGOmdSuqRlyTkhdGlIWXwenKZx3+NMqW2g+BT15pF/js1RxY1s/VqQ0xCc57Nxa+vufTDtmLbROAlbv+dbriVigy14iHz4YIGPy73Yz/tSaGsKuyWyQbuqByXNVyHSWgyMMReFV9qdANFhmP3/sTHsJ9DqVhs09VA9U8SCz69TH8MzVP99XP4X3Hl78IxwB1N5LaoSEwrwOf3alVPgQPHzQHgoxevfYcJpuXQmCPKmnE3bAg3aEfS41FlXGWs4rWapb0ujKmi6mpiZPxvmscHwysnisG2kQeRAKymFGiJaaxkL4vHu8ZVKko8hJGxbqzJ51gGv1gYw3VM9/pCCLvc6UmWpGBbNp6UCOfYm2+tspuUjGkT6qaqGUMDYQAVIx+O1ciakI67h9SusYzgHyd/+t3MyfCZCPNFtH8Di/CAcl60WsBMOxGoAZG599uOX53kNkqxz+Nobi9VfT9mDSVkQni3t2rD7xlRXFV8q2pDumNXck6SGLDNLQlGbSeeIXb+mLksZzLptWI3wxDW7bffj3uPa8ItI/4ea7NiZ NbAiQIrK 01Mntg1SVGpW2W6AeVluDgerPAnEQx/922NUofh8+bADpyKg5djsIP11S1ka4MWDYmHhTON8m5DcwOf56tWvm09Wd677QcKTMeEYFmX00/MuluOq3M63XKiWqCbeP+Ixep5txlw7mE/Y7BfO5yZQKH5U7H4mVuRx1yD3pUH+sP3g2YEIyy9htD3iAE2fCNX2G+3Jji4UO87FRjrzlyC1xj31Y5p/EOfkPoSHn4eRJZ7pn0Bqn2bw9dBItuB8SITeqnD6fEcu8NPk3tjnAqwNJrQgEHuR0ciafmOJHjFG2zMGHnpgdV9ZBwVI+SeSt7lO4tZULTcGPaIiKBHTLHRdFjiQMAenNFHdhOW+UIY7E2YU01rZwfPNWPyodH67dBMG/uUsfV0KFhE+OTYs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 31, 2023 at 09:57:35AM +0000, Qi Zheng wrote: > From: Qi Zheng > > The debugfs_remove_recursive() will wait for debugfs_file_put() > to return, so there is no need to put it after synchronize_srcu() > to wait for the rcu read-side critical section to exit. > > Just move it before synchronize_srcu(), which is also convenient > to put the heavy synchronize_srcu() in the delayed work later. > > Signed-off-by: Qi Zheng > --- Afaict, should be a patch independent of this series.