From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10624C7EE23 for ; Tue, 30 May 2023 22:13:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C9046B0072; Tue, 30 May 2023 18:13:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7776B6B0074; Tue, 30 May 2023 18:13:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 666A56B0075; Tue, 30 May 2023 18:13:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 58CCD6B0072 for ; Tue, 30 May 2023 18:13:11 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B1F3140370 for ; Tue, 30 May 2023 22:13:11 +0000 (UTC) X-FDA: 80848322982.01.C419E32 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 42C7C4001A for ; Tue, 30 May 2023 22:13:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GMqZ3gNK; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685484789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zmFlsCx0yHrUFTbX7vQr5JPh2I48WYHfsuDyDisqNzM=; b=BtPC69EKIMGnZa4ulcbCDKtpbWZvGwEgZLJMloiSKEIXQFQHME+HtBmNPeqPXvRKlUN43K SEldXDoGfyttdXRLWpr/pZEoHmoBPeZCzr5xfkv6DWdVgWvtdbTnGO4m2dW3/n+VyTExVF wOrKA78B/GXsl+w9HvbOSxs6oomVYho= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GMqZ3gNK; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685484789; a=rsa-sha256; cv=none; b=g8rAfRWiCAekZqnADZy1nSJkT2TSpJlCvHGCT8JXtBKrRucLlY2zz7DQ01xHXPzsgJc9DG wE/0SB+ZVCFa/9VJLgmq3WK21K1GCnwcNhhO0St1KRgSqum0junLhepzXWDkTMHxCRRF9C VsKIrjfbvc1X7PlbBWBmzDvE+kv0GKY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D8086111B; Tue, 30 May 2023 22:13:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B27C433D2; Tue, 30 May 2023 22:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1685484787; bh=y0tk1LhfJUoWojH29xQgBQAHyyiXOdXW+PIeggjfJ4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GMqZ3gNKQSHgrxIW3VQKnJ3POD/m4f3LfkDLMUO9uTzwJ4TFhEJJnDfXfootzO017 PmgfE18SeCrd+MYkrstOTSn1rsgn/s6pf+LFlnoj3xWdvKFFDtmfjBN3T+SjWdns/W nA8n1goiD5ektUFw7ElFB9J6q0dow8tBCGBAxK1w= Date: Tue, 30 May 2023 15:13:06 -0700 From: Andrew Morton To: Miaohe Lin Cc: , Subject: Re: [PATCH] mm: page_alloc: remove unneeded header files Message-Id: <20230530151306.b9f24b247c66ea7f80df6be8@linux-foundation.org> In-Reply-To: <20230527100728.267992-1-linmiaohe@huawei.com> References: <20230527100728.267992-1-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 42C7C4001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sb8hutcrawzd7z565d5jqu611dutkigz X-HE-Tag: 1685484789-95192 X-HE-Meta: U2FsdGVkX1/lRZnEzWkk5vzj/siUxwe7yAbvulo4CrD/i2PQsMQO4hXwIfA9CwnmqEcaF3905CLa7+CWgLKvWhoUPI2D4QQoxrmq2g9SRMHT/5TN4mrJJ5sEL4jYM3/Jq4uXMzATS01pewRFjcpCY9V8XCkJemNYHYaA4F+d97bC/X38FNQgXL8NoljJIohtGehkIrhv598zF/G1koOEbbTg9yk985VtmG/QPTbL3aXBqTOZDfL9ITsehMEtfaYPLVPel9qU18kk/5g5lLyzCg87g7n1PKOaeBAIML1qgkKOt73p23YT6dCUztJ/6zXx4i0Qt1JjPj+NdmCCzYVkXKdQvscwhp8uV8jKrTfY7mGCXhuJpGlcG1ZmxxxO4eoYFjqU0OSVPTcfpplQc4Vp4c4qW7SBdw1vpCtlYFXtBOg3ZRGzAq3MFa7yXmtmgSHsJlcbt+IWw44ki41hBMbhHIkxxzjVU8SpC79R5z0kHga+CAWjgoaMwxQl6RBwd2uemPpmYHgEVzWc8Zf1Zko2bXClolvgLXhysVy1c31TgKRpCQlJ57fnnTNgYcfBN3XkjTAEwYaX7DxsN21Mk1xwz0Ztagz8enEGCn3D7DTP4e3sFfkxGdBFLPDIljK9EPUvyqSyLvpt3NZNLHF59NghkZAmSODmOBoAdgAbxfSAg3HidEevFyd8KdhKwq4jIyXvN7w3vGwN1kbXEtQfEvQV3EPsV9r8lNgyCrYoTNwcaw9PdrGIUpNnCR2/keaqK4CI4TwpZ9cg6lAS1RgqTifbpXMGajg+OGpUy8j/YbSrvpQXrDbwr6OJMFl/EA89cYpqLAn5jrhSiz8PAIDuOOos5kj9I2tl93qhDvN2m0CtqYCNDYWnPJR0TzIjK9ryfcCO1mQhsk9VHZPd7rWvgaq5jy8ND/XSgObmjch7lBJ97QcNUOe6N9kngnYChl4Cq0NHSu68k1teRg34aNi3kgx uKdP1pNE rWr8n3UQ8uVY486aTGz4bGVIklzHPucb/o8cR20ZOVX3Bl+wiLAtEHuAkDWmcikggIknA+Q4Vur90Y9CXVb12vhfXB1J9YmGpEFvv4+4fnp5AUKCAmDdJktrk/3LLzhLIANLTA2hjjUgY4/uFLPX9GyaYsrSIgtIIVZ9wi3tFckdshGtNyMnkVrKywEbQHrZmGStFEnbkCsGJuwKtffT9CC605R6eYztxTPOHRh/444xS/rhUOK45x2g2HDKFzYMpCU3/L7PiglJAs/egZ8o8WIrnmtQxYmLOQ6e9+DLut/y6JjwKPwoz8Lwu4IY6HDqCafJ9DkDIKFBIJFQKhAnChVdeuqLP3PdSs1NfPu/iJqbCRe9fbQdCBpaB9duQsqdM2Mpc4ByPHfa1i5+O3EY13HADXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 27 May 2023 18:07:28 +0800 Miaohe Lin wrote: > Remove some unneeded header files. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e671c747892f..beb6db613238 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -24,9 +24,7 @@ > #include > #include > #include > -#include This contains the prototype for print_modules(). So we're now reliant upon module.h being included via some other header, which is fragile. > #include > -#include > #include > #include > #include > @@ -36,8 +34,6 @@ > #include > #include > #include > -#include > -#include > #include > #include > #include > @@ -52,11 +48,9 @@ > #include > #include > #include > -#include > #include > #include > #include > -#include Needed for do_div()? > #include "internal.h" > #include "shuffle.h" > #include "page_reporting.h" > -- > 2.27.0