From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9E6C77B7A for ; Mon, 29 May 2023 18:53:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8338A6B0072; Mon, 29 May 2023 14:53:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81307900002; Mon, 29 May 2023 14:53:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72049900002; Mon, 29 May 2023 14:53:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 63DFF6B0072 for ; Mon, 29 May 2023 14:53:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2BF97C01CF for ; Mon, 29 May 2023 18:53:42 +0000 (UTC) X-FDA: 80844191484.18.D5EBD48 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf12.hostedemail.com (Postfix) with ESMTP id 60F1940019 for ; Mon, 29 May 2023 18:53:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=S5vwol9v; spf=pass (imf12.hostedemail.com: domain of 3s_R0ZAgKCJoMB4E88F5AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3s_R0ZAgKCJoMB4E88F5AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685386420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fb+xGJEzAuTS5TrIgTU4fcvFK43ao8HwfzBYRc52TTY=; b=js+THyRz9AYiBOupUc6xqeX1hwRBKGEkgTBG2HPqDpPBk3E0CMvFKmD9IlqeTQ0YM2aqPc GiNIbKU/BIhbcCLmo0DU+HPeLG2T8T8UmIsFT6mmRVKTkauvhUDrSX9C5pbyBoF7LFzV6f Kl902jMXBJ/oXRwBkRbRrgOfTRWrqfw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=S5vwol9v; spf=pass (imf12.hostedemail.com: domain of 3s_R0ZAgKCJoMB4E88F5AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--shakeelb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3s_R0ZAgKCJoMB4E88F5AIIAF8.6IGFCHOR-GGEP46E.ILA@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685386420; a=rsa-sha256; cv=none; b=7mJ15B3u+97TEut5Wf9Yr0g05kunKcxAaGb28EpoV+ZK0lNvrkfcGcGlDgGK2zTXTZuDqv JCPK/H+yAwsbDPZ4Tku+7EqeeQ4AbagnbLDmUYa0HUOx8AYKT4lrMj886oG7BekfLsyCjz EMtsaSBv42UQC7/8aXIgqpSC94Rp2Vc= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-ba81b37d9d2so6896039276.3 for ; Mon, 29 May 2023 11:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685386419; x=1687978419; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fb+xGJEzAuTS5TrIgTU4fcvFK43ao8HwfzBYRc52TTY=; b=S5vwol9vE0JkslbkyRPxKAkNViXqytiqtwh4nsd9eEgwmZ719gWuFJVhrVRcYMhMhH I47+gsK59+oMFCcm/r1itjNdraOXhmYJZhEWSuRWoUYXc7Dp070Pa2Yyvj4dEuYLGKoh AVGVBgumYkPyDju0i+9bhA5sVMRSAbgmt/bo08Ofp93ulaxvSQqkzkIXUIKt60Qxt7aS ckbLK5h8mRGy+3ePq+B0w88MS07aczR+7j5ah1Mo10ytZ913dDcxeiCeTs6HWF478yhB CJ70hGrv1bkk+tSU6BqdFxjeOmCN1out6pHgQpdSrk/bLD1zCrblrtDWLbN3YGdezv4T flqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685386419; x=1687978419; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fb+xGJEzAuTS5TrIgTU4fcvFK43ao8HwfzBYRc52TTY=; b=IUmtbV4Y5Nem0vr0nfkq4o2EpvVzeinbMLqxfwECXoHxrQjdpI+QidrNI+Bae7FnLY 0hpOXKGxM6C8wNko29Tvzfk79Eh1N4OacA2ao+98jX6dJ0Rh8oVgfskkSHH10ul+5Heg zzUhuOmj155PQO6xtdCIcDpJcDWAhpp5Pv8R7bF7+OvH/LmiGzaVMFmoYzes7QuN8Si6 tjrw8keqCVfk1/LIZbmCBReW4EDHoB20692Z+hcnA3V6Ax2+e7BjD+u+GsmzcUGAegIO +OVoWvk7Q86sdfKYeuGtcdUw/d06hjulTnGbcauzjNdZSgFN+X202VXAqshDJtTfY8uc SKfw== X-Gm-Message-State: AC+VfDyMVqNZsVvPZuk++3eH/cIuGYZUfd4hOIjgmeskWPL2nCPBYbwH W3HQlcZhtDeHih0tPtTwFXmtgMO8fUVuRg== X-Google-Smtp-Source: ACHHUZ7Vn/Q5HrLEkQuw5sBuUMFb7N55w2kESh9lJCpvJqW43vVCYmwyZoVIhiVBp34GVFj710bX4NkVKlJqoQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a25:ad1c:0:b0:bac:a7d5:f895 with SMTP id y28-20020a25ad1c000000b00baca7d5f895mr31364ybi.10.1685386419461; Mon, 29 May 2023 11:53:39 -0700 (PDT) Date: Mon, 29 May 2023 18:53:37 +0000 In-Reply-To: Mime-Version: 1.0 References: <20230527103126.398267-1-linmiaohe@huawei.com> Message-ID: <20230529185337.3gk3ww76sdxdgv6o@google.com> Subject: Re: [PATCH] memcg: remove unused mem_cgroup_from_obj() From: Shakeel Butt To: Matthew Wilcox Cc: Muchun Song , Yosry Ahmed , Miaohe Lin , Vasily Averin , hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 60F1940019 X-Rspam-User: X-Stat-Signature: k19bbexgnyhgmz8nc3cougtt9satsbfh X-Rspamd-Server: rspam01 X-HE-Tag: 1685386420-116668 X-HE-Meta: U2FsdGVkX181eL6R/KmGRHaN3l67AAmGEmEKcNp+Xlc4nFhfjP843O1yLaJ/77CN/u9I9/Z8Zx34RcEIbkUpb/abT1YABDlWyyaAYfwOhWhIpy6jdWeFAM5jHtf47ASaoWeG1IDwl8OSi/GmHmp99i3r67B+zaErq/fz12FZgBsDtWLyOzqhdTNHjW6gkiAArnh48btuh9sRObWBLySIF+u7AAJlu5Ys4UmPP0RQM57ujMpaNTU95WDExZTpOPkDj11v3z/jvZa+6ChANxNr66kbLn6wpIuApqN/P2qsN8v8DhxBAYFa9pMbC4+zwGnhuvxeRWC3lrV0szTvt7LZdccgpgTKFt7iwnSvD1Dn4VF0gXvIum2SnKFR7wgaH9cfnwgp4ZIQBtz8ZoNDqy320qzYy0Oe0/nalkAq9zS22UJN9PgI16G/lYbhjVxsN68IVj6lSEo9Qr++bu0IK0WTywAvC9J1GWApQp7hhwTa7K3bEbwn0Qy4eg/XNap9PpdcZCR9krnw/hx7BxM5irB/ZVpX4herHr7Wn9F5FVB55mK+HowAHXn3cjaCsglW5Q55Unhb/p7GHrAUPhxphrO9MiWZoRiFMebM2SWB/qzM4E5jZQRNopYk3V0qCsGG95Oz2hfXisZKhDHlMW+IDu03cw7i+cIcar0QbaDhHCgVZVpio5yVKWue8dLoIHW98lt/d0AYkWmwpETMwAtvmQk25mz88MHUBhF06mCigbCpSHdVONcnW1EDWLsU6oA6mnbwAVwHwB/GGga4FpXq3PDFicZ0XkHek+v7BRpnDZ4BIMsnR6LKdcyyumQ50M675dumfqtc3iWntzzGTTh+RHeay/Y4anPFR+EbTp8cXd0miVVQXHdXES44DwpcqpeOqhEomxpgj9Dy4yGLA08sK5ByIiieEcR3AbK8piTt6xRdRG5uAHHh7AgepfztsGwI9Bq1ZqySdc/T58TPp632+b7 H57edDYt g+GxKiIeUwuS30/Edy17BhJmCnikhWDcH3UAWhswTKxZGTX1dah6tASOrRcLNawHKBx0VXSWPkJtLKjtVpLA3cEWyI1fQvxXzGO9fjox2TVug/21XnLmWZQYNwuRAgEhOLSPwVpBmLEfJHQQU7pkYOPNX9bSpYWljcSSSypLQTvdmeuhIqnlw7o0l1B3cSnDiAHe0nRSFk6xULw5cNKjFHpve3uU07IIC/2J4VwtdU6KFe5LJtb8ZAcwLhqeTRZ7kK1bAmdoi3lfLNPqcA+eRRSmnbFEV5IYiuUGvXMCQVeuPX4XFs4PRsCoG9jPHCJhq334GOMzFCj0gAN4Wb77JrinKbInOGfr3FoL3U5Q/7hjPMp3MCwNeh+kbQFvkeD21U/JVhBtWVEhLcLtXTTusYhqMLV7htN9EIxF0bFlhY4SQhkWHfKHAZvUr/Ha8LyTQHlFNGBbzN28zId8bT1o5XrlqP4lAHYQI1tFl/eMIFMVTe6xb5syRiHLmdNwl1qVYk4mdasbe9cLpg6P4vCCGtGcmAQDuw/cHKuxE82hkMtRrRAYMFe7tc65Fz99nSXC3+VmSLgYaoALaTIdh8EKuH3K84PNFIYC9njHFvcH/xIyXcpXhsKtp1mvzamkpy+4TBlcK5vQzIztyUirI6RURlRoyrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 28, 2023 at 08:36:43PM +0100, Matthew Wilcox wrote: > On Sun, May 28, 2023 at 09:01:37PM +0800, Muchun Song wrote: > > with *init_net*. If Vasily does not want to bring commit 1d0403d20f6c back, > > this patch LGTM. Otherwise, let's wait for Vasily. > > If we're not going to bring back 1d0403d20f6c then we should > simply revert fc4db90fe71e instead of applying this patch. Initially I was thinking of adding virt_addr_valid() check in the mem_cgroup_from_obj() but it seems like that check is not cheap on arm64. I don't have any quick solutions other than adding a check against init_net in __register_pernet_operations(). I will wait for couple of days for Vasily otherwise I will retry 1d0403d20f6c with the init_net check in __register_pernet_operations().