From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3DFC7EE29 for ; Mon, 29 May 2023 09:05:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 937AC900003; Mon, 29 May 2023 05:05:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E8AA900002; Mon, 29 May 2023 05:05:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D67F900003; Mon, 29 May 2023 05:05:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6EC4F900002 for ; Mon, 29 May 2023 05:05:14 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3986740234 for ; Mon, 29 May 2023 09:05:14 +0000 (UTC) X-FDA: 80842708548.29.9B403C6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 7D20120017 for ; Mon, 29 May 2023 09:05:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HK7x766l; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685351112; a=rsa-sha256; cv=none; b=r2UEHVLXbK9+q17AjiYPVD4POstoubLGSsbVfxLnPU+aUCrcljIX7MKn3KGWQ36Yq6MDu4 uA3tlflvbf137nUeTy5oljIJCtVn9uJ0+jzV1W3skJHx3Ox+2t2pdcFPLf1RAnTLvMkaSD xQuols/DYEs1I5FbyCXuRv+q+Q52Fho= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HK7x766l; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685351112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SKCN6+rIJbSn4UUW83iTDhQxYZuSyFGccz9+NYMd5cU=; b=6PKeEIs7T92apfMIfmeqKdHiKmLq0nbH7Box8BcWEqXWh1V6zH/ZbApf+IGMbHqJKaFJrf 8XrdfT5jqK6eGdmBf+Hsfm3FTZ/t25m2M1n4fvlVhg0O0OHxYpCqCjp9VgWQzqJvXq8Fff rYXCFxO5uX1gh7Qv1BQ1ZIIF3tbNelg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9157160EE1; Mon, 29 May 2023 09:05:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07B15C4339B; Mon, 29 May 2023 09:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685351111; bh=a0JuTRdYRCCfiZG2Iw5Mnx/pP+lqpKmJlhBMUAjpNL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HK7x766l7V56uon1rxaUzwgAf6cZoaiFKntT9oIUJxtajR+3PG//Zw6INfHkCD7YL Q08U2FLyBg3+kfe2Tj4Uzdb5ybjOQkCRLSyYPdFwuYEjjfPu02YmWt5JjwlaqRnmXL AQ5AknK4p5P3KRaCvVHVc5VKPcSB0QDFqempdzu6KkyNuVEDH24/CCs5oWZYQuDx86 0Yqh1Qvt/hXekeLFe9PhSfU2EQLwzaAcAkUIDdGg3oR4S3/5H1r5X+GshQGCQ8xv9q E03Qku3fBBuqL1ZGrW56JvwgsZcqsqUDiQMZlf8c6ET5O6YRnqxjtwFEz1brANpftN qGWoGIX3/ROEg== Date: Mon, 29 May 2023 12:04:46 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH] mm/mm_init.c: remove free_area_init_memoryless_node() Message-ID: <20230529090446.GK4967@kernel.org> References: <20230528045720.4835-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230528045720.4835-1-haifeng.xu@shopee.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7D20120017 X-Stat-Signature: cpk8odwa9ist6uhhs9barjr6hqsia8ea X-HE-Tag: 1685351112-720436 X-HE-Meta: U2FsdGVkX18xosSM2eiCWKHiA5pZ1NdJFZK2F8m7drzII93S9bYL36Sg8a69F/Oghianh4BEk2qllnt+PtCOWbnCde9cap91alNIj+xd5UVVspTaT3NODx2IheRD9G/rWDKPofpv2liZUVjTmWrUKcirVAfPiNr6evJL66XRwh6mwEPGOfJMZtqjlcPWm5SrFqyJjc4CBskL4noyjT57pfWTJ5QV5bJk6y51zLSJIE3twBQbx8Ax/Djh3V1e0JaWxhm1vRoY5px9e/JjfAvCOZNXmvNVel8yIlqtFWx3/H2vCjY8efUgnKLzzxyjb8tmDEHShMdPsuPGFQk3i6gZN+0IGVxLdDd1/C8y4G9JbFUrd57qXcIFVfdjuMJwUho3sUk368aTheslI6BAcy464+VgCzblekMjHreVUhAQNh7Yx2i4os5GcChS1D8hjdTzhsEzWVJZR+SWznK5moa/HOsa9td+HeRYBwMIpjmbUqMuEnY8Tndm2NyuGjSR3epQHxZCOC+j+l7kwvHjeEB8nI0e278qTzWO0qVG8VDjS0g0dVybNEhN6vEd/rtJftDMf9c5Nk4Vfoj7wf5yvQFBWe2DmdOKihg2BJ6aXcRDNkmZ9HBeFHZnysQOjYHEowUHkmwAa44MawX8cekfQxwQh9MnbV5/+3/+zGxIDlUKmHJkw4kzFKaGBQG2fzeVajNZNmz1NFiuqAoVeHllCqQvzibQ6UeegYndS7ogQOE0VzYMTKIxCCQGTJ1Byc4s4nAevY+rkW0q0rND1HsgN6+U7psRZxrpB094DIyu5zmOKMeD7bgiXWDhWnEzCxyrfV/HCsqipkLhuKCdy84E5CDpO1GPNTd2OG1dOEYBO9GOJCK0LE2G3eclI9+h4DHyFP1LWObOt/Wz3IkLay0bx7YoYxxs4SWsErCKP+ayHfuRQuelR+87ZhTqq+Z+grCbesFd+4uZV7JwUoOr3jjBmUd i5POVOa1 d9Z9SJ8X+6h650N9sXg7vBS4DivIANo7zLmakI4tAOnD+I7S764NvY9w6fBesaSXaUp2h86/LKobX5dmRUHdBe4c4a/pmYV9i909dcSQMhlxMw7OSVydiepPcGhkT8OzlLVjhB+K1HSRpavWuWqIFU61XLg8M1l8M1thr7l7s5gyzNpvz7Wt7OLB2a8R/buBw8o+/pyOdn1LuR2doGAnpTFzgdVl3zRdV09mBum9NvtodGF1Yj150PyUe57f93mYHP273qDOgtv5K2Fa4uCuMHu8QHF9dz/vqmRuWuPe5ULmD4TPz0KPcRLYCfnqk9yHrbMAMdBV60W0uetzOQ2xg4c8dmKa6lGuYASPPBRfa+5PB5G7DZC1XjXwkk2AkQuk1e4+r6jwjI4KmpME= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (added Michal) On Sun, May 28, 2023 at 04:57:20AM +0000, Haifeng Xu wrote: > free_area_init_memoryless_node() is just a wrapper of > free_area_init_node(), remove it to clean up. > > Signed-off-by: Haifeng Xu > --- > mm/mm_init.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 2d91bb52c619..93821824271a 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1752,11 +1752,6 @@ void __init setup_nr_node_ids(void) > } > #endif > > -static void __init free_area_init_memoryless_node(int nid) > -{ > - free_area_init_node(nid); > -} > - > /* > * Some architectures, e.g. ARC may have ZONE_HIGHMEM below ZONE_NORMAL. For > * such cases we allow max_zone_pfn sorted in the descending order > @@ -1867,7 +1862,7 @@ void __init free_area_init(unsigned long *max_zone_pfn) > panic("Cannot allocate %zuB for node %d.\n", > sizeof(*pgdat), nid); > arch_refresh_nodedata(nid, pgdat); > - free_area_init_memoryless_node(nid); > + free_area_init_node(nid); Using a dedicated free_area_init_memoryless_node() wrapper here emphasizes that the node has no memory, but I don't have a strong feeling about keeping it. > > /* > * We do not want to confuse userspace by sysfs > -- > 2.25.1 > -- Sincerely yours, Mike.