From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09568C77B7C for ; Sun, 28 May 2023 05:48:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B047900003; Sun, 28 May 2023 01:48:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13960900002; Sun, 28 May 2023 01:48:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1BF1900003; Sun, 28 May 2023 01:48:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF43F900002 for ; Sun, 28 May 2023 01:48:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 95EAD140327 for ; Sun, 28 May 2023 05:48:15 +0000 (UTC) X-FDA: 80838583350.18.69EF9A1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id CCF43100011 for ; Sun, 28 May 2023 05:48:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="R/fA88QD"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685252893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dn1/VnoKh7k0BFodx8KOntRgQy9RxLUg9iOIy8gu12s=; b=FYBkTwrnCCl7kvG7B1lKqTeAW8BQqAYRzkvLNblVW8P98q+RwFU+OHThMBEdVUf0m1y9yP iq3CLRu46F6CVcc37l2wrCiWhTzuwBaTEP1Lk4Tiqh0pKkwXh+OXZtVTCqh665BrHyn90E BzkdaX9lOfXNI6ckSOtjsO44FeIvZEQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="R/fA88QD"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685252893; a=rsa-sha256; cv=none; b=SsMKdMPK8nYbF1f1qB2I7DFPtngl7k0nUQM59o60+gznhIjuiCnBhTSJUDhSiELnuI5XB1 wFcqcjzDAXRKNM1TZUI2GbctP0fCYRuR5bYWv+IZ7z1k+9ekaOwM9B48AYg5yTaBza5Y9y kCDI7ckerTsQpxy4DQfC7MfQ6BJcA24= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7A4B60B63; Sun, 28 May 2023 05:48:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2385C433D2; Sun, 28 May 2023 05:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685252892; bh=bkuMHroVl9TlOSFo6p59v17X6rAsvGxb3kzfT5vZogM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/fA88QDLAPfI5+3dlnjis0mHISdgNRk033rp1tEp/+Mnh4pdPF6GyqhT2d0f44ZM O9W0HkIZYw4XGrrX1f3tUzE0jNE3oALs8Cn992s+EfmiHsu8hfXhu3DkQX9TcwN2oj 7E7N3KWaDItcFkwUQzuLHOiQy27MUurhgxG80g7TkNYefeCpTsWvx1dhgZiE8imgx7 3iInnTBsRh7R7es7uW5hUx43VvmKiGSLfYpxMoZFKFBm9CDY8XYAON1aC4gzYndzuk JoH7BurJumWuV7HAw5lKspfn5I/oVTTKuKbhXpKROtOf7xIXSt3aAHLO5P0Ikkt3g7 bN8aIuRcKOvMA== Date: Sun, 28 May 2023 08:47:45 +0300 From: Mike Rapoport To: Matthew Wilcox Cc: Vishal Moola , Andrew Morton , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 05/34] mm: add utility functions for ptdesc Message-ID: <20230528054745.GI4967@kernel.org> References: <20230501192829.17086-1-vishal.moola@gmail.com> <20230501192829.17086-6-vishal.moola@gmail.com> <20230525090956.GX4967@kernel.org> <20230525202537.GA4967@kernel.org> <20230527104144.GH4967@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CCF43100011 X-Stat-Signature: tzhf81ryjmswr7e5ad1e3nuatfpxqer4 X-HE-Tag: 1685252893-395028 X-HE-Meta: U2FsdGVkX19k191Z2teGpqchBD6pC8kIcGr3BnyYFPbnmA2amWbfq6JmHza38eAr42U3t+7XPuZq9pUpTf5c/qPQnMrc84YbtnA48iIFGvonjwu8xodMtkO33DpS4UFifNz0HVbAYu7hY5wAkWlJ/G0UvjCYSCG6mumZQY4gHiCvcDFCKL2DbNuIwDlm7pz1WYRqNaT8P2fqTZDgg9+NHJ71aCWwYhHHcE3ETYGZ2GLcJ2qJ2gl+LkjcPkSgSSUurGx52upltQjL4XCGbHgOztpR84iIs4WAdr7OkONWgCF9Ciu8SqmxcReORt8gRYv+TCttgQZqxqWI2v1Um3h7BHFP02PNfDYuE4hxYeazuJzXpmMn6AQUil5Sou2DnXELo2VYn/VrdZAb3tixML2xIGovWNbZGWspD59UtpvwmgCjY3tisdjC4zwhIVrZsT53WQcElgJI+NS1hyFm4EMcelAJx60SSSNl8P3TVnxMs7dNQehQHPW0YxBlGISfCoVIpVDy3ONDCRfJflCWVMrGZHrAStxhHqhuejAanIv735Om8w0KyPkUTtKu59rPzSGp6RP/dZ1yRTwgDTf7jO4wwBMFh/FXbdn9U7mjqtdGmGbmWfRxp450JMTDl6rgtOB8A3KRcVgzUDaRoEVAQc+IIP5tqKSInnZINX2C41moUdDECYeZDOaEaLNnziH6jlvtKvTDDxuUJHE3tXSmAoHoDkhhTA81irzC6FrLJIxNCP7hxLm89TPNLis/NuHztIICwMOkZl2z2KyPbcftBBvAI4jAVs12hWKolj6/a5xiubdJ7brWL/k6mQWhYyUJiUeWMrUfrG70cK20vpo3sj0DiiKa8VTtDqt70lUthnITahEhBN9V1xO6rDl0MSiwD+X0UHAbFodq0W1cLTr6UVgnc/se4tg9iz+SM9vdebjWFkMnIWlqiaS9o5zrJHDPaHS/CRLqbzNnrtcXOhvAZ6i VLVnysrP h4f4mEDexTqLCzDLbamBo+ay79JsM3u5wqI3DOGWddxui0TVrNmqPW+aHDSVGd+b3b68bmuDsrgCtFCtZ9dBEH12/ssY56HpJbvlbwfmMtUPkUesE/7rWN06CCzeK0O7AXLMvvNLcZR/U4EaCDGXk1XlwI2VOoFUXTTQk7RBI11XRzklgQ1iBKFuuc+jN7NBbOGkwpBWMEElkI+d5RcZb/j5ndnU0D4Rt6WGqKXMSYY04wLxXbEktWoQX8okBi2HGayLOw7tsMT1jZjOOiWOUl2s3wttfvQqM8rpSJkggiAPBrUO2J68+iYxAOHazW+ZEo6YaHrA2fCZtb4nYxBSgU9rsW3Nyus6q92OenfwHQ+KwSF0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 27, 2023 at 04:09:31PM +0100, Matthew Wilcox wrote: > On Sat, May 27, 2023 at 01:41:44PM +0300, Mike Rapoport wrote: > > Sorry if I wasn't clear, by "page table page" I meant the page (or memory > > for that matter) for actual page table rather than struct page describing > > that memory. > > > > So what we allocate here is the actual memory for the page tables and not > > the memory for the metadata. That's why I think the name ptdesc_alloc is > > confusing. > > But that's going to be the common pattern in the Glorious Future. > You allocate a folio and that includes both the folio memory descriptor > and the 2^n pages of memory described by that folio. Similarly for all > the other memory descriptors. I'm not arguing with that, I'm not happy about the naming. IMO, the name should reflect that we allocate memory for page tables rather than for the descriptor of that memory, say pgtable_alloc() or page_table_alloc(). -- Sincerely yours, Mike.